From tolga.dalman at googlemail.com Mon Aug 11 06:24:03 2014 From: tolga.dalman at googlemail.com (Tolga Dalman) Date: Mon, 11 Aug 2014 13:24:03 +0200 Subject: [crossfire] [PATCH] Crossfire client linking fails in trunk Message-ID: <53E8A7D3.5080902@googlemail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, the attached patch fixes the client compilation on trunk. Thanks! Best regards, Tolga Dalman -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJT6KfTAAoJEATLYSm2cxP9+0wH/2rZUtHHdft7XYFv59xHBdmT n1m+k6Ppvk+cCuPliNnPG1Nq3UoL5WXNJw0L01VyOd/S8Jg7X/zSsCVmsqRoxCJB 0TReIWdKy7wuX7e0/KUCl9I6NayZjsPOTOqkXoYNQNOFX8tSqCxE6Y3czHMWE+3Y PP9stmxthJKDiTCTN56z4EqhrwSEfuKAbEk7M+hEt3Z0jrtDc0ASvFIKi5mNBxGi 0WlXeLief/QL+mnSWuY0ijO3XmSpruYnK5U4N+Kfz6SgUt56q2Wx9EmkQhTHWAjC oSEe9DBE9KDcEXo/cuDWLgIKti849D+WRRSm4sbUaTBrnQ0iGIUIomgSyiUlZhk= =n/VL -----END PGP SIGNATURE----- -------------- next part -------------- A non-text attachment was scrubbed... Name: crossfire-client-glib.patch Type: text/x-patch Size: 711 bytes Desc: not available URL: From kevinz5000 at gmail.com Mon Aug 11 09:24:29 2014 From: kevinz5000 at gmail.com (Kevin Zheng) Date: Mon, 11 Aug 2014 09:24:29 -0500 Subject: [crossfire] [PATCH] Crossfire client linking fails in trunk In-Reply-To: <53E8A7D3.5080902@googlemail.com> References: <53E8A7D3.5080902@googlemail.com> Message-ID: <53E8D21D.8010308@gmail.com> On 08/11/2014 06:24, Tolga Dalman wrote: > the attached patch fixes the client compilation on trunk. Thanks! Committed in r19602 with minor changes, thanks! Have you tried the CMake build system? I intend to support both Autotools and CMake for the next release, but start to phase out the former in the distant future. Thanks, Kevin Zheng From tolga.dalman at googlemail.com Mon Aug 11 14:16:36 2014 From: tolga.dalman at googlemail.com (Tolga Dalman) Date: Mon, 11 Aug 2014 21:16:36 +0200 Subject: [crossfire] [PATCH] Crossfire client linking fails in trunk In-Reply-To: <53E8D21D.8010308@gmail.com> References: <53E8A7D3.5080902@googlemail.com> <53E8D21D.8010308@gmail.com> Message-ID: <53E91694.7060302@project-psi.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/11/2014 04:24 PM, Kevin Zheng wrote: > On 08/11/2014 06:24, Tolga Dalman wrote: >> the attached patch fixes the client compilation on trunk. Thanks! > > Committed in r19602 with minor changes, thanks! Great! > Have you tried the CMake build system? I intend to support both Autotools > and CMake for the next release, but start to phase out the former in the > distant future. CMake is definitely the way to go. Unfortunately, it doesn't yet work as expected. [ 7%] Building C object common/CMakeFiles/cfclient.dir/client.c.o /home/tdalman/src/crossfire/client/trunk/common/client.c: In function 'init_connection': /home/tdalman/src/crossfire/client/trunk/common/client.c:344:21: error: storage size of 'hints' isn't known struct addrinfo hints; ^ A quick analysis shows the reason explained here: https://stackoverflow.com/questions/12024703/why-cant-getaddrinfo-be-found-when-compiling-with-gcc-and-std-c99 Naturally, I would compile with -std=gnu99, but that's not a portable solution :) /home/tdalman/src/crossfire/client/trunk/common/client.c:497:5: warning: implicit declaration of function 'freeaddrinfo' [-Wimplicit-function-declaration] freeaddrinfo(res); ^ Don't know, what this is. Probably a follow-up error from above. I also noticed that is not included first in this file - this could lead to further errors. /home/tdalman/src/crossfire/client/trunk/common/client.c: In function 'negotiate_connection': /home/tdalman/src/crossfire/client/trunk/common/client.c:578:9: warning: implicit declaration of function 'usleep' [-Wimplicit-function-declaration] usleep(10*1000); /* 10 milliseconds */ ^ is not included. Best regards Tolga Dalman -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJT6RaUAAoJEATLYSm2cxP9QYAH/RkhjqaAPkKPe6fsrHCLukwc 2NCzKgE5tSg31V2bKZ1MSTs9QUoA7nT5W76pl0xkwJEcPvGkxWTUbHsI8y6Q7qqx BcdqAxpT/lwUaMOjzSLP7KxkFPXEYKCYxm6qDkopMBLT/dK0MvKwohu5EYMPkNcO nlLaCTfRLN11O4lWT/T7iW/0h11cB2qpLl6u9FkPqZgNBbsiXKeOIFCUrJLiAI6G yo27jrg/tj1YLbiUKsD3GwA49oUUFswDwteu1g/dRH7t58d/2pImtrSmtWpwN782 pZ5BY+WWcuRmtfR4b2/aPcXsUmFL4RQGnXXLB0NXVrkUXXfmLqwRHCOkdMv20Q4= =1Q5L -----END PGP SIGNATURE----- From kevinz5000 at gmail.com Mon Aug 11 21:42:34 2014 From: kevinz5000 at gmail.com (Kevin Zheng) Date: Mon, 11 Aug 2014 21:42:34 -0500 Subject: [crossfire] [PATCH] Crossfire client linking fails in trunk In-Reply-To: <53E91694.7060302@project-psi.org> References: <53E8A7D3.5080902@googlemail.com> <53E8D21D.8010308@gmail.com> <53E91694.7060302@project-psi.org> Message-ID: <53E97F1A.5070508@gmail.com> On 08/11/2014 14:16, Tolga Dalman wrote: > CMake is definitely the way to go. Unfortunately, it doesn't yet work > as expected. > > [ 7%] Building C object common/CMakeFiles/cfclient.dir/client.c.o > /home/tdalman/src/crossfire/client/trunk/common/client.c: In function > 'init_connection': > /home/tdalman/src/crossfire/client/trunk/common/client.c:344:21: error: > storage size of 'hints' isn't known > struct addrinfo hints; > ^ > > A quick analysis shows the reason explained here: > > https://stackoverflow.com/questions/12024703/why-cant-getaddrinfo-be-found-when-compiling-with-gcc-and-std-c99 > > Naturally, I would compile with -std=gnu99, but that's not a portable > solution :) Actually, the current `configure` script already adds "-std=gnu99" or some variant thereof behind your back. While getaddrinfo(3) is a POSIX extension, it is still relatively portable. On Windows, this issue is taken care of with a few preprocessor definitions. In the distant future I may rewrite parts of the client to use the GLib networking routines, which is portable thanks to the library. It may not even be this problem at all. I need to go take a closer look at the code; it may be just that we're missing a header file. > /home/tdalman/src/crossfire/client/trunk/common/client.c:497:5: warning: > implicit declaration of function 'freeaddrinfo' [-Wimplicit-function-declaration] > freeaddrinfo(res); > ^ Ditto, although I'm fairly certain this is due to a missing header. > /home/tdalman/src/crossfire/client/trunk/common/client.c: In function > 'negotiate_connection': > /home/tdalman/src/crossfire/client/trunk/common/client.c:578:9: warning: > implicit declaration of function 'usleep' [-Wimplicit-function-declaration] > usleep(10*1000); /* 10 milliseconds */ > ^ > > is not included. Fixed locally but not committed yet; I want to do all the header fixes in one go. Thanks, Kevin Zheng From kevinz5000 at gmail.com Mon Aug 11 21:49:29 2014 From: kevinz5000 at gmail.com (Kevin Zheng) Date: Mon, 11 Aug 2014 21:49:29 -0500 Subject: [crossfire] [PATCH] Crossfire client linking fails in trunk In-Reply-To: <53E91694.7060302@project-psi.org> References: <53E8A7D3.5080902@googlemail.com> <53E8D21D.8010308@gmail.com> <53E91694.7060302@project-psi.org> Message-ID: <53E980B9.40606@gmail.com> Hi Tolga, Sorry for the follow-up. On 08/11/2014 14:16, Tolga Dalman wrote: > /home/tdalman/src/crossfire/client/trunk/common/client.c: In function > 'negotiate_connection': > /home/tdalman/src/crossfire/client/trunk/common/client.c:578:9: warning: > implicit declaration of function 'usleep' [-Wimplicit-function-declaration] > usleep(10*1000); /* 10 milliseconds */ > ^ > > is not included. I haven't had the opportunity to clean up the maze of #include's in the client source code. It appears that 'client.c' includes 'client.h', which in turn includes 'client-types.h'. This file includes conditionally, when HAVE_UNISTD_H is set (presumably for portability). How are you building the client? Which operating system/environment? Could you pastebin an entire copy of your build log? Thanks, Kevin Zheng From tolga.dalman at googlemail.com Tue Aug 12 03:12:28 2014 From: tolga.dalman at googlemail.com (Tolga Dalman) Date: Tue, 12 Aug 2014 10:12:28 +0200 Subject: [crossfire] [PATCH] Crossfire client linking fails in trunk In-Reply-To: <53E97F1A.5070508@gmail.com> References: <53E8A7D3.5080902@googlemail.com> <53E8D21D.8010308@gmail.com> <53E91694.7060302@project-psi.org> <53E97F1A.5070508@gmail.com> Message-ID: <53E9CC6C.3000300@project-psi.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/12/2014 04:42 AM, Kevin Zheng wrote: > On 08/11/2014 14:16, Tolga Dalman wrote: >> Naturally, I would compile with -std=gnu99, but that's not a portable >> solution :) > > Actually, the current `configure` script already adds "-std=gnu99" or some > variant thereof behind your back. While getaddrinfo(3) is a POSIX > extension, it is still relatively portable. On Windows, this issue is taken > care of with a few preprocessor definitions. What configure script ?? I just did $ mkdir build; cd build; cmake ..; make > It may not even be this problem at all. I need to go take a closer look at > the code; it may be just that we're missing a header file. > >> /home/tdalman/src/crossfire/client/trunk/common/client.c:497:5: warning: >> implicit declaration of function 'freeaddrinfo' >> [-Wimplicit-function-declaration] freeaddrinfo(res); ^ > > Ditto, although I'm fairly certain this is due to a missing header. Yes, replacing std=c99 by std=gnu99 defines the necessary POSIX extension macros and, thus, fixes all errors. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJT6cxsAAoJEATLYSm2cxP9yzAH/2186LXDDXT65vVDw8Gt6Fol QeVls90TagNp75bXx5YARTO2gaFi+s8QUBnm5LafIVQZqY7wTn5tq1sc70q7CA7l BFzGKaKmtaB0iUVtrPM6GGPSf6jTK6g2xIhvcwHMgXj435bVeMlKk2VK3jMAzIQ5 l1xmpaEYlqFkuZdHaEj221o2+VM6XTN+9YV7MUwq3Xu0qbhBO+PNYWSzN3NCFIC9 zfhXcbTsPph60GIVLpI2un6SXiwMI/qAuXY7UJhBTlYbImLDtTxJUlB20qCuUpFl gMcdnQJlVq3GQgmLluQT3nzt7STUiDKotwnKGaaohMwMwTePrYwuLjuBpYtK30I= =L3xX -----END PGP SIGNATURE----- From kevinz5000 at gmail.com Wed Aug 13 15:07:03 2014 From: kevinz5000 at gmail.com (Kevin Zheng) Date: Wed, 13 Aug 2014 15:07:03 -0500 Subject: [crossfire] [PATCH] Crossfire client linking fails in trunk In-Reply-To: <53E9CC6C.3000300@project-psi.org> References: <53E8A7D3.5080902@googlemail.com> <53E8D21D.8010308@gmail.com> <53E91694.7060302@project-psi.org> <53E97F1A.5070508@gmail.com> <53E9CC6C.3000300@project-psi.org> Message-ID: <53EBC567.5080702@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/12/2014 03:12, Tolga Dalman wrote: >> Actually, the current `configure` script already adds >> "-std=gnu99" or some variant thereof behind your back. While >> getaddrinfo(3) is a POSIX extension, it is still relatively >> portable. On Windows, this issue is taken care of with a few >> preprocessor definitions. > > What configure script ?? I just did > > $ mkdir build; cd build; cmake ..; make The `configure` script from Autotools, not CMake. > Yes, replacing std=c99 by std=gnu99 defines the necessary POSIX > extension macros and, thus, fixes all errors. If the code compiles correctly using "-std=gnu99", then use it. While portability is definitely a desirable, it's probably better done along with some other massive change (i.e. GIO networking). Thanks, Kevin Zheng -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJT68VnAAoJEOrPD3bCLhCQLG4IAKmxxcI6c1X14iG3iGqkn0XB 7nTchsmUiDdM0wyhxxUOAjdw0GG6Hx474yR1nh1wZwQkmiVHYxQbGV7fpVrGnPXx IouDiTBH2ZSlmfxVZVMrXhwUy3bmcaXTTZHG07jCMduQvsZZFg7pa7mm5gz9qg/3 zFegVmm/sPLLxUNR8ClqFLNEXZB1VXCmgtT8t2rCmoe7qCcnUc7Rq0Gqp0coEVt7 GoHWlsvTsawwcUTSoU5wJzv9gKwmflW0xD0wZ/hEBhxW3lpOfT2OK9fpfMdxyYly ggYbKL2+6aqqsygg+FwvGYYGdKtCkIFEymXVyCsoZlxH4aKgOQ8Tnz/f1Ald5yo= =jguB -----END PGP SIGNATURE----- From davidnicholashurst at gmail.com Wed Aug 13 18:53:12 2014 From: davidnicholashurst at gmail.com (David Hurst) Date: Thu, 14 Aug 2014 09:53:12 +1000 Subject: [crossfire] Fwd: Review your Google Analytics website performance for July In-Reply-To: <6f42d3c46a8360e0.1407948846409.435301.377202.en.6d9ccbebbed90a65@google.com> References: <6f42d3c46a8360e0.1407948846409.435301.377202.en.6d9ccbebbed90a65@google.com> Message-ID: Hi Team, Just FYI I thought people might be interested in the latest analytics on the wiki page. Saru ---------- Forwarded message ---------- From: Google Analytics Date: Thu, Aug 14, 2014 at 2:54 AM Subject: Review your Google Analytics website performance for July To: davidnicholashurst at gmail.com [image: Google Analytics] Your Customer ID: wiki.metalforge.net Sign in A snapshot of your website in July. Take a few minutes to review last month's website performance for *http://wiki.metalforge.net*. We hope that these key metrics and our monthly tip will help you identify new opportunities for your business. VISITS 312 The total number of visits to your site this month BOUNCE RATE 65% Your bounce rate shows how many people leave your site without visiting any other pages on your site TIME ON SITE 03:04 The average amount of time someone spends on your site in a single session AVERAGE PAGES 3 The average number of pages viewed in a single session Did you know you had 312 visits this month? Keep an eye on your All Traffic report to see exactly where your visitors come from so you can make tweaks to your marketing campaigns. Sign in Your Audience TOP COUNTRIES TOP COUNTRY *90 Visits* United States *18 Visits* Switzerland *15 Visits* France *15 Visits* Germany *15 Visits* Portugal Your Location report tells you where your visitors live around the world. Make sure you?re promoting your business in all the right areas. View your Location report How people are finding you TOP KEYWORDS crossfire wiki real time 3 Visits crossfire game install cen ... 2 Visits crossfire debian install 1 Visits http://www.mixxx.org/wiki/ ... 1 Visits make server crossfire 1 Visits ADWORDS VISITS 0 AdWords Visitors 312 Non-AdWords Visitors 312 Total Visitors [image: 547 New Visitors / 547 Return Visitors] Did you know you can attract more potential customers to your site with paid online ads? Learn more about how Google AdWords can help. Sign up for AdWords TOP SOCIAL SOURCES 100% WordPress 0% 0% 0% 0% TOP REFERRERS google / organic *167 Visits* crossfire.real-time.com / referral *87 Visits* (direct) / (none) *34 Visits* bing / organic *6 Visits* meomotsachvn.wordpress.com / referral *4 Visits* What?s happening when users come to your site TOP PAGES Visits /doku.php/linu ... /doku.php /doku.php/faq /doku.php/serv ... /doku.php/cros ... Pageviews Page Exits 41 EXITS Did you know that *41 (13.1%)* people exited your site at /doku.php/linux ? View your Exit Pages Your Goals NO GOALS SET UP YET 0 Use goals to track customer interactions that matter to your business the most, such as purchases or number of pages viewed. ABANDONMENT RATE 0% The percentage of people who start but do not complete one of your goals Your goals completion sources Looks like you don?t have any Goals set up yet. Use Goals to keep an eye on customer actions that matter to you, like clicks and sales. Set up Goals Thank you for reviewing our report. Please take a few minutes to provide feedback . Go to your account Join the Community Ask Experts Learn ? 2014 Google Inc. 1600 Amphitheatre Parkway, Mountain View, CA 94043 This email was sent to davidnicholashurst at gmail.com because you indicated that you'd like to receive updates and tips about your Google Analytics account. If you don't want to receive such emails in the future, please unsubscribe here . You can also change your preferences on your account's Google Analytics Email Communications page by logging into https://www.google.com/analytics/settings/my_account -------------- next part -------------- An HTML attachment was scrubbed... URL: