From pc-crossfire06 at crowcastle.net  Sun Oct 22 14:22:15 2023
From: pc-crossfire06 at crowcastle.net (Preston Crow)
Date: Sun, 22 Oct 2023 15:22:15 -0400
Subject: [crossfire] Server log messages
Message-ID: <1517861a-c021-47b8-ad38-37e4dd69a9b2@crowcastle.net>

I'm seeing some server log messages that seem to indicate a need to 
clean stuff up:

23/10/22 13:46:18 [DD] archetype exceptional beauty has nrof set to 4, 
which will be ignored
23/10/22 13:46:18 [DD] archetype flawless beauty has nrof set to 4, 
which will be ignored
23/10/22 13:46:18 [DD] archetype Blessedness has nrof set to 10, which 
will be ignored
23/10/22 13:46:18 [DD] archetype Assassinating Dragons has nrof set to 
10, which will be ignored
23/10/22 13:46:18 [DD] archetype Assassinating Trolls has nrof set to 
10, which will be ignored

I think those are from the artifacts file, and I would remove the nrof 
entries, but I'm afraid they might be used somewhere despite the message.

Also at startup:

[DD] Artifact with no chance: white leather
[DD] Artifact with no chance: black leather
[DD] Artifact with no chance: Sirens

[DD] Monster Valkyrie has hp set higher than maxhp (350>0)
[DD] Monster Belzebub has hp set higher than maxhp (20000>15000)
[DD] Monster cave byakie has hp set higher than maxhp (10000>8000)
[DD] Monster twisted sprite has hp set higher than maxhp (5500>4000)

The HP higher than max might be an error, but it does block some 
healing, so it might be intentional.  I also see similar messages on 
some map loads where I assume the correct answer is to also set maxhp to 
match hp (e.g., Beserker on /scorn/oldcity/oldcity54)

And on some map loads:

23/10/11 14:03:26 [DD] citylife: adding 6 NPC to map /world/world_105_116.
23/10/11 14:03:26 [DD] Merged duplicate skill skill_use_magic_item for 
farmer

23/10/11 14:03:26 [DD] citylife: adding 5 NPC to map /world/world_105_115.
23/10/11 14:03:26 [DD] Merged duplicate skill skill_use_magic_item for man
23/10/11 14:03:26 [DD] Merged duplicate skill skill_use_magic_item for man
23/10/11 14:03:26 [DD] Warning: Tried to insert object wrong part of 
multipart object.
23/10/11 14:03:26 [DD] Warning: Tried to insert object wrong part of 
multipart object.
23/10/11 14:03:26 [DD] Warning: Tried to insert object wrong part of 
multipart object.

23/10/11 14:08:14 [DD] load_objects on /scorn/misc/battle_arena/entrance 
took 5679 us
23/10/11 14:08:14 [DD] Merged duplicate skill skill_use_magic_item for 
ticket vendor

I think the duplicate skill has something to do with 'race human,' but I 
didn't find it.

And over two thirds of the messages in my log are starting the 
Move_Fog.py and Moving_Fog.py scripts (2.2 out of 2.8 million lines).  
It may be a good idea to only issue log messages for python scripts that 
fail or have some output.