- On second thought, its more future-proof to use the GTK type than to use
the GDK type for treeview allocation in on_spell_window_size_allocate().
1 lines of code changed in 1 file:
- It has been pointed out that on_spell_window_size_allocate() was written
with a non-portable structure reference (offended target: Sun). Fix the
structure reference to use the base GDK type only, and comment on the
equivalence of GdkRectangle and GtkAllocation.
5 lines of code changed in 1 file:
- Change comment text to better fit current spells dialog implementation.
1 lines of code changed in 1 file:
- Tab to spaces, end-of-line whitespace removed.
- Minor whitespace reformat of some tabular code.
63 lines of code changed in 1 file:
- Formatting of comments / function parameters only. No functional change.
24 lines of code changed in 1 file:
- Remove comment text that is no longer pertinent since the descriptions are
now handled by a single cell renderer.
1 lines of code changed in 1 file:
- Remove commented out abort();
0 lines of code changed in 1 file:
- Remove extra blank line.
- Fix spelling and capitalization in comments.
- Format block comments more consistently to use less vertical space. etc.
128 lines of code changed in 1 file:
- Tabs to spaces and associated indentation fixes.
11 lines of code changed in 1 file:
- End-of-line whitespace and extra blank lines removed.
6 lines of code changed in 1 file:
- Since this is a C project, rename AM_CPPFLAGS to AM_CFLAGS.
2 lines of code changed in 1 file:
- Update to add a new function in spells.c that redraws the spell information
to optimize use of space when the dialog content and/or size is changed.
1 lines of code changed in 1 file:
- The prior implementation instantiated a cell renderer for each spell listed
in the dialog, but a single renderer behaves the same as multiple renderers
in this dialog, so there is no need to waste resources on more than one.
- The description cell data function is only needed to create row-specific
renderers, so it is removed in favor of using the size-allocate signal
handler to apply updates to the description column wrap-width.
- Comments for several global variables are added or improved.
31 lines of code changed in 1 file:
- The spells dialog description text now dynamically reflows text and adjusts
row height when the window is re-sized by the user.
32 lines of code changed in 2 files:
- Fix indentation error.
39 lines of code changed in 1 file:
- Remove silly mis-typed pointer type and unnecessary cast from spells.c.
2 lines of code changed in 1 file:
- The spells dialog now defaults to wrap the description at 300 pixels or so
as before, but dynamically re-calculates the wrap width based on the dialog
width and the width of the other columns. Presently the code does not
reclaim extra vertical height when the dialog is widened, so the dynamic
wrap is a bit pointless except for shrinking the dialog down. More work is
needed to get the description field to shrink vertically.
- Three of the columns now have their values centered under the column title
to try to improve aesthetics.
- The SP/Mana column title is renamed "Cast/Cost" as SP/Mana was redundant and
Grace was unmentioned. This new title also goes along with Spellmon 2
changes in the pipeline that support setting ingredients as additional
casting costs. Ingredient data is expected to merge with the mana/grace
data in this dialog, and go in the same column as mana/grace cost.
103 lines of code changed in 2 files:
- Move a widget pointer assignment closer to its point of use improve code
readability and consistency with code elsewhere. No functional change.
2 lines of code changed in 1 file:
- Spell dialog data is now top, right aligned so that details are at the top
of the cell and lined up with the first line of the description.
- Auto-wrap the description to a fixed width. Though a dynamic, or user
settable width would be better, this at least returns the dialog to a
state similar to how it was prior to removal of line breaks from the spell
description text in the archetypes. Ideally, more work to improve the wrap
will be done, but lets lock in this fix for the time being.
24 lines of code changed in 2 files:
- Non-functional whitespace, comment, and formatting changes only.
Some local variables in functions swapped order for readability.
191 lines of code changed in 1 file:
- make proto is broken again (at least on some systems) due to -pthread
getting on the cproto command line and being misinterpreted as command
options: cproto: invalid option -- 'h'. This was fixed before by taking
out PTHREAD_CFLAGS, but it has crept back via some other make variable.
A workaround is added, but is commented out because it uses a GNU make
extension that is not portable. What constitutes a portable way to filter
out -pthread if it occurs?
14 lines of code changed in 1 file:
- Update to add new function in account.c.
1 lines of code changed in 1 file:
- Fix client malfunction on [X] closing of account system dialogs. Though the
dialogs have the Deletable property set to No, some window managers do not
honor this setting, and put the [X] close icon on the window frame. Added
new on_window_delete_event() callback and connected it to all of the account
system dialogs so their delete_events are trapped and ignored. The dialogs
now only dismiss in the manner the designer intended.
35 lines of code changed in 2 files:
- Remove warning: old-style function definition
8 lines of code changed in 1 file:
- Whitespace, margin, and comment reformat only. No functional change.
Cuddle function names with opening parenthesis. Add doxygen comment headers
for functions. Add doxygen @param throughout. Cuddle doxygen parameter
description with parameter. Reformat comments to make better use of line
width. Capitalization. Collapse consecutive empty lines to single line.
Remove end-of-line whitespace, and excessive intra-line whitespace, etc.
428 lines of code changed in 1 file:
- Add the msgctrl_window to the list of dialogs that need special settings.
- Add a note on the importance of setting the Deletable property to No, and
connecting the delete events of all dialogs to gtk_widget_hide_on_delete().
13 lines of code changed in 1 file:
- Fix segfaults and/or client malfunctions when [X] closing the about and
message control dialogs under window managers that do not honor setting
the GTK deletable property to No.
20 lines of code changed in 3 files:
- Fix segfault and/or client malfunction when [X] closing the keybinding
dialog on window managers that do not honor setting its GTK deletable
property to No.
19 lines of code changed in 2 files:
- Fix client malfunction when [X] closing the configuration dialog under
window managers that do not honor setting its GTK deletable property to No.
12 lines of code changed in 2 files:
- Fix segfault when [X] closing the spells dialog under window managers that
do not honor setting the GTK deletable property of the dialog to No.
11 lines of code changed in 2 files:
- Fix segfault when [X] closing the skills dialog under window managers that
do not honor setting the deletable property of the dialog to No.
7 lines of code changed in 2 files:
- Style, formatting, and whitespace changes only. No functional change.
107 lines of code changed in 1 file:
- Make all the account-related dialogs non-deletable.
4 lines of code changed in 1 file:
- Change the dialogs.glade design up to support GTK 2.16 and let Glade-3
reorder orientation properties to amuse itself. It also automatically added
more properties in various places... hopefully all sane changes.
- Set the login dialog deleteable property to false so (some) window managers
do not show the [X] close icon. The client can't handle the dialog being
closed. This is a partial fix only. Some window managers (or whatever) do
not honor the GTK property.
- Clean up a widget name in the config dialog.
- Summarize .glade file mods in the ChangeLog.
32 lines of code changed in 2 files:
- Fix id strings with trailing spaces. The Glade editor used previously had
a GUI issue that caused these. Apparently some problems occurred before
it was realized the items were being generated with trailing spaces.
2 lines of code changed in 2 files:
- Prevent royal screw up by Glade 3.6.7 when loading this file. 3.6.7 was
released knowing that it would render vboxes horizontally when the .glade
file was made for GTK < 2.16, and that manual edit/save would be required.
http://mail.gnome.org/archives/gnome-announce-list/2009-June/msg00063.html
50 lines of code changed in 11 files:
- Prevent royal screw up by Glade 3.6.7 when loading this file. 3.6.7 was
released knowing that it would render vboxes horizontally when the .glade
file was made for GTK < 2.16, and that manual edit/save would be required.
http://mail.gnome.org/archives/gnome-announce-list/2009-June/msg00063.html
22 lines of code changed in 1 file:
- The removal of line breaks from the .arc files has made the spells dialog
width explode, so add a comment to the spells dialog code that gives a hint
about making the description line-wrappable. The code is commented because
it wraps at a bad width, but in case I don't get it figured out soon, I do
not want to forget the command.
13 lines of code changed in 1 file: