September 2010 Commit Log

Number of Commits:
63
Number of Active Developers:
2
kbulgrien 2010-09-30 21:32 Rev.: 13950

- Fix doxygen @param warnings for process_race_class_info().

1 lines of code changed in 1 file:

kbulgrien 2010-09-30 21:30 Rev.: 13949

- Fix doxygen @param warnings for metaserver_update_cache().

2 lines of code changed in 1 file:

kbulgrien 2010-09-30 21:27 Rev.: 13948

- Fix doxygen warning: argument 'data' of command @param is not found in the
argument list of FailureCmd().

1 lines of code changed in 1 file:

kbulgrien 2010-09-30 21:24 Rev.: 13947

- Fix doxygen warning: argument 'varargs' of command @param is not found in
the argument list.

3 lines of code changed in 1 file:

kbulgrien 2010-09-30 21:21 Rev.: 13946

- Fix doxygen warnings: Found unknown command `\parm'.

3 lines of code changed in 1 file:

kbulgrien 2010-09-30 21:16 Rev.: 13945

- Fix doxygen warnings: Unsupported xml/html tags found.

8 lines of code changed in 1 file:

kbulgrien 2010-09-30 21:10 Rev.: 13944

- Fix doxygen warnings about unsupported xml/html tags.

2 lines of code changed in 1 file:

kbulgrien 2010-09-30 21:04 Rev.: 13943

- Remove duplicate prototype for draw_ext_info() not needed here as it is in
gtk2proto.h.
- Fix doxygen add_marked_text_to_pane() undocumented parameter warning.

3 lines of code changed in 1 file:

kbulgrien 2010-09-30 20:52 Rev.: 13942

- Resolve a doxygen warning about undocumented parameters, and transfer plain
comments into the @param documentation of drawquarterlightmap_sdl().

18 lines of code changed in 1 file:

kbulgrien 2010-09-30 20:43 Rev.: 13941

- Remove incorrect forward reference to do_clienthelp() to fix doxygen
warning, and remove a doxygen header comment from another prototype.

0 lines of code changed in 1 file:

kbulgrien 2010-09-30 20:32 Rev.: 13940

- Fix doxygen errors (@params vs @param).

11 lines of code changed in 1 file:

kbulgrien 2010-09-29 06:38 Rev.: 13936

- Fix spelling.

11 lines of code changed in 1 file:

kbulgrien 2010-09-28 22:06 Rev.: 13934

- Create doxygen defgroup setups for related definitions.
- Minor reformatting of comments and definitions.
- Convert comments to doxygen style.
- Convert tabs to spaces.

189 lines of code changed in 1 file:

kbulgrien 2010-09-28 01:04 Rev.: 13932

- It's not CVS anymore.

0 lines of code changed in 9 files:

kbulgrien 2010-09-27 21:43 Rev.: 13930

- Add doxygen commenting to describe various functions and data structures.
- Make the music command look more like it is grouped with sound2 by swapping
the order of the commands in the commands[] array.
- Restructure and rewrite various comment texts to improve use of line width
and to improve the text grammar and clarity.
- Comment DoClient() to make it more clear what it does.
- Fix typographical errors.

119 lines of code changed in 1 file:

ryo_saeba 2010-09-26 13:26 Rev.: 13915

Add file.

2 lines of code changed in 1 file:

ryo_saeba 2010-09-26 13:23 Rev.: 13914

Update the number of lists.

1 lines of code changed in 1 file:

ryo_saeba 2010-09-26 13:21 Rev.: 13913

Add an 'unidentified' tab.

24 lines of code changed in 2 files:

kbulgrien 2010-09-25 22:27 Rev.: 13886

- Make it clearer what the setup command "sound 3" means by adding a comment.

10 lines of code changed in 1 file:

kbulgrien 2010-09-25 14:00 Rev.: 13884

- Remove a test that kills off the sound server before it should (now that the
SDL_mixer server basically works with the [obsoleted] sound command data
sent from the client).

0 lines of code changed in 1 file:

kbulgrien 2010-09-25 13:32 Rev.: 13883

- This is a bug-fix for Sound2Cmd() in preparation for implementing sound2
support, and it includes doxygen comments for Sound2Cmd() and MusicCmd()
with formatting changes near play_sound(), Sound2Cmd(), and MusicCmd().
- Improve the sound2 data format description text by using variable names.
- Change the data types of Sound2Cmd values x and y to match server type.
- Fix incorrect data indexing and data smashing in Sound2Cmd, including a
broken sound name length check in Sound2Cmd.
- Improve Sound2Cmd() LOG messages.

64 lines of code changed in 1 file:

kbulgrien 2010-09-23 23:50 Rev.: 13869

- Make common.c a common file instead of maintaining duplicate code in both
common.c and cfsndserv.c.
- Rename soundsdef.h to def_sounds.c throughout to convert the sound data to
a linkable object instead of an include (as part of the transition to use
of common code and data). Create def_sounds.h to support shared use of
the data structure defined in def_sounds.c.
- Create an sndproto.h maintained by `make proto` to maintain prototypes for
shared code.
- Create common.h to support shared use of common.c between different sound
servers.
- Migrate all shared/duplicate definitions in cfsndserv.c and alsa9.c into
common.c.
- Remove duplicate functions from cfsndserv.c.
- Change rcsid_* declaration from static to const to remove a compile warning.
- Add support for using .ogg and .wav extensions in parse_sound_line() when
SDL_mixer is used to support sound.

190 lines of code changed in 6 files:

kbulgrien 2010-09-23 23:33 Rev.: 13868

- Modify the script to produce the def_sounds[] array in a .c file instead
of a .h file so that the data can be compiled to a .o for use in multiple
.c files that make up a sound binary.
- The script now also produces a .h file that contains and extern prototype
for def_sounds[].

0 lines of code changed in 2 files:

kbulgrien 2010-09-23 19:04 Rev.: 13867

- Synch init_sounds() and SoundCmd() with cfsndserv.c. This is a formatting
change only.

65 lines of code changed in 1 file:

kbulgrien 2010-09-23 18:55 Rev.: 13866

- Sync common.c write_settings() and read_settings() with cfsndserv.c. This
is a formatting change only.

18 lines of code changed in 1 file:

kbulgrien 2010-09-23 18:34 Rev.: 13865

- Synch parse_sound_line() with cfsndserv.c (oddly, common.c isn't common at
all yet). The code is identical except that an unnecessary else is removed.

158 lines of code changed in 1 file:

kbulgrien 2010-09-22 23:52 Rev.: 13854

- A first run at playing sound effects using SDL_mixer. It mixes sounds over
another playing "song", but doesn't yet seem to work with the client, so
more work is needed. Getting this far, it looks like the cfsndserv overhead
is kind of a waste. SDL_mixer handles a lot of the issues the fd driver
code had to manage on its own. Also, noted, use of fork means that Windows
use is probably not viable even if SDL_mixer is cross-platform.
- Added tracking for SDL_mixer "Mix_Chunk"s which contain sounds to mix.
- Transitioned back to using .ogg files as converting a bunch of .wav to .ogg
is trivial with oggenc. .oggs are half the size of .raw, and a quarter the
size of .wav.
- Add error handling to use of the various SDL_mixer initialization processes.
- Switched from printf to fprintf on stderr for error message output in the
SDL_mixer sound server code.
- Legacy play_sound() was so tied to the fd server that it is ifndef SDL_SOUND
now, and a whole new play_sound() is added to support SDL_mixer use. It is
starting to look like SDL_mixer should be separated as the Alsa9 server is.
- For now, settings.simultaneous sets the number of allocated mixing channels,
and defines a fixed number of Mix_Chunks to manage. This means sounds are
loaded from file each time played.
- Some whitespace changes.

162 lines of code changed in 1 file:

kbulgrien 2010-09-21 22:47 Rev.: 13853

- Mostly whitespace changes and commenting.
- Set up parse_sound_line to convert .raw file extensions to .ogg or .wav when
the SDL_mixer sound support is set up to help with development of the new
server.
- Remove SDL_INIT_VIDEO from SDL_Init() in init_audio() as this server is only
meant to handle audio.
- Add stdin processing to sdl_mixer_server(). This is pretty much a copy of
the code used for the legacy code now in fd_server().

193 lines of code changed in 1 file:

kbulgrien 2010-09-20 23:06 Rev.: 13838

- Improve a debug message in parse_sound_line().
- Remove an unnecessary else in parse_sound_line().
- Comment parse_sound_line() to add doxygen content and describe the parse.
- Change the default signedness for SDL_mixer to match the settings used by
most of the supported sound systems.

128 lines of code changed in 1 file:

kbulgrien 2010-09-18 00:52 Rev.: 13836

- Fix improper use of buffers in Mix_OpenAudio() where a chunksize should be
used instead. The docs say: chunksize is the size of each mixed sample. The
smaller this is the more your hooks will be called. If make this too small
on a slow system, sound may skip. If made to large, sound effects will lag
behind the action more. You want a happy medium for your target computer.
You also may make this 4096, or larger, if you are just playing music.
- Fix ifdef SOUND_DEBUG in main() to not include the return -1 in the event
that a file descriptor is not identifed when the SDL_mixer server is not in
use.
- Resolve a compiler warning by providing a return value in the SDL_mixer
audio_play() function. This function is still a stub, but the return value
is calculated the same as all the other audio_play() functions compute it.

5 lines of code changed in 1 file:

kbulgrien 2010-09-18 00:33 Rev.: 13835

- Extract the "legacy" server code that is based on file descriptors into a
function called fd_server(). The SDL_mixer library is not based on file
descriptors, so no need to blow up main() with a giant if statement to
support the two different types of server.
- Create an sdl_mixer_server() function that will handle sound when the
SDL_mixer library is in use. For now, simply play a sample .ogg file
found in the current working directory, and exit. This just proves that
playing music works, but does nothing to act like the sound server should,
and indeed, it does!
- Add a few SOUND_DEBUG statements to the SDL_mixer init_audio() and
audio_play() functions.

71 lines of code changed in 1 file:

kbulgrien 2010-09-17 23:48 Rev.: 13834

- Indentation fix. Whitespace only.

54 lines of code changed in 1 file:

kbulgrien 2010-09-17 23:15 Rev.: 13833

- Fix assignment of zerolevel used in memset() where 0x8000 was specified
instead of 0x00.
- Move descriptive text into @return documentation for init_sounds().
- Add doxygen header comments to all audio_play() and init_audio()
functions.

16 lines of code changed in 1 file:

kbulgrien 2010-09-17 23:11 Rev.: 13832

- Fix up doxygen comment headers for init_audio() and audio_play().

13 lines of code changed in 1 file:

kbulgrien 2010-09-17 22:51 Rev.: 13831

- Mark init_audio() doxygen @return to indicate what the return value is
supposed to be.

5 lines of code changed in 2 files:

kbulgrien 2010-09-17 22:50 Rev.: 13830

- Explicitly return zero if init_audio() for SDL_mixer started up the sound
stuff okay.
- Mark all init_audio() doxygen @return to indicate what the return value is
supposed to be.
- Remove smash of 'buffers' pointer in SDL_mixer init_audio().

7 lines of code changed in 1 file:

kbulgrien 2010-09-17 21:13 Rev.: 13829

- Fix syntax error in --enable-sdl_mixer related code.

10 lines of code changed in 1 file:

kbulgrien 2010-09-15 23:13 Rev.: 13821

- Clean up the (hastily written/copy/pasted) SDL_mixer init_audio comments and
error messages.

4 lines of code changed in 1 file:

kbulgrien 2010-09-15 23:04 Rev.: 13820

- Replace a comment that was deleted because it was in the wrong place.

1 lines of code changed in 1 file:

kbulgrien 2010-09-15 22:50 Rev.: 13819

- Add the beginnings of SDL_mixer support as a potential solution for cross-
platform sound support that allows mixing sound effects and music.
- Fix spelling and change Couldn't to Could not.

106 lines of code changed in 1 file:

kbulgrien 2010-09-15 22:47 Rev.: 13818

- Whitespace changes. Indentation made consistent. No functional change.
Comments converted to Doxygen style, etc.

229 lines of code changed in 1 file:

kbulgrien 2010-09-15 22:45 Rev.: 13817

- Begin preparations for adding SDL_mixer support for potential cross-platform
sound support that can support mixing music and sound effects.

38 lines of code changed in 1 file:

kbulgrien 2010-09-15 00:01 Rev.: 13816

- Back off the dependency on GTK 2.18.0. The client still has the new
functionality, but compiles and runs fine at GTK 2.14.0. As the lower
limit is not known, return the dependency to 2.0.0 as it was before.

19 lines of code changed in 4 files:

kbulgrien 2010-09-14 02:52 Rev.: 13815

- Fix error compiling with -Wformat -Werror=format-security. Mandriva 2010.1
uses these options by default when building RPMs.

4 lines of code changed in 2 files:

kbulgrien 2010-09-14 01:56 Rev.: 13814

- Take a stab at setting a GTK+2.0 requirement on a minimum of 2.18.0.
- Remove commented out support for old clients.

6 lines of code changed in 1 file:

kbulgrien 2010-09-14 01:25 Rev.: 13813

- Change mixed grave accent and single quoting in a message to use only single
quotes so it doesn't break syntax highlighting in the file.
- Comment rework to fix spelling, etc, and generally fill out formatting to
use more column width. Also deleted what appears to be an extraneous
comment.

41 lines of code changed in 1 file:

kbulgrien 2010-09-14 01:08 Rev.: 13812

- Since someone deleted the x11 and gtk-v1 client codebases, there is really
no point in keeping around the commented out configure support for them.

0 lines of code changed in 1 file:

kbulgrien 2010-09-13 23:04 Rev.: 13811

- Not sure what this is for, but the comment says to update it, so here we go.

0 lines of code changed in 2 files:

kbulgrien 2010-09-13 23:03 Rev.: 13810

- Use the gtk-2.0.m4 macro to test for a usable version of GTK+ 2.0. mmetson
found that build fails on Fedora Core 11. It turns out the spells dialog
uses two functions first provided by GTK+ 2.18.0 in the code that wraps the
description and auto-grows/shrinks the column when the player resizes the
dialog. It is known that one of the calls is pretty easy to rewrite for
build with pre-2.18.0, but converting the other call has not been reviewed.

24 lines of code changed in 2 files:

kbulgrien 2010-09-13 20:01 Rev.: 13809

- GTK 1 is long gone, so replace the macro file with one for GTK 2.

196 lines of code changed in 2 files:

kbulgrien 2010-09-10 20:57 Rev.: 13786

- Whitespace changes. Indentation made consistent. No functional change.
Comments converted to Doxygen style, etc. Minor comment improvements.

747 lines of code changed in 1 file:

kbulgrien 2010-09-06 22:00 Rev.: 13759

- Tabs to spaces, comment restructuring and change to doxygen format including
addition of @param and @return comments for the functions. No code changes.

105 lines of code changed in 1 file:

ryo_saeba 2010-09-04 06:32 Rev.: 13743

Apply patch #2913553: Fix implicit declaration warning Tim Hentenaar.

14 lines of code changed in 2 files:

kbulgrien 2010-09-03 23:49 Rev.: 13722

- Remove warning: function declaration isn’t a prototype

2 lines of code changed in 1 file:

kbulgrien 2010-09-03 23:37 Rev.: 13721

- Remove unneeded cast.
- Replace simple type casts (GtkSpinButton*) and (GtkToggleButton*) with what
appears to be more commonly used notation in GTK code: GTK_SPIN_BUTTON() and
GTK_TOGGLE_BUTTON().

10 lines of code changed in 1 file:

kbulgrien 2010-09-03 23:29 Rev.: 13720

- Remove warning: initialization discards qualifiers from pointer target type

1 lines of code changed in 1 file:

kbulgrien 2010-09-03 23:27 Rev.: 13719

- Remove various warnings about pointer qualifiers:
note: expected ‘char *’ but argument is of type ‘const char *’
warning: assignment discards qualifiers from pointer target type
warning: passing argument 2 of ‘add_to_textbuf’ discards qualifiers from
pointer target type
warning: passing argument 8 of ‘add_to_textbuf’ discards qualifiers from
pointer target type

7 lines of code changed in 1 file:

kbulgrien 2010-09-03 23:07 Rev.: 13718

- Remove warning: function declaration isn’t a prototype

1 lines of code changed in 1 file:

kbulgrien 2010-09-03 23:04 Rev.: 13717

- Remove warning: will never be executed

2 lines of code changed in 1 file:

kbulgrien 2010-09-03 23:02 Rev.: 13716

- Remove warning: cast from function call of type ‘gdouble’ to non-matching
type ‘unsigned int’

2 lines of code changed in 1 file:

kbulgrien 2010-09-03 23:01 Rev.: 13715

- Remove warning: comparison between signed and unsigned integer expressions

1 lines of code changed in 1 file:

kbulgrien 2010-09-03 22:57 Rev.: 13714

- Remove warning: old-style function definition

2 lines of code changed in 1 file:

kbulgrien 2010-09-03 22:53 Rev.: 13713

- Reformat comments to more uniform margins.
- Reformat some long code lines for consistency.
- Minor comment text modifications: mostly capitalization, grammar, and so on.
- Convert TODO/FIXME comments to doxygen style so they show up in generated
documentation.
- Unify the style used for @param comments so they all start the description
on the same line as doxygen @param, et. al., for readability and to use less
vertical space.

137 lines of code changed in 1 file:

August 2010 »

Generated by StatSVN 0.7.0