October 2010 Commit Log

Number of Commits:
88
Number of Active Developers:
6
akirschbaum 2010-10-31 04:27 Rev.: 14044

Rewrite expression.

1 lines of code changed in 1 file:

akirschbaum 2010-10-31 03:59 Rev.: 14043

Simplify code.

3 lines of code changed in 2 files:

meflin2 2010-10-29 12:33 Rev.: 14042

make quite command message more clear

1 lines of code changed in 1 file:

mwedel 2010-10-29 01:13 Rev.: 14041

Add some notes about race/class starting choices with advanced
character creation. Work in progress, but no harm in commiting
documentation as done so far.
MSW 2010-10-28

151 lines of code changed in 2 files:

akirschbaum 2010-10-28 01:14 Rev.: 14040

Suppress warnings.

3 lines of code changed in 3 files:

akirschbaum 2010-10-28 01:11 Rev.: 14039

Update comments.

39 lines of code changed in 3 files:

akirschbaum 2010-10-28 01:04 Rev.: 14038

Whitespace changes.

1 lines of code changed in 2 files:

kbulgrien 2010-10-26 22:56 Rev.: 14037

- Fix bogus doxygen @params directives.

12 lines of code changed in 1 file:

anmaster 2010-10-25 03:48 Rev.: 14036

Fix possibility of arithmetic overflow in the function buf_overflow().

6 lines of code changed in 2 files:

kbulgrien 2010-10-24 13:09 Rev.: 14035

- BloodyShade(IRC) suggested fixing this.

2 lines of code changed in 1 file:

ryo_saeba 2010-10-24 09:17 Rev.: 14034

Simplify code.

1 lines of code changed in 1 file:

anmaster 2010-10-24 09:15 Rev.: 14033

Enable Python 2.7 to be used. Prefer 3.1 over 3.0.

6 lines of code changed in 2 files:

anmaster 2010-10-24 09:06 Rev.: 14032

Fix building client with build directory separate from source directory.

11 lines of code changed in 3 files:

ryo_saeba 2010-10-24 08:46 Rev.: 14031

Const specifier for object::face.

3 lines of code changed in 2 files:

ryo_saeba 2010-10-24 07:17 Rev.: 14030

Use strncat instead of snprintf, as the result is not specified if the same data is used as source and destination.

2 lines of code changed in 1 file:

ryo_saeba 2010-10-24 06:58 Rev.: 14029

Thou Shall Not Change A Const Variable (tm).

3 lines of code changed in 1 file:

ryo_saeba 2010-10-24 06:37 Rev.: 14028

Remove 'Fontindex' type and use 'uint16', for coherence.

7 lines of code changed in 5 files:

ryo_saeba 2010-10-24 06:17 Rev.: 14027

Adjust coordinates to be near the greeting sign in Scorn and Navar.

6 lines of code changed in 1 file:

ryo_saeba 2010-10-24 05:54 Rev.: 14026

Update.

15 lines of code changed in 1 file:

mwedel 2010-10-24 00:35 Rev.: 14025

server/player.c: Bug fix for new character creation - give racial items
before applying class so special racial faces stick.
MSW 2010-10-23

23 lines of code changed in 2 files:

kbulgrien 2010-10-23 23:00 Rev.: 14024

- Add various details regarding archetypes, IRC, the check framework, etc. and
edit various paragraphs to try to improve the presentation of information.
- Minor reformatting for more consistent margins.

83 lines of code changed in 1 file:

kbulgrien 2010-10-23 22:05 Rev.: 14023

- It is now possible to ./configure; cd gtk-v2/src; make to build the client,
without having to execute make at the top of the project first. This can
be helpful during development.

23 lines of code changed in 1 file:

ryo_saeba 2010-10-23 04:19 Rev.: 14022

Make explicit that the player must give a number.

1 lines of code changed in 1 file:

ryo_saeba 2010-10-23 03:58 Rev.: 14021

Prevent dimension door through windows, reminder courtesy Khaleh.

17 lines of code changed in 1 file:

ryo_saeba 2010-10-23 03:45 Rev.: 14020

Kaptel can't be charmed. Prevent dimension door to bypass doors.

18 lines of code changed in 1 file:

ryo_saeba 2010-10-23 03:41

Prevent dimension door use to bypass doors.

171 lines of code changed in 2 files:

ryo_saeba 2010-10-23 03:41 Rev.: 14017

Prevent dimension door use to reach the key.

9 lines of code changed in 1 file:

mwedel 2010-10-21 01:22 Rev.: 14016

Changes for new character creation:
system/map.arc: Add subtype to existing starting map, add new ones for
player to be able to choose.
player/...: Make race/class names lowercase - most already were, so make
few that were not lowercase so they are all consistent.
MSW 2010-10-20

67 lines of code changed in 6 files:

mwedel 2010-10-21 01:20 Rev.: 14015

Update for advanced (in game) character creation:
common/init.c: Add check for new subtype for finding first map.
doc/Developers/protocol: Fix formatting, add starting map information.
include/shared/newclient.h: Add types for map requestinfo data.
include/map.h: Add new map subtypes.
include/player.h: Add new ADD_PLAYER_... values for add_player()
include/sockproto.h: updated
include/sproto.h: updated
server/player.c: Change add_player() to have second parameter be a
bitmask value and not true/false. Add apply_race_and_class().
server/apply.c: Reformat apply_changes_to_player() and have it take new
parameter which determines if class stat bonus can exceed racial maximum.
socket/loop.c: Handle startingmap requestinfo requrest.
socket/lowlevel.c: Add SockList_AddLen16Data() for cases were we want
to send a length prefixed block of data that is >255 bytes long.
socket/request.c: Update for loginmethod 2. Update decode_name_password()
to support passing length of data back to server via parameter. Handle
new character creation data from client.
socket/requestinfo.c: Add command to send choice of starting maps
to the client.
types/player_changer/player_changer.c: Add new parameter to call of
apply_changes_to_player()
MSW 2010-10-20

576 lines of code changed in 15 files:

mwedel 2010-10-21 01:18 Rev.: 14014

Commit client side support for new in client character creation.
common/client.h: Add various new globals for map, race, and class info.
common/commands.c: Move Race_Class_Info structure to header file, add
new global declarations. Add handling of requesting and storing
starting map information from server. Handle newcharinfo
protocol command.
common/external.h: Add new external calls.
common/init.c: Add calls to free race and class data.
common/proto.h: Add new prototype
gtk-v2/glade/dialogs.glade: Update dialogs.glade file with new
window for creating character.
gtk-v2/src/Makefile.am: Add create_char.c file
gtk-v2/src/account.c: Add calls for popups and to show the choose
character window. Add handling for new character creation method.
gtk-v2/src/create_char.c: New file that handles character creation logic.
gtk-v2/src/gtk2proto.h: Update with new functions
gtk-v2/src/main.c: update loginmethod to 2, add call to
init_create_character_window()
gtk-v2/src/main.h: Add global reference to account password
gtk-v2/src/stats.c: Make some widgets static to the file.
MSW 2010-10-20

2072 lines of code changed in 15 files:

mwedel 2010-10-21 01:16 Rev.: 14013

New definitions for starting map information.
MSW 2010-10-20

7 lines of code changed in 1 file:

akirschbaum 2010-10-20 14:39 Rev.: 14012

Remove unused code.

8 lines of code changed in 5 files:

akirschbaum 2010-10-20 14:25 Rev.: 14011

Remove magic numbers for rounding values.

12 lines of code changed in 6 files:

kbulgrien 2010-10-19 23:34 Rev.: 14010

- For almost the same reason given for removing the path, also remove the
dot extension on the sound names so that the server can append whatever
extension it wants to use.

163 lines of code changed in 1 file:

akirschbaum 2010-10-19 13:30 Rev.: 14009

Update .skin file documentation.

2 lines of code changed in 1 file:

akirschbaum 2010-10-18 15:48 Rev.: 14008

Prevent duplicate freeing of socket_struct entries.

5 lines of code changed in 2 files:

ryo_saeba 2010-10-17 11:07 Rev.: 14007

White zone of Darcap's Manor.

5648 lines of code changed in 4 files:

ryo_saeba 2010-10-17 06:31 Rev.: 14006

Add missing tiles.

2838 lines of code changed in 1 file:

ryo_saeba 2010-10-17 06:23 Rev.: 14005

Darcap's Manor, brown zone, with hopefully a nice challenge.

4906 lines of code changed in 4 files:

ryo_saeba 2010-10-17 03:27

Add an emergency exit to the first Raffle floor, to let people escape after a map reset.

24 lines of code changed in 2 files:

kbulgrien 2010-10-14 23:49 Rev.: 14002

- It is now possible to `./configure; cd sound-src; make` and build the sound
server without doing a top-level make.

27 lines of code changed in 1 file:

mwedel 2010-10-14 23:37 Rev.: 14001

Fix minor syntax error for sun sound.
MSW 2010-10-14

1 lines of code changed in 1 file:

kbulgrien 2010-10-14 06:54 Rev.: 14000

- Rename a missed reference to sounds.dist.

1 lines of code changed in 1 file:

kbulgrien 2010-10-14 06:53 Rev.: 13999

- Do not encourage putting path names into the sounds file anymore. Instead,
commit it with no paths at the point of use rather than making it with a
script that translates the paths to the flavor of the day. cfsndserv is
now able to search multiple paths defined at build time.

206 lines of code changed in 3 files:

kbulgrien 2010-10-14 06:48 Rev.: 13998

- Having hardcoded paths is a bad plan. Much better to allow the sound server
to be adaptable about where it locates sound files. Since the sound system
changed away from use of numbers, this file is almost useless anyway. For
now, remove the paths so we can use it as a cross-reference between sound
name and the sound number used by the original sound protocol.

0 lines of code changed in 2 files:

kbulgrien 2010-10-13 23:13 Rev.: 13997

- Remove warning: pointer targets in passing argument 1 of ‘StdinCmd’ differ
in signedness (for legacy sound systems).

1 lines of code changed in 1 file:

kbulgrien 2010-10-13 23:11 Rev.: 13996

- Move an #ifdef to fix compilation for legacy sound systems.
- Fix a misspelling of StdinCmd in fd_server() function to fix compilation for
legacy sound systems.

5 lines of code changed in 1 file:

kbulgrien 2010-10-13 23:01 Rev.: 13995

common.h
- Add #defines for commonly used sound server data directories and externs for
the pointer variables they will ultimately be used with.
- Add a helpful #define SOUND_DEBUG in this common file.
- Add an extern to the client replace_chars_with_string() function so that the
sound server can transparently support backslash delimited path strings.
sndproto.h
- Rebuild to support the new stdin handler and the sound number and type
translator functions.
common.c
- Instead of allocating memory for paths each time a file is referenced, set
up pointers for each path that is used more than once, and allocate the
memory for them one time via init_sounds().
- Remove function prototypes as common.h is the correct place to put them.
- Update a comment relating to play_sound()'s sound_number parameter.
- Document the rationale behind use of MAXSOCKBUF for a file path buffer size.
- Remove individualized setup of paths at the point-of-use in init_sounds(),
write_settings(), and read_settings().
- To smooth the transition from sound to sound2 command support by cfsndserv,
or, rather, to temporarily limit the scope of the rewrite and speed time to
initial functionality testing, create a stub sound_to_soundnum() translator
to take legacy sound names and map them to sound numbers so all legacy
sound drivers do not have to be re-written all at once. For this commit,
the function is a stub, so sound effects are basically disabled, but the
code compiles cleanly.
- As with conversion of sound name to sound number, create type_to_soundtype()
to convert sound2 types to sound types so that legacy sound effects can be
played with minimal rewrite. This conversion layer is hopefully temporary,
but should allow minimally functional sound support much earlier as it
prevents a need to immediately rewrite the drivers for all supported sound
systems.
- Rename SoundCmd() to StdinCmd() and rewrite it to parse both sound2 and
music commands coming from the client over stdin. The format of commands
from the client is completely changed to support all of the parameters that
the sound2 protocol defines, and requires string arguments to be quoted to
make it easier to manage names with a variety of characters including white
space. StdinCmd() does basic parameter sanity checks on the data so it can
discard invalid commands. StdinCmd() detects the type of command by the
location of the quoted strings in the client commands.
alsa9.c
common.c
cfsndserv.c
- Add client includes to the sound server to allow more commonality between
the sound server and the client.
alsa9.c
cfsndserv.c
- Update the sound server notice that identifies how it is compiled and add
a statement summarizing what is supported and not supported.
- Standardize SOUND_DEBUG announcements when entering primary sound support
functions.
- Add a play_music() stub function to all legacy sound systems (ALSA, ALSA9,
Sun, SGI, and OSS) that does nothing when they are selected, and add a very
basic (but functional) play_music() function that plays music if SDL_SOUND
is compiled in. Having play_music() available for all sound systems lets
StdinCmd() remain the same no matter which sound system is built.
- Rename calls to SoundCmd() to StdinCmd().
cfsndserv.c
- Move the helpful #define SOUND_DEBUG to common.h.
- Relocate all SDL_mixer sound support functions into the same #ifdef and all
the legacy functions into the same #else to put the related functions in
closer proximity with each other.

741 lines of code changed in 6 files:

kbulgrien 2010-10-13 19:55 Rev.: 13994

- Fix make complaint about having two targets that resolve to the same
library.

4 lines of code changed in 1 file:

kbulgrien 2010-10-13 19:49 Rev.: 13993

- Fix duplicate reference to cfsndserv instead of a reference to the alsa9
version.

1 lines of code changed in 1 file:

kbulgrien 2010-10-12 22:19 Rev.: 13992

- Remove duplicate of strdup_local() in common.c. It is in ../common/misc.c,
so it seems silly not to link with ../common/libccflient.a rather than have
it two places in the same project. Furthermore, for sound and music, more
functions from ../common are needed, so this is also prep work for that.

34 lines of code changed in 4 files:

anmaster 2010-10-11 13:14 Rev.: 13991

Fix incorrect svn properties, for example .png should not have svn:keywords set, that could in worst case result in corruption. While we are updating properties anyway, clean up incorrect (but mostly harmless) svn:mime-type, svn:executable and so on.

0 lines of code changed in 9378 files:

ryo_saeba 2010-10-10 14:06 Rev.: 13990

Darcap Manor, bases. More to come later.

9756 lines of code changed in 5 files:

ryo_saeba 2010-10-10 13:27 Rev.: 13989

Correctly enable plugins to handle THROW and STOP events for projectiles.

27 lines of code changed in 3 files:

anmaster 2010-10-10 09:35 Rev.: 13988

Change from using memory.h to using string.h, include memory.h as well
but make use of the check for it we already have in configure... That
header shouldn't be needed, but who knows... Also Update the output of
the -o flag to be more relevant...

14 lines of code changed in 3 files:

anmaster 2010-10-10 09:19 Rev.: 13987

Fix incorrect check in test/bugs/bugtrack/check_2879249.c.

4 lines of code changed in 2 files:

anmaster 2010-10-10 09:17 Rev.: 13986

Fix bug that caused server to sometimes crash on account login.

4 lines of code changed in 2 files:

ryo_saeba 2010-10-10 06:25 Rev.: 13985

Display balance in a nicer way. Better 'buy' list.

12 lines of code changed in 1 file:

ryo_saeba 2010-10-10 06:22 Rev.: 13984

Give access to 'cost_string_from_value' to the Python plugin.

16 lines of code changed in 2 files:

ryo_saeba 2010-10-10 06:20 Rev.: 13983

Use all coin types when displaying prices.

4 lines of code changed in 2 files:

anmaster 2010-10-09 17:41 Rev.: 13982

Fix some bugs found by static analysis (dead assignment, NULL dereference) using clang-analyzer.

101 lines of code changed in 5 files:

anmaster 2010-10-09 16:43 Rev.: 13981

Fix a number of serious compiler warnings (passing pointer to integer of different size, discarding const qualifiers).

10 lines of code changed in 7 files:

anmaster 2010-10-09 16:14 Rev.: 13979

Do not make symbols globally visible by default on *nix (when supported),
on Windows this is always the case. To prevent hidden errors (since most
developers seem to test on *nix), use -fvisibility=hidden when GCC is used
and make the MODULEAPI and CF_PLUGIN macros use __attribute__ to mark those
as visible. This will not break on any compiler not supporting this, but will
prevent future hidden errors of this type.

A further advantage with this is that it reduces risk of symbol name collision
between various dynamic objects.

111 lines of code changed in 12 files:

anmaster 2010-10-09 15:29 Rev.: 13978

Add missing CF_PLUGIN in cflogger. This would only fail on Windows since by default on *nix, all symbols are exported. Thus this error went unnoticed until I tried with -fvisibility=hidden and setting the MODULEAPI and CF_PLUGIN macros use __attribute__((visibility("default"))...

7 lines of code changed in 2 files:

anmaster 2010-10-08 08:32 Rev.: 13977

Fix some serious compiler warnings (missing declaration of function, fixed by adding an #include; wrong type for argument to snprintf, fixed by changing to use the proper variable) in the test
suites.

8 lines of code changed in 3 files:

anmaster 2010-10-08 08:28 Rev.: 13976

Fix case where a size_t* and an int* were confused. On my system that resulted in rare data corruption sometimes when the function in question was called.

8 lines of code changed in 2 files:

anmaster 2010-10-08 08:11 Rev.: 13975

Fix format string used to include pid in temporary filenames. It was %hx (short) but in reality pids are these days 32-bit. Change to %x and cast the parameter to unsignd int.

7 lines of code changed in 2 files:

kbulgrien 2010-10-07 21:26 Rev.: 13974

- Got a bit hasty on that last commit eh? Update various play_sound()
references to play_sound_effect().

6 lines of code changed in 1 file:

kbulgrien 2010-10-07 21:22 Rev.: 13973

- Rename the play_sound() function to avoid a name conflict with a cfsndserv
function of the same name. It messes up the doxygen call graphs.
- Reverse the order of the sound and source names sent to cfsndserv so that
the name of the sound effect or music is always the last quoted string on
the command line as it makes the command parse a little nicer on the
cfsndserv end of the pipe.

11 lines of code changed in 2 files:

kbulgrien 2010-10-07 19:55 Rev.: 13972

- Fix compilation with -Wformat -Werror=format-security.

10 lines of code changed in 1 file:

kbulgrien 2010-10-07 06:43 Rev.: 13971

- Disable developer aids in sound/music functions. They were accidentally
turned on at revision 13969.

3 lines of code changed in 1 file:

kbulgrien 2010-10-06 23:03 Rev.: 13970

- Doxygen comment rework for Sound2Cmd() and MusicCmd().

13 lines of code changed in 1 file:

kbulgrien 2010-10-06 22:45 Rev.: 13969

- Fix a doxygen complaint about the use of unsupported XML/HTML tags in a
Sound2Cmd() and MusicCmd().

6 lines of code changed in 1 file:

kbulgrien 2010-10-06 22:33 Rev.: 13968

- Make the gtk-v2 client compatible with the sound2 protocol from the server
and complete the unfinished implementations in Sound2Cmd() and MusicCmd().
This makes the client ready for sound2 and music by altering the format of
data sent to cfsndserv. cfsndserv is incompatible with the sound2 protocol
because sound numbers have been dispensed with, so the change in format of
data piped to cfsndserv does not break anything any worse than it already
was.

122 lines of code changed in 3 files:

kbulgrien 2010-10-06 22:22 Rev.: 13967

- Add the common/shared folder to INCLUDES.
- Reformat for readability, and remove DEFAULT_INCLUDES from the proto target
to get rid of duplicate includes.

14 lines of code changed in 1 file:

anmaster 2010-10-06 13:38 Rev.: 13966

Fix /python/guilds/arrest.py, it just kept throwing errors into server stderr...

3 lines of code changed in 1 file:

anmaster 2010-10-06 08:23 Rev.: 13965

Fix out of tree build. common/Makefile.am called some scripts that were not properly handling the case of source directory and build directory differing.

8 lines of code changed in 4 files:

anmaster 2010-10-06 07:59 Rev.: 13964

Add missing -I in utils/Makefile.am, otherwise mapper.c doesn't find global.h.

5 lines of code changed in 2 files:

ryo_saeba 2010-10-03 04:59 Rev.: 13963

Don't crash when there is a mood floor with speed in a container.

11 lines of code changed in 2 files:

ryo_saeba 2010-10-03 04:47 Rev.: 13962

Discard items of type PLAYER during map loading.

13 lines of code changed in 2 files:

kbulgrien 2010-10-02 16:46 Rev.: 13961

- Macros installed by libtoolize.

15 lines of code changed in 4 files:

kbulgrien 2010-10-02 16:44 Rev.: 13960

- Follow recommendation given by libtoolize.

1 lines of code changed in 1 file:

kbulgrien 2010-10-02 16:17 Rev.: 13959

- Give sound-serv access to the shared newclient.h file, and update the proto
target with similar changes.

5 lines of code changed in 1 file:

ryo_saeba 2010-10-02 04:34 Rev.: 13958

Add 'containers' pickup menu item.

100 lines of code changed in 15 files:

ryo_saeba 2010-10-02 04:23 Rev.: 13957

Add 'containers' pickup option.

7 lines of code changed in 2 files:

ryo_saeba 2010-10-02 04:18 Rev.: 13956

New pickup type, 'container'.

16 lines of code changed in 4 files:

ryo_saeba 2010-10-02 04:12 Rev.: 13955

Use 'magic devices' for weapon and armour improvers during pickup.

5 lines of code changed in 2 files:

kbulgrien 2010-10-01 06:39 Rev.: 13953

- Change the server SockList buffer to use MAXSOCKBUF for its size (also used
by the client). The prior literal specified one too many bytes allowed by
a two byte size, and even though it was practically okay, it was confusing
or distracting to see the server allocate a bigger buffer than the client.

7 lines of code changed in 1 file:

September 2010 »

Generated by StatSVN 0.7.0