Re: [Bug 18] New - CVS version: "Fall through Hole" message given too early

[Jan Echternach <>]

On Wed, Jun 14, 2000 at 02:27:17PM -0500,  wrote:
> + The code in apply_move displays "You fall through a hole" before calling
> + transfer_ob. However, the transfer_ob call won't nessecarily move the player,
> + leading to the confusing situation that a player is told he has fallen without
> + moving. I've only given the apply_move code a brief reading, but
> + it looks like this affects holes and trapdoors.

Displaying the message after calling transfer_ob() is too late if
you're hit by something on the target square of the hole.  The proper
fix would be to print the message somewhere inside transfer_ob(), but
this is not easy because transfer_ob() is not only used for holes.
With the current solution, you know at least that the hole is blocked
if you get the message but don't move anywhere.

-- 
Jan