Re: CF: Bug: win32/say cmd & memory leak

[Mark Wedel <>]

Michael Toennies wrote:
> 
> Hi
> 
> Also in the last CVS release, i can kill the server when i type 200 chars in
> the chat window
> and press the say cmd. If i shout the string, all works fine.

 Now fixed in CVS.  I was able to reproduce this bug - now it will just truncate
the data beyond 240 or so characters, which isn't perfect.  I guess this could
get done in a more clever fashion.

> 
> Also, in the 95.5. i create me a superman ring for map testing, give him all
> immunities and
> protections. that means all including blind but not internal.
> 
> After i try to ID the ring, the server crashes badly (and i make the guy
> next to me crying because
> i kill his 20mb download :).

 Sort of fixed.  The server now survives, but the client crashes with such a
ring in the inventory.  I have a feeling (after only a quick look) that it is as
Jan said - the server is sending a too long item description to the client. 
Thats next on the list to fix.

 From the CHANGES file for these fixes:

common/item.c: Modify query_short_name to avoid buffer overflow on long
ring descriptions.  Also, increased size of buffer in this function so
that longer ring descriptions will not get truncated.  MSW 5/22/2000

server/c_chat.c: Add standard banner to top of file.  Fix say command so
that it does not crash the server if something beyond 256 characters is
spoken - extra data is just truncated.  MSW 5/22/2000
-
[you can put yourself on the announcement list only or unsubscribe altogether
by sending an email stating your wishes to ]