Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 156 (100.0%) | 9849 (100.0%) | 63.1 |
| mwedel | 98 (62.8%) | 9430 (95.7%) | 96.2 |
| akirschbaum | 29 (18.6%) | 232 (2.4%) | 8.0 |
| tchize | 16 (10.3%) | 129 (1.3%) | 8.0 |
| cavesomething | 4 (2.6%) | 30 (0.3%) | 7.5 |
| crowbert | 3 (1.9%) | 13 (0.1%) | 4.3 |
| ryo_saeba | 3 (1.9%) | 6 (0.1%) | 2.0 |
| elsbernd | 1 (0.6%) | 5 (0.1%) | 5.0 |
| onefang | 1 (0.6%) | 3 (0.0%) | 3.0 |
| tanner | 1 (0.6%) | 1 (0.0%) | 1.0 |
make branche directories, delete old trunk.
0 lines of code changed in 13 files:
Add .cvsignore files, courtesy Rapha��l Quinet - quinet
0 lines of code changed in 1 file:
Make common/cconfig.h act as the default server if set, if not set, connect
to metaserver. Prior to this, it always went to the metaserver unless
-server option was given.
--
common/cconfig.h: Comment out SERVER so by default it connects to metaserver
common/client.c: Add handling to initialize server from SERVER if defined,
null otherwise.
common/metaserver.c: Don't present default server in metaserver selection
default is null.
gtk/gx11.c, gtk-v2/src/main.c, x11/x11.c: Change command line handling -
if server is set, use that as default to connect to.
--
MSW 2006-07-1
2 lines of code changed in 1 file:
x11/xutil.c: Use snprintf() to avoid possible buffer overflows.
23 lines of code changed in 1 file:
gnome/gnome.c, gtk/gx11.c, x11/x11.c: Remove unused macros.
0 lines of code changed in 1 file:
Change "if(ptr) free(ptr)" into "free(ptr)".
6 lines of code changed in 2 files:
Fix problem in gtk1 & gtk2 client when player issues disconnect command -
client would hang and consume all CPU time.
---
common/external.h: Add declaration to cleanup_connection()
common/p_cmd.c: In disconnect command, add call to cleanup_connection()
gtk/gx11.c, gtk-v2/src/main.c: Add cleanup_connection() - removes socket
from one of the gdk input device, call gtk_main_quit so it returns
to metaserver selection.
x11/x11.c: Add empty cleanup_connection() - x11 client doesn't need to
do anything special.
MSW 2006-07-06
5 lines of code changed in 1 file:
Clean up some compile warnings. They generally fall into either wrong form
for variable (%lld vs %ld), or cast for data (char* vs uint8*)
---
common/client-types.h: Add FMT64 defines like done in the server. Removes
need for #ifdef WIN32 in many places.
common/client.c: Remove unneeded cast for ReplyInfoCmd(). Change type
of length parameter passed to getsockopt() to be a socklen_t.
common/commands.c: Change ReplyInfoCmd() to take a uint8*. Add several
char*/uint8* casts. Change TickCmd() to also take uint8*
common/external.h: Add extern void client_tick(uint32 tick).
common/image.c: load_image() so that its fourth param (checksum) is a uint32.
In finish_face_cmd() change filename to be a char*. Add some casts in
ImageCmd() & Image2Cmd(). Change display_newpng() so its first param
(face) is just a int, not a long. Change get_image_info() to take in
a uint8* for data, add some casts. Change get_image_sums() to take in
a char*
common/item.c: Change several buffers used by the socklist structure to
be uint8, add casts as needed.
common/newsocket.c: Change SockList_Init() so that the passed in buffer
is a uint8*, so that is what the target buffer type is. Add some
casts and update some types within the program.
common/player.c: Change a buffer from char to uint8.
common/proto.h: Rebuilt.
common/script.c: Change it to take in a uint8 for data. Change %lld
to use FMT64
common/script.h: Update declaration of script_watch()
gtk/config.c: Remove const from titles. While they may be used as a const,
the gtk function they are passed to isn't declared that way.
gtk/gx11.c: Remove unused function end_windows(). Replace %lld with
FMT64. Removed const from title declaration.
gtk/inventory.c: Remove const from titles declaration. re-enable cast
for image creation for tabs.
gtk/keys.c: Add note about compiler warning and bad code technique for
for getting the selection.
gtk/png.c: Removed unused variables/function - png_to_gdkpixmap()
gtk/text.c: Change void_callback() to match format of other callbacks
to prevent warning.
gtk-v2/src/gtk2proto.h: Rebuilt.
gtk-v2/src/png.c: Remove unused variable.
gtk-v2/src/stats.c: Replace %lld with FMT64.
pixmaps/question.111, pixmaps/stipple.111, pixmaps/stipple.112: Change
types to be char and not unsigned char, since that is what
the function tha uses this data expects.
x11/x11.c: Replace %lld with FMT64
---
MSW 2006-07-04
2 lines of code changed in 1 file:
Changes related to logging of version information.
aclocal, Makefiles.*: Rebuilt for new file in gtk-v2/src.
common/misc.c: Change MINLOG to be a variable so it can be changed via
command line options.
gtk/gx11.c: Have bug window display rcsid versions. Add -loglevel command
line option. Move printing of some log messages until after we process
command line options since that can change the log level.
gtk-v2/gtk-v2.glade: Add an about window for the gtkv2 client.
gtk-v2/src/Makefile.am: Add about.c file.
gtk-v2/src/about.c: file for about window.
gtk-v2/src/callbacks.h: on_about_close_clicked() added by glade.
gtk-v2/src/interface.c, interface.c: New logic for about window. New
function - create_about_window()
gtk-v2/src/main.c: Add -loglevel command line option. Move printing of some
log messages after we process command line options.
gtk-v2/src/menubar.c: remove menu_about() - now in about.c
MSW 2006-07-04
1 lines of code changed in 1 file:
Make some changes to the defaults so that the game is a bit more user friendly
to completely new users (eg, those that don't have a settings file):
--
common/init.c: Turn off popups (gtkv1 client) by default - general seems
that it isn't popular, and placement of the popups needs to be fixed.
gtk-v2/src/main.c: Change default map size to ask from server to be
25x25 - the gtkv2 client has default window size for that, so lets use
it.
x11/x11.c: Turn on scroll of text by default - non scroll is really ugly
and doesn't make any sense give the power of even very slow cpus now.
MSW 2006-07-01
1 lines of code changed in 1 file:
This commit adds client side support for the map2 & tick protocol commands.
In additional the the necessary decode logic, more layers are also added
to the map.
--
common/Makefile.am/.in: Fix proto directive
common/client.c: Add global tick variable. Add links to handle map2
and tick protocol commands. Update setup request sent to server
to request to use the tick and map2 commands.
common/client.h: Add additional fields to Animations structure. Increase
MAX_MAP_OFFSET to match the value on the server.
common/commands.c: Add parsing of return of map2 failures on setup command
so that client can fall back. Add additional initializations for
new fields in AnimCmd(). Change definition of NUM_LAYERS to match
what the map1 command wants/expects. Add Map2Cmd() to decode
map2 protocol command. Do some whitepsace clean of ExtSmooth().
Add TickCmd()
common/init.c: Add seeing of random number generator.
common/mapdata.c: Rewrite CLEAR_CELLS macro to handle additional layers.
Clear animation data in expand_clear_face(). Change MAXLAYERS to
MAP1_LAYERS since map2 increase MAXLAYERS. Add support functions for
setting data in the map2 command.
common/mapdata.h: Increase MAXLAYERS, add MAP1_LAYERS define to old number
of layers. Add animation data to MapCellLayer.
common/newclient.h: Add various defines related to the map2 data.
common/proto.h: Rebuilt
gtk/gx11.c: Add cleint_tick() to handle map animations. Update
do_timeout() to not do animations if we are getting tick data.
gtk-v2/src/config.c: Fix bug in config code where it wasn't enabling
darkness when player switched back from no darkness mode to some
mode.
gtk-v2/src/main.c: Add client_tick() to handle animations. Update
do_timeout() to not do animations if tick is set.
gtk-v2/src/opengl.c: Fix drawing logic where objects which were visible
but in which the bottom right corner was off the map was not being
drawn - only a problem in opengl since it only draws the object
when it finds the head, does not draw each piece.
sound-src/Makefile.am/.in: Fix creation of sounds file - was using
wrong variable name.
x11/xutil.c: Add basic client_tick() that is a callback from the common code.
MSW 2006-05-14
5 lines of code changed in 1 file:
Fix bug #1442523 (Crash when pressing TAB during login). Also fix undefined
behavior due to overlapping strings passed to strncpy().
14 lines of code changed in 1 file:
Apply patch #1433271 (code-cleanup) by Stefan Huehner: Add const and static,
remove unused variables
12 lines of code changed in 5 files:
More improvements to the gtk-v2 client:
- Add spell selection window similar to that in the gtk-v1 client.
- Make it so that clicking on the headers in the metaserver and keybinding
selection windows will result in table be sorted by that header.
--
*/Makefile.in: Rebuilt by automake.
aclocal.m4: Updated by aclocal.
gtk-v2/TODO: Remove things that have been done, add other things mentioned
on mailing list that should be done.
gtk-v2/gtk-v2.glade: Updated with new spell selection window.
gtk-v2/src/Makefile.am: Add spells.c file
gtk-v2/src/spells.c: File that handles spell selection window.
gtk-v2/src/callbacks.h: Updated by glade
gtk-v2/src/gtk2proto.h: rebuilt
gtk-v2/src/interface.c: Updated by glade.
gtk-v2/src/interface.h: Updated by glade.
gtk-v2/src/keys.c: Add necessary calls to enable sorting of table by
clicking on headers.
gtk-v2/src/main.c: Add call to update_spell_information() if spell information
has changed.
gtk-v2/src/metaserver.c: Add necessary calls to enable sorting of table by
clicking on headers. Convert the idletime and number of players columns
to be ints - this makes the sort work as expected, and actually simplifies
the code a little.
gtk-v2/src/support.h: Rebuilt by glade.
MSW 2006-02-22
3 lines of code changed in 1 file:
Apply patch #1430279 (code-cleanup: const, static, etc) by Stefan Huehner.
16 lines of code changed in 3 files:
make the mesage displayed on trying to drop locked items more descriptive
2 lines of code changed in 1 file:
remove coloured inventory and text options and support for black and white monitors, change cfclient to a grey colourscheme
28 lines of code changed in 3 files:
x11/png.c: Add same workaround from gtk/png.c to make it work on 64 bit
systems.
MSW 2006-01-01
43 lines of code changed in 1 file:
gtk/{map.c,sdl.c}, x11/x11.c: General cleanup - just whitespace changes.
8 lines of code changed in 1 file:
x11/x11.c: Fix similar problem for x11 client: need_update needs to be cleared
too.
1 lines of code changed in 1 file:
Fixed Makefile problem where soundsdef.h was not autobuild , breaking compilation
1 lines of code changed in 1 file:
*Makefile.in, aclocal.m4, configure: Rebuilt.
1 lines of code changed in 1 file:
Fix bug #1102991 (Duplicate grapical display of the same monster):
common/Makefile.am: Add new files mapdata.c and mapdata.h.
common/{client.c, commands.c}: Tell mapdata module the current display size.
common/commands.c: Remove functions to handle map updates. Rewrite
map1_common() to pass information into mapdata module.
common/init.c, gtk/gx11.c: Add new config options -mapscroll and -nomapscroll
to enable/disable scrolling the map view with bitmap operations.
common/mapdata.[ch]: Add new module to handle all updates to the_map.
gtk/gx11.c: Remove code for #if ALTERNATE_MAP_REDRAW. Initialize question mark
face for fog of war. Remove code to allocate the_map.
gtk/image.c: Do not clear the_map in reset_image_data() anymore.
gtk/map.c: Move code to update map data into mapdata module.
draw_pixmap(): New function to draw one face.
drawsmooth(): Check correct layer instead of fixed layer zero. Fix out of
bounds array access.
display_mapcell(): New function to draw one cell.
gtk_draw_map(): Move map drawing code into display_mapcell().
gtk/sdl.c: Basically the same changes as in gtk/map.c
gtk-v2/src/image.c: Basically the same changes as in gtk/gx11.c.
gtk-v2/src/main.c: Add config options -smooth/-nosmooth to enable/disable
smoothing. Remove code to allocate the_map.
gtk-v2/src/map.c: Basically the same changes as in gtk/map.c.
gtk-v2/src/opengl.c: Fix out of bounds array access. Initialize question mark
face for fog of war.
gtk-v2/src/sdl.c: Basically the same changes as in gtk/map.c.
x11/x11.c: Implement map scrolling by using XCopyArea(). Add config options
-mapscroll/-nomapscroll to enable/disable this. Remove code to allocate or
clear the_map. Add new function display_mapcell() to draw one cell. Move
map drawing code from display_map_doneupdate() into display_mapcell().
Remove two pixel border around map window; is was used inconsistently, and
the window size was four pixels too small.
x11/xutil.c: Move code to update map data into mapdata module.
107 lines of code changed in 4 files:
Fix sound compilation so it only tries to compile alsa9 helper if we
in fact have alsa 9 libs.
*/Makefile.in: Rebuilt
configure.in, configure: Add ALSA9_TARGET, replacing SOUND_TARGETS which
was no longer being used.
sound-src/Makefile.am: add EXTRA_PROGRAMS line for cfsndserv_alsa9 so
don't get errors from automake, add @ALSA9_TARGET@ to bin_PROGRAMS.
MSW 2005-08-28
1 lines of code changed in 1 file:
common/misc.c, gtk/{gx11.c,sdl.c,text.c}, gtk-v2/src/sdl.c, x11/sound.c:
Fix non-Ansi C89 code: remove "inline" function specifier, replace "//"
comments.
1 lines of code changed in 1 file:
x11/x11proto.h, x11/xutil.c: Use correct parameter type "uint16" for
addsmooth().
2 lines of code changed in 2 files:
This commit adds full automake support for the client - previously, only the
gtk-v2 directory used automake, rest was Makefile.in - now everything is
automake - makes maintenance and distributions easier.
--
common/Makefile.am gtk/Makefile.am help/Makefile.am pixmaps/Makefile.am
sound-src/Makefile.am utils/Makefile.am x11/Makefile.am pixmaps/Makefile.in
utils/Makefile.in help/Makefile.in: New Makefiles
Makefile.am, Makefile.in: Removed unneeded rules, move pixmap, help, util
handling to makefiles in their own directories.
configure, configure.in: Update to include pixmap, help, util as
directories.
gtk-v2/Makefile.am, gtk-v2/Makefile.in: Clean up some rules in this makefile.
common/Makefile.in, gtk/Makefile.in, sound-src/Makefile.in, x11/Makefile.in:
Rebuilt as part of automake.
gtk-v2/src/Makefile.am, gtk-v2/src/Makefile.in: Add banner copyright, remove
uneeded rules.
MSW 2005-08-11
590 lines of code changed in 2 files:
x11/x11.c: Fix crash if display cannot be opened.
5 lines of code changed in 1 file:
crossfire-client.spec, gnome/Makefile.in, x11/Makefile.in: Patch from Kari
Pahula to fix manpage paths.
1 lines of code changed in 1 file:
Patch #1197437 courtesy krudat - inventory-related
6 lines of code changed in 2 files:
This patch fixes a few memory leaks related to image caching in all clients.
common/image.c: Declare facetoname[] as static. Add all code accessing this
array. Print warning if image cannot be created.
gtk/gx11.c, gtk/image.c, gtk-v2/src/image.c, x11/x11.c, x11/xutil.c: Remove
code accessing facetoname[].
gtk/gx11.c, gtk-v2/src/main5H.c, x11/x11.c: Always call init_cache_data() to
initialize pixmaps[] array.
gtk/image.c, gtk-v2/src/image.c, x11/png.c: Reject invalid face
numbers and fix resource leak in create_and_rescale_image_from_data().
gtk/image.c, gtk-v2/src/image.c, get_map_image_size: Pretend invalid faces to
be of size 1x1 in get_map_image_size().
gtk-v2/src/image.c: Properly free opengl resources in free_pixmap(). Fix
resource leak when freeing old pixmaps in reset_image_data().
x11/png.c: Properly free resources if an error occurs.
x11/x11.c: Ignore invalid face numbers.
x11/x11.h Remove duplicate definition of MAXPIXMAPNUM and facetoname[].
x11/xutil.c: Initialize size of pixmaps[0].
35 lines of code changed in 4 files:
Main change of this is addition of opengl drawing for the map in the gtk-v2
client. On my system, the opengl code is about 10 times faster than the
sdl code was, making it so I can turn on all the bells and whistles (smoothing,
best lighting) and still use less than 10% cpu time. As part of this, I
redid the smoothing logic, so the client now requires a new server for
smoothing to work (needs push logic, as client won't request smoothing
info as that adds a lot of complication). This change was done because
the old smoothing code wasn't that efficient - now, we store the smoothing
face along with the face it smooths, so finding the smoothing info is
much faster.
--
configure.in, configure: Add check for -lglut - indication we have opengl
libraries available.
common/client.h: Remove Smooths struct. Change CONFIG_SDL to
CONFIG_DISPLAY, and add CFG_DM_... to denote different display modes,
since there is more than just sdl and not sdl now.
common/commands.c: Don't have SmoothCmd try to update what spaces need
to be redrawn - for opengl, it doesn't care about that, and for
most other maps, it will figure it out when it needs to redraw
anyways.
common/config.h.in: Addition of HAVE_OPENGL line.
common/image.c: Remove getsmooth() - rely on push logic.
common/init.c: Update want_config[CONFIG_SDL] to
want_config[CONFIG_DISPLAYMODE]
gtk/config.c: Change access to CONFIG_DISPLAYMODE
gtk/gx11.c: Change access to CONFIG_DISPLAYMODE. Add -smooth command line
option.
gtk/gx11.h: Add smooth_face to PixmapInfo struct.
gtk/image.c: Change access to CONFIG_DISPLAYMODE. When getting new
PixmapInfo struct, use calloc so we are sure all fields are initialized
to zero. Add addsmooth().
gtk/map.c: Change access to CONFIG_DISPLAYMODE. Change how we access
smooth face info.
gtk/sdl.c: Change how we access smooth face info.
gtk-v2/src/Makefile.am, gtk-v2/src/Makefile.in: Add addition of OPENGL_LIBS
to link libs. Add opengl.c file.
gtk-v2/src/config.c: Add image.h include.
gtk-v2/src/gtk2proto.h: Rebuilt.
gtk-v2/src/image.c: Change access to CONFIG_DISPLAYMODE. Add hooks for
opengl image generation. Change call for pixmap creation from malloc
to calloc. Add addsmooth().
gtk-v2/src/image.h. If we have opengl, include GL/gl.h. Add fields
for opengl texture maps.
gtk-v2/src/info.c: Update so text line wraps if it is too long.
gtk-v2/src/inventory.c: Add checks to make sure object face is
valid before trying to draw. In icon mode, add code to cleanup
old fields (if you drop an item, it wouldn't erase the list item
in the list). Also, free callbacks, as they effectively stack,
and we were using incorrect object pointers (pointer from first
callback, which didn't match current one).
gtk-v2/src/keys.c: Add image.h to includes.
gtk-v2/src/main.c: Add image.h to includes. Change access to
CONFIG_DISPLAYMODE. Add -opengl command switch. Remove
+sdl and popups command line options. Relocate setup of
cache call setup to after we know all windows have been created.
gtk-v2/src/map.c: Change access to CONFIG_DISPLAYMODE. Add opengl
drawing hooks. Change access for smooth info. Implement
button press code for map window (basically grabbed from
gtk/map.c)
gtk-v2/src/opengl.c: New file containing opengl draw code.
gtk-v2/src/png.c: Remove some unused code resulting in compile warnings.
gtk-v2/src/sdl.c: Remove some commented out code. Change access method
for smoothing code.
x11/xutil.c: Change access to CONFIG_DISPLAYMODE. Add addsmooth()
function.
MSW 2005-03-20
7 lines of code changed in 1 file:
Add 'show' command back in to list of commands.
common/external.h: Change prototype of command_show() to match p_cmd.c
prototype.
common/p_cmd.c: Add 'show' to command dispatch table.
gtk/gtkproto.h: rebuilt
gtk/gx11.c: change declaration of command_show() to take const char *.
gtk/sdl.c: Make drawsmooth_sdl() static so it won't be put into gtkproto.h
file, which causes compilations to fail.
x11/x11.c: change declaration of command_show() to take const char *.
x11/x11proto.h: rebuilt
MSW 2005-02-26
10 lines of code changed in 2 files:
Makefile.in, common/Makefile.in, gnome/Makefile.in, gtk/Makefile.in,
sound-src/Makefile.in, x11/Makefile.in: Add ${DESTDIR} prefix for
installation into other directories. Patch from sourcefore #1061895
MSW 2005-02-09
common/external.h, common/init.c, common/player.c, common/proto.h,
common/script.c, common/script.h, common/p_cmd.c (new file),
common/p_cmd.h (new file), gtk/gtkproto.h, gtk/gx11.c, gtk/help.c (new
file), gtk/keys.c, help/chelp.h, x11/x11.c, x11/x11proto.h, x11/xutil.c:
Install command table for client side commands - makes adding commands a
little easier, but also makes it easier to have better help. Bulk of the
changes are in p_cmd.c file, which pulled some code out of player.c.
Other source files modified to clean up function parameters (all now take
const char * as the command options). Patch from sourceforge 1022245,
with some work done by me. Addition fix in gtk/keys.c unbind - buffer
overflow would result if unbinding very long binding.
MSW 2005-02-09
26 lines of code changed in 4 files:
Makefile.in: Fix up distclean directive to go into all directories.
configure.in, configure: Fix configure so the --enable-feature and
--disable-feature flags follow proper standard (from patch on
sourceforge). Add check for -lossaudio. Modify check for
-lSDL_image library - don't require it for SDL support (if we
have it, we'll use it, but for newer versions of SDL, it doesn't
seem to exist anymore)
common/client-types.h: Minor formatting change.
common/script.h: add defines for PF_LOCAL and AF_LOCAL if they are
missing.
gtk/Makefile.in: Install man page into section 6.
sound-src/Makefile.in: Fix up depend command - had wrong variable.
Fix up distclean to remove automatically generated files.
x11/Makefile.in: Install man page into section 6.
MSW 2005-02-04
2 lines of code changed in 1 file:
Various updates for 1.7.0 release - bump version number. Some file names
renamed/removed/mistypes in the Makefiles - fix those up. Update the
CHANGES file.
MSW 2004-04-18
1 lines of code changed in 1 file:
Minor changes to clean up some compiler warnings.
MSW 2004-04-18
4 lines of code changed in 2 files:
fixed a bug in save_individual_key in which a buf was overflowed when
a binded command has a size approaching the maximum length (sizeof(bind_buf)).
Also fixed a potential problem which could arise when loading a keybinds file where
some commands exceeded maximum command length.
8 lines of code changed in 1 file:
Added a warning message when keybinding is trucated becasue too long
Also fixed a bug in rebinding of command/fire/run and other system binding
2 lines of code changed in 1 file:
Logging of source files version on client. Removed need for scripting in Makefile
Better used way which didn't use Makefile and a script. Simply ask each .c file
to create a char * rcsid_directory_file_c and collected them as an array in main()
43 lines of code changed in 6 files:
(31 more)