Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 280 (100.0%) | 65770 (100.0%) | 234.8 |
| kbulgrien | 206 (73.6%) | 58208 (88.5%) | 282.5 |
| partmedia | 38 (13.6%) | 5101 (7.8%) | 134.2 |
| mwedel | 7 (2.5%) | 1919 (2.9%) | 274.1 |
| ryo_saeba | 13 (4.6%) | 314 (0.5%) | 24.1 |
| cavesomething | 13 (4.6%) | 175 (0.3%) | 13.4 |
| tchize | 1 (0.4%) | 53 (0.1%) | 53.0 |
| anmaster | 2 (0.7%) | 0 (0.0%) | 0.0 |
Switch to a library-independent naming scheme.
0 lines of code changed in 27 files:
Replace common menu items with stock items.
450 lines of code changed in 1 file:
Implement multiple changes to how keybindings are handled. [1]
- Show all keybindings (including defaults)
- Add "Any" key modifier type
- Consistently use hash helper functions to clean up code
- Fix usage texts
- Only bind lowercase keys
- Rehash keybind entry on key dialog update
- Remove -afmnr flags from 'bind' command
Submitted by: Arvid Brodin <arvidb@kth.se> [1]
19 lines of code changed in 1 file:
Remove depricated "swapped" attribute introduced by broken Glade editor.
75 lines of code changed in 2 files:
GTK2 interface requires 2.16 only features; this was not correctly set in the glade file.
439 lines of code changed in 1 file:
Fix cut off menu bar by removing unused labels. Somehow Glade insists on shuffling the format of the entire file, which will confuse diff.
1080 lines of code changed in 1 file:
Remove unused dialog window.
0 lines of code changed in 1 file:
Use stock buttons whenever possible.
47 lines of code changed in 1 file:
Rename "Metaserver Selection" to "Server Selection" and switch to a few stock buttons.
18 lines of code changed in 1 file:
Make it clear that the stat bar color option only works when using a few specific GTK themes. Somehow Glade insists on reordering every line in the dialog file which makes `svn diff` output look ugly.
Submitted by: Pascal Zotto
PR: bugs/685
2971 lines of code changed in 1 file:
Fix capitalization.
2 lines of code changed in 1 file:
- Character creation windows aesthetics dramatically improved. A window title
was added. Character name alignment is more consistent with the rest of the
window layout. Frames were added around information blocks. Wasted space
is used by pulling the race/class descriptions out of the stat table. Unused
points are now in the Total column and closer to the rest of the stat data.
- The starting map window aesthetics were improved. A window title was added
and the map selector is positioned at the top of the window rather than in
the middle.
- The add character dialog has minor modifications to improve consistency with
other dialogs.
- The password change dialog is more uniform looking.
- Add dialogs are set to not be deletable to avoid client failure when a user
might click on the [X] window control (some window managers do not
honor this).
- A liblade warning is no longer presetn at client startup. This was done by
Glade automatically. A widget was automatically removed when the project
was saved.
- Many widget names were changed to logical names that describe where they
appear in the various dialogs and what purpose they serve. These are not
functional changes, but they greatly improve readability of the layout.
1198 lines of code changed in 1 file:
- Fix for choose_starting_map_window. Primarily making the dialog not
deletable since deleting the window completely hoses the client and
forces a restart. This also makes the dialog not ugly.
42 lines of code changed in 1 file:
Add timestamping option.
16 lines of code changed in 1 file:
Add account password change logic and dialogs.
221 lines of code changed in 1 file:
Change adjustment value to remove:
(crossfire-client-gtk2:341): Gtk-WARNING **: GtkSpinButton: setting an adjustment with non-zero page size is deprecated
messages from showing up at program start.
MSW 2011-01-11
7 lines of code changed in 1 file:
common/client.h: Update race & class structures to hold choice information
from server.
common/commands.c: Add handling of choice information from server.
gtk-v2/src/create_char.c: Add handling of choice option lists.
gtk-v2/glade/dialogs.glade - add labels and combo boxes for the choice
options.
MSW 2010-11-14
122 lines of code changed in 1 file:
Commit client side support for new in client character creation.
common/client.h: Add various new globals for map, race, and class info.
common/commands.c: Move Race_Class_Info structure to header file, add
new global declarations. Add handling of requesting and storing
starting map information from server. Handle newcharinfo
protocol command.
common/external.h: Add new external calls.
common/init.c: Add calls to free race and class data.
common/proto.h: Add new prototype
gtk-v2/glade/dialogs.glade: Update dialogs.glade file with new
window for creating character.
gtk-v2/src/Makefile.am: Add create_char.c file
gtk-v2/src/account.c: Add calls for popups and to show the choose
character window. Add handling for new character creation method.
gtk-v2/src/create_char.c: New file that handles character creation logic.
gtk-v2/src/gtk2proto.h: Update with new functions
gtk-v2/src/main.c: update loginmethod to 2, add call to
init_create_character_window()
gtk-v2/src/main.h: Add global reference to account password
gtk-v2/src/stats.c: Make some widgets static to the file.
MSW 2010-10-20
795 lines of code changed in 1 file:
Add 'containers' pickup menu item.
77 lines of code changed in 11 files:
- Add the msgctrl_window to the list of dialogs that need special settings.
- Add a note on the importance of setting the Deletable property to No, and
connecting the delete events of all dialogs to gtk_widget_hide_on_delete().
13 lines of code changed in 1 file:
- Make all the account-related dialogs non-deletable.
4 lines of code changed in 1 file:
- Change the dialogs.glade design up to support GTK 2.16 and let Glade-3
reorder orientation properties to amuse itself. It also automatically added
more properties in various places... hopefully all sane changes.
- Set the login dialog deleteable property to false so (some) window managers
do not show the [X] close icon. The client can't handle the dialog being
closed. This is a partial fix only. Some window managers (or whatever) do
not honor the GTK property.
- Clean up a widget name in the config dialog.
- Summarize .glade file mods in the ChangeLog.
23 lines of code changed in 1 file:
- Fix id strings with trailing spaces. The Glade editor used previously had
a GUI issue that caused these. Apparently some problems occurred before
it was realized the items were being generated with trailing spaces.
2 lines of code changed in 2 files:
- Prevent royal screw up by Glade 3.6.7 when loading this file. 3.6.7 was
released knowing that it would render vboxes horizontally when the .glade
file was made for GTK < 2.16, and that manual edit/save would be required.
http://mail.gnome.org/archives/gnome-announce-list/2009-June/msg00063.html
50 lines of code changed in 11 files:
- Prevent royal screw up by Glade 3.6.7 when loading this file. 3.6.7 was
released knowing that it would render vboxes horizontally when the .glade
file was made for GTK < 2.16, and that manual edit/save would be required.
http://mail.gnome.org/archives/gnome-announce-list/2009-June/msg00063.html
22 lines of code changed in 1 file:
gtk-v2/glade/dialogs.glade: Fix for bug 3020531 - The Create Character
button does nothing. Trailing space in widget name resulted in code
not finding the widget and attaching callback to it.
MSW 2010-07-12
1 lines of code changed in 1 file:
- Remove the Skills/Experience tab from the core stats notebook in
gtk-v2.glade as the skills window is better to use. Tested at 1400x1050,
640x480. At 640x480, the inventory/message panel is all the way to the
left, but the hpane grab bar is visible. At default client size with no
gdefaults2 or gtk-v2.pos, the map is to small to work properly, (some map
tiles stay black) but, if the corestats are pushed down or hidden at the
bottom of the screen it is playable.
2 lines of code changed in 1 file:
- Oh, ok, remove disfunctional scrollbars from ALL the layouts...
37 lines of code changed in 1 file:
- Remove the disfunctional scrollbars from around the map in most gtk-v2
.glade files. The layout acts better under different circumstances when
they aren't there. After all these years they've never been used, so no
point in keeping them around as they just take up space.
141 lines of code changed in 6 files:
- Remove the disfunctional scrollbars from around the map in chthonic.glade.
The layout acts better under different circumstances if they aren't there.
5 lines of code changed in 1 file:
- Remove the skills/experience table from these layout as a result of the new
skills window. A significant design point for both of these layouts was to
try to remove the vertical space constraints that the skills & experience
information placed on the layout when it was used on smaller displays.
- Update the AUTHORS notes for both of these layouts.
132 lines of code changed in 3 files:
- Remove the skills/experience table from the chthonic layout as a result of
the new skills window. At least one user desires this change also.
- Give meaningful names to various chthonic widgets that had generic names.
- Add a note to the AUTHORS file that notes a minor save/restore issue with
the protections/core statistics notebook area in the lower right corner
of the chthonic layout. It seems as though nesting hpaned or vpaned within
each other may be part of why some layouts have restore issues that need to
be dealt with.
110 lines of code changed in 2 files:
- Fix sixforty.glade issue with spinbutton_count to avoid run-time message
regarding non-zero page size.
- Remove the sixforty.glade table_skills_exp and enclosing structures now that
the skills window is available.
- Add note to AUTHORS that sixforty.glade has save/restore window position
issues at this time. This issue has been present prior to this, so until it
is fixed, just document it as a known issue so it doesn't get forgotten
(again). Also do not mention a map dimension less than allowed (8 vs.
minimum 11), and add mention of use of map and icon scale to improve
usability.
19 lines of code changed in 1 file:
- Update the description of oroboros.glade. Removed the skills and experience
table per creation of the new skills window. This allowed the four tab
notebook in the top right to change to 2 tabs to improve accessibility of
vital statistics. This redesign also seems to improve the sizability of the
client, possibly making it easier to shrink below the default 1024x768
dimensions and opening the door to improvements in other layouts.
511 lines of code changed in 2 files:
- A complete rework of the client configuration dialog to make it take up less
vertical space. Netbook users with a screen height of 600 pixels could not
access all items in the dialog. The dialog was also pretty ugly and the
controls were not organized as well as they could be. The overall design of
the dialog now matches the design principles used for the account dialogs.
- Fix up even more confusion in the ChangeLog.
873 lines of code changed in 1 file:
- Dress up the dialogs related to the account code. A few items are moved to
make better use of space, but this mostly adds containers, attributes,
padding, etc. that improves the dialog aesthetics. Orientation properties
are removed to reduce libglade spew when running on older versions. They
aren't needed anyway. The other major change is that now all widgets have
logical names.
956 lines of code changed in 1 file:
Add skills window
175 lines of code changed in 13 files:
Add account based support to gtk2 client & common code. Remove support
for gtk1 and X11 clients
---
configure.ac: Remove check for gtk1, cfgtk2 option, X11 libraries, and
checks related to those clients.
common/client.c: Add tracking of loginmethod. Update setup to send
loginmethod, update dispatch table for new commands. Add
close_server_connection() so duplicate code does not need to be
repeated. Don't send addme command when using new login method.
common/client.h: Add globals for motd, news, rules, loginmethods,
INFO_... types.
common/commands.c: Add processing of requestinfo for motd, rules, news.
Add handling of loginmethod setup. Add call to hde_all_login_windows()
when play starts. Add FailureCmd(), AccountPlayersCmd() to handle
protocol commands.
common/init.c: Free motd/news/rules data when changing servers.
common/metaserver.c: Move meta_sort() to this file, don't make it
static - removes compiler warnings.
common/metaserver.h: Remove static declaration of meta_sort, and
function prototype for it.
common/p_cmd.c: Update do_disconnect() to use close_server_connection()
common/proto.h: Updated with new functions.
gtk-v2/glade/dialogs.glade: Add new windows for account login code.
gtk-v2/src/Makefile.am: Add account.c file.
gtk-v2/src/gtk2proto.h: Update with new functions.
gtk-v2/src/account.c: New file - does account logic.
gtk-v2/src/info.c: Change order of includes. Move some declarations
from this file to info.h. Generalize some of the handling so
other functions can use textbuffer but take advantage of the markup
processing provided in this file
gtk-v2/src/info.h: New file - declarations from info.c moved here.
gtk-v2/src/keys.c: Change order if include of main.h. Update to use
close_server_connection()
gtk-v2/src/main.c: Change order of includes. Add sample use of
custom glib log handler. Update to try and use loginmethod 1
gtk-v2/src/main.h: Add extern for csocket_fd so a bunch of
files don't have to declare it itself.
gtk-v2/src/map.c: Change ordering of includes.
gtk-v2/src/menubar.c: Update to sue close_server_connection()
gtk-v2/src/metaserver.c: change order of includes. Call
hide_all_login_windows() when bringing up metaserver window.
gtk-v2/src/opengl.c: Change order of includes.
gtk-v2/src/pickup.c: Change order of includes.
gtk-v2/src/spells.c: Change order of include of gtk2proto.h
----
MSW 2010-04-08
993 lines of code changed in 1 file:
- Convert tooltip_text fields to tooltip fields as mwedel reports that newer
versions of glade3 have issues with it (though the version I have does not).
- Remove has_tooltip settings not needed by the tooltip fields.
- Make sure all the tooltips have a Translatable property.
9 lines of code changed in 1 file:
- Rework un-deux.glade layout to support SVN revision 11699 changes to GTK-V2
client code. HP/SP/Grace/Food/Exp label is split up into four labels each,
and the encumbrance data is also split.
292 lines of code changed in 1 file:
(70 more)