/client/trunk Developers: kbulgrien

Login name:
Total Commits:
924 (22.2%)
Lines of Code:
87,428 (32.1%)
Most Recent Commit:
2012-09-28 02:10

Activity by Clock Time

Activity by Hour of Day for kbulgrien

Activity by Day of Week for kbulgrien

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 924 (100.0%) 87428 (100.0%) 94.6
gtk-v2/glade/ 206 (22.3%) 58208 (66.6%) 282.5
gtk-v2/src/ 231 (25.0%) 11773 (13.5%) 50.9
/ 217 (23.5%) 7861 (9.0%) 36.2
sound-src/ 56 (6.1%) 3399 (3.9%) 60.6
common/ 102 (11.0%) 2655 (3.0%) 26.0
macros/ 20 (2.2%) 1637 (1.9%) 81.8
common/shared/ 3 (0.3%) 736 (0.8%) 245.3
gtk-v2/ 17 (1.8%) 718 (0.8%) 42.2
gtk/ 33 (3.6%) 257 (0.3%) 7.7
x11/ 12 (1.3%) 84 (0.1%) 7.0
gtk-v2/themes/ 11 (1.2%) 63 (0.1%) 5.7
help/ 5 (0.5%) 16 (0.0%) 3.2
gtk/win32/ 3 (0.3%) 13 (0.0%) 4.3
utils/ 5 (0.5%) 4 (0.0%) 0.8
pixmaps/ 3 (0.3%) 4 (0.0%) 1.3

Activity of kbulgrien

Most Recent Commits

kbulgrien 2012-09-28 02:10 Rev.: 18461

- Character creation windows aesthetics dramatically improved. A window title
was added. Character name alignment is more consistent with the rest of the
window layout. Frames were added around information blocks. Wasted space
is used by pulling the race/class descriptions out of the stat table. Unused
points are now in the Total column and closer to the rest of the stat data.
- The starting map window aesthetics were improved. A window title was added
and the map selector is positioned at the top of the window rather than in
the middle.
- The add character dialog has minor modifications to improve consistency with
other dialogs.
- The password change dialog is more uniform looking.
- Add dialogs are set to not be deletable to avoid client failure when a user
might click on the [X] window control (some window managers do not
honor this).
- A liblade warning is no longer presetn at client startup. This was done by
Glade automatically. A widget was automatically removed when the project
was saved.
- Many widget names were changed to logical names that describe where they
appear in the various dialogs and what purpose they serve. These are not
functional changes, but they greatly improve readability of the layout.

1198 lines of code changed in 1 file:

  • gtk-v2/glade: dialogs.glade (+1198 -954)
kbulgrien 2012-09-26 00:19 Rev.: 18455

- Fix for choose_starting_map_window. Primarily making the dialog not
deletable since deleting the window completely hoses the client and
forces a restart. This also makes the dialog not ugly.

42 lines of code changed in 1 file:

  • gtk-v2/glade: dialogs.glade (+42 -13)
kbulgrien 2012-06-17 08:45 Rev.: 18265

- On Mageia 2, build with libfreeglut-devel failed due to the linker not
knowing to link with -lX11. In searching for a solution, I found the
AX_CHECK_GL, AX_CHECK_GLU, AX_CHECK_GLUT macros that are supposed to
improve compatibility various OpenGL implementations. See the files
here: http://code.google.com/p/autoconf-gl-macros/ . Though that did
not help with the X11 issue, the change is kept in the hope that it is
still an improvement. Though it was not used, the Microsoft compiler
detection support in this package was also included for completeness.
- The X11 issue seems to be related to a malfunction of AC_PATH_XTRA, as
it does not do what the documentation says it should do (at least in
this environment.) It does not set X_PRE_LIBS, X_LIBS, and X_XTRA_LIBS
and others seem to concur per web search. Though the AC_PATH_XTRA
method seems broken, this change hopefully leaves it as a fallback in
case the pkg_config method does not work.
- Since gtk-v2/src/Makefile is changed anyway, also fix the cproto/proto
target failure due to a upper/lowercase issue. A TAB/spaces consistency
issue is also addressed.
- The macros folder is updated to include the new M4 files that provide

523 lines of code changed in 7 files:

  • configure.ac (+70 -35)
  • gtk-v2/src: Makefile.am (+5 -5)
  • macros: Makefile.am (+4), ax_check_gl.m4 (new 148), ax_check_glu.m4 (new 141), ax_check_glut.m4 (new 114), ax_lang_compiler_ms.m4 (new 41)
kbulgrien 2010-10-26 22:56 Rev.: 14037

- Fix bogus doxygen @params directives.

12 lines of code changed in 1 file:

  • gtk-v2/src: create_char.c (+12 -8)
kbulgrien 2010-10-23 22:05 Rev.: 14023

- It is now possible to ./configure; cd gtk-v2/src; make to build the client,
without having to execute make at the top of the project first. This can
be helpful during development.

23 lines of code changed in 1 file:

  • gtk-v2/src: Makefile.am (+23 -4)
kbulgrien 2010-10-19 23:34 Rev.: 14010

- For almost the same reason given for removing the path, also remove the
dot extension on the sound names so that the server can append whatever
extension it wants to use.

163 lines of code changed in 1 file:

  • sound-src: sounds (+163 -161)
kbulgrien 2010-10-14 23:49 Rev.: 14002

- It is now possible to `./configure; cd sound-src; make` and build the sound
server without doing a top-level make.

27 lines of code changed in 1 file:

  • sound-src: Makefile.am (+27 -25)
kbulgrien 2010-10-14 06:54 Rev.: 14000

- Rename a missed reference to sounds.dist.

1 lines of code changed in 1 file:

  • sound-src: Makefile.am (+1 -1)
kbulgrien 2010-10-14 06:53 Rev.: 13999

- Do not encourage putting path names into the sounds file anymore. Instead,
commit it with no paths at the point of use rather than making it with a
script that translates the paths to the flavor of the day. cfsndserv is
now able to search multiple paths defined at build time.

206 lines of code changed in 2 files:

  • sound-src: Makefile.am (+1 -4), sounds (new 205)
kbulgrien 2010-10-14 06:48 Rev.: 13998

- Having hardcoded paths is a bad plan. Much better to allow the sound server
to be adaptable about where it locates sound files. Since the sound system
changed away from use of numbers, this file is almost useless anyway. For
now, remove the paths so we can use it as a cross-reference between sound
name and the sound number used by the original sound protocol.

0 lines of code changed in 2 files:

  • sound-src: sounds.dist (changed)
kbulgrien 2010-10-13 23:13 Rev.: 13997

- Remove warning: pointer targets in passing argument 1 of ‘StdinCmd’ differ
in signedness (for legacy sound systems).

1 lines of code changed in 1 file:

  • sound-src: cfsndserv.c (+1 -1)
kbulgrien 2010-10-13 23:11 Rev.: 13996

- Move an #ifdef to fix compilation for legacy sound systems.
- Fix a misspelling of StdinCmd in fd_server() function to fix compilation for
legacy sound systems.

5 lines of code changed in 1 file:

  • sound-src: cfsndserv.c (+5 -5)
kbulgrien 2010-10-13 23:01 Rev.: 13995

- Add #defines for commonly used sound server data directories and externs for
the pointer variables they will ultimately be used with.
- Add a helpful #define SOUND_DEBUG in this common file.
- Add an extern to the client replace_chars_with_string() function so that the
sound server can transparently support backslash delimited path strings.
- Rebuild to support the new stdin handler and the sound number and type
translator functions.
- Instead of allocating memory for paths each time a file is referenced, set
up pointers for each path that is used more than once, and allocate the
memory for them one time via init_sounds().
- Remove function prototypes as common.h is the correct place to put them.
- Update a comment relating to play_sound()'s sound_number parameter.
- Document the rationale behind use of MAXSOCKBUF for a file path buffer size.
- Remove individualized setup of paths at the point-of-use in init_sounds(),
write_settings(), and read_settings().
- To smooth the transition from sound to sound2 command support by cfsndserv,
or, rather, to temporarily limit the scope of the rewrite and speed time to
initial functionality testing, create a stub sound_to_soundnum() translator
to take legacy sound names and map them to sound numbers so all legacy
sound drivers do not have to be re-written all at once. For this commit,
the function is a stub, so sound effects are basically disabled, but the
code compiles cleanly.
- As with conversion of sound name to sound number, create type_to_soundtype()
to convert sound2 types to sound types so that legacy sound effects can be
played with minimal rewrite. This conversion layer is hopefully temporary,
but should allow minimally functional sound support much earlier as it
prevents a need to immediately rewrite the drivers for all supported sound
- Rename SoundCmd() to StdinCmd() and rewrite it to parse both sound2 and
music commands coming from the client over stdin. The format of commands
from the client is completely changed to support all of the parameters that
the sound2 protocol defines, and requires string arguments to be quoted to
make it easier to manage names with a variety of characters including white
space. StdinCmd() does basic parameter sanity checks on the data so it can
discard invalid commands. StdinCmd() detects the type of command by the
location of the quoted strings in the client commands.
- Add client includes to the sound server to allow more commonality between
the sound server and the client.
- Update the sound server notice that identifies how it is compiled and add
a statement summarizing what is supported and not supported.
- Standardize SOUND_DEBUG announcements when entering primary sound support
- Add a play_music() stub function to all legacy sound systems (ALSA, ALSA9,
Sun, SGI, and OSS) that does nothing when they are selected, and add a very
basic (but functional) play_music() function that plays music if SDL_SOUND
is compiled in. Having play_music() available for all sound systems lets
StdinCmd() remain the same no matter which sound system is built.
- Rename calls to SoundCmd() to StdinCmd().
- Move the helpful #define SOUND_DEBUG to common.h.
- Relocate all SDL_mixer sound support functions into the same #ifdef and all
the legacy functions into the same #else to put the related functions in
closer proximity with each other.

741 lines of code changed in 6 files:

  • ChangeLog (+13)
  • sound-src: alsa9.c (+36 -10), cfsndserv.c (+395 -230), common.c (+274 -62), common.h (+20 -1), sndproto.h (+3 -1)
kbulgrien 2010-10-13 19:55 Rev.: 13994

- Fix make complaint about having two targets that resolve to the same

4 lines of code changed in 1 file:

  • sound-src: Makefile.am (+4 -5)
kbulgrien 2010-10-13 19:49 Rev.: 13993

- Fix duplicate reference to cfsndserv instead of a reference to the alsa9

1 lines of code changed in 1 file:

  • sound-src: Makefile.am (+1 -1)
kbulgrien 2010-10-12 22:19 Rev.: 13992

- Remove duplicate of strdup_local() in common.c. It is in ../common/misc.c,
so it seems silly not to link with ../common/libccflient.a rather than have
it two places in the same project. Furthermore, for sound and music, more
functions from ../common are needed, so this is also prep work for that.

34 lines of code changed in 4 files:

  • sound-src: Makefile.am (+31 -15), common.c (-12), common.h (+3), sndproto.h (-1)
kbulgrien 2010-10-07 21:26 Rev.: 13974

- Got a bit hasty on that last commit eh? Update various play_sound()
references to play_sound_effect().

6 lines of code changed in 1 file:

  • gtk-v2/src: sound.c (+6 -6)
kbulgrien 2010-10-07 21:22 Rev.: 13973

- Rename the play_sound() function to avoid a name conflict with a cfsndserv
function of the same name. It messes up the doxygen call graphs.
- Reverse the order of the sound and source names sent to cfsndserv so that
the name of the sound effect or music is always the last quoted string on
the command line as it makes the command parse a little nicer on the
cfsndserv end of the pipe.

11 lines of code changed in 2 files:

  • gtk-v2/src: gtk2proto.h (+1 -1), sound.c (+10 -3)
kbulgrien 2010-10-07 06:43 Rev.: 13971

- Disable developer aids in sound/music functions. They were accidentally
turned on at revision 13969.

3 lines of code changed in 1 file:

  • gtk-v2/src: sound.c (+3 -3)
kbulgrien 2010-10-06 23:03 Rev.: 13970

- Doxygen comment rework for Sound2Cmd() and MusicCmd().

13 lines of code changed in 1 file:

  • gtk-v2/src: sound.c (+13 -4)

(328 more)

Generated by StatSVN 0.7.0