Directory server/trunk/server/

Lines of Code

Developers

Most Recent Commits

partmedia 2020-04-22 21:04 Rev.: 21219

Set timeout to zero when trying to swap map with player

1 lines of code changed in 1 file:

• server/trunk/server: swap.c (+1)

ryo_saeba 2020-04-13 08:44 Rev.: 21208

Add 'dumpabove' command, similar to 'dumpbelow'.

29 lines of code changed in 2 files:

• server/trunk/server: c_wiz.c (+28 -10), commands.c (+1)

ryo_saeba 2020-04-13 03:26 Rev.: 21206

Fix comment.

6 lines of code changed in 1 file:

• server/trunk/server: skill_util.c (+6 -2)

partmedia 2020-04-13 01:00 Rev.: 21205

Clear last_skill_ob before removing inventory

6 lines of code changed in 1 file:

• server/trunk/server: login.c (+6)

partmedia 2020-04-02 16:21 Rev.: 21203

Refactor with find_applied_skill_by_name()

While here, warn instead of crashing when last_skill_ob[i]->skill is
NULL. It is not yet clear why that happens.

7 lines of code changed in 2 files:

• server/trunk/server: attack.c (+1 -11), spell_util.c (+6 -8)

partmedia 2020-04-02 16:21 Rev.: 21202

Improve shutdown handling

- Shut down immediately on signal or 'shutdown now', instead of waiting
up to 51 ticks
- Warn players on login, and more often

48 lines of code changed in 2 files:

• server/trunk/server: login.c (+2), server.c (+46 -29)

ryo_saeba 2020-04-01 15:41 Rev.: 21201

Fix comment.

2 lines of code changed in 1 file:

• server/trunk/server: skill_util.c (+2 -2)

partmedia 2020-03-21 13:36 Rev.: 21189

Reduce indirection

Submitted by: Frank Wilde <F.Wilde@casino2000.lu>

4 lines of code changed in 1 file:

• server/trunk/server: party.c (+4 -3)

partmedia 2020-03-21 13:36 Rev.: 21188

Refactor duplicate empty party removal code

Submitted by: Frank Wilde <F.Wilde@casino2000.lu>

19 lines of code changed in 1 file:

• server/trunk/server: party.c (+19 -36)

partmedia 2020-03-21 13:35 Rev.: 21187

Move same-party rejoin check to party_join()

Submitted by: Frank Wilde <F.Wilde@casino2000.lu>

9 lines of code changed in 2 files:

• server/trunk/server: c_party.c (-7), party.c (+9 -1)

partmedia 2020-03-20 19:28 Rev.: 21184

Improve 'maps' command output

24 lines of code changed in 1 file:

• server/trunk/server: c_misc.c (+24 -20)

partmedia 2020-03-20 19:28 Rev.: 21181

Play sound for all kills

1 lines of code changed in 1 file:

• server/trunk/server: attack.c (+1 -3)

akirschbaum 2020-03-14 14:30 Rev.: 21169

Explicitly handle missing archetypes

4 lines of code changed in 1 file:

• server/trunk/server: plugins.c (+4 -2)

partmedia 2020-03-14 02:13 Rev.: 21160

Fix build

1 lines of code changed in 1 file:

• server/trunk/server: shop.c (+1 -1)

akirschbaum 2020-03-13 14:06 Rev.: 21159

Fix some crashes caused by accesses to missing archetypes

133 lines of code changed in 6 files:

• server/trunk/server: attack.c (+3 -1), knowledge.c (+3), player.c (+68 -50), resurrection.c (+6 -3), shop.c (+9 -4), spell_effect.c (+44 -21)

partmedia 2020-03-13 12:58 Rev.: 21158

Return NULL if searching for the 0 skill

No skill has a subtype of 0; in fact, item_types uses 0 to represent
item types that cannot be identified with a skill.

However, due to a separate issue, find_skill_by_number() may find skill
tools with a matching subtype of 0 but no skill associated with it
(since skills have subtypes correctly set). Then adjust_skill_tool()
will try to give the player a new skill, which might duplicate a skill
the player already has.

4 lines of code changed in 1 file:

• server/trunk/server: skill_util.c (+4)

partmedia 2020-03-13 12:58 Rev.: 21157

Set swapped map timeout to 0

1 lines of code changed in 1 file:

• server/trunk/server: swap.c (+1)

partmedia 2020-03-13 12:58 Rev.: 21156

Run map change events when entering a tiled map

22 lines of code changed in 2 files:

• server/trunk/server: player.c (+3 -8), server.c (+19 -15)

partmedia 2020-03-13 12:58 Rev.: 21154

Use strlcpy() instead of snprintf()

38 lines of code changed in 10 files:

• server/trunk/server: c_chat.c (+2 -2), c_misc.c (+10 -10), c_object.c (+1 -1), c_wiz.c (+2 -2), knowledge.c (+1 -1), login.c (+2 -2), party.c (+2 -2), player.c (+4 -4), plugins.c (+2 -2), server.c (+12 -12)

partmedia 2020-03-12 00:54 Rev.: 21152

Add error message for observed crash

7 lines of code changed in 1 file:

• server/trunk/server: attack.c (+7 -4)

partmedia 2020-03-12 00:06 Rev.: 21151

Limit number of map swaps per tick

Swapping can take many tens of milliseconds. Swapping too many maps in
one tick can cause enough latency for the server to skip time.

10 lines of code changed in 1 file:

• server/trunk/server: swap.c (+10 -3)

partmedia 2020-03-11 11:25 Rev.: 21144

Retire MAX_OBJECTS

MAX_OBJECTS has probably outlived its usefulness. It was previously "no
hard limit," only serving to trigger map swapping immediately after
loading a map, if the number of used objects exceeded MAX_OBJECTS.

At worse case, MAX_OBJECTS causes an O(n^2) search and O(n) swaps, where
n is the number of maps in memory. This happens immediately after
loading a very large map. The server takes O(n) to search for the map
with the smallest remaining timeout and swaps it, and does this n times
or until enough memory is freed. If the other maps are small, this does
not free much memory and causes the "performance hit" mentioned in the
comments. This was observed on Invidious, where the server experienced
delays of up to 700 ms immediately after loading a large map due to
excessive swapping.

Removing MAX_OBJECTS does not significantly change the server's
allocation pattern because the server never frees memory (it maintains
an internal free list) and because maps are swapped out based on timeout
at the end of each tick anyway.

2 lines of code changed in 4 files:

• server/trunk/server: c_misc.c (+1 -2), monster.c (+1 -1), server.c (-1), swap.c (-53)

partmedia 2020-03-08 20:49 Rev.: 21143

Improve 'malloc' command output

29 lines of code changed in 1 file:

• server/trunk/server: c_misc.c (+29 -7)

partmedia 2020-03-08 20:49 Rev.: 21141

Remove PlM column from 'maps' command

m->players should never disagree with players_on_map(m, FALSE), so this
column is redundant.

3 lines of code changed in 1 file:

• server/trunk/server: c_misc.c (+3 -3)

partmedia 2020-03-08 20:49 Rev.: 21140

Revert "Reduce calls to monster_compute_path"

This change caused several crashes on Invidious:

Program terminated with signal SIGSEGV, Segmentation fault.
853: FOR_MAP_PREPARE(op->map, op->x+freearr_x[rv.direction], op->y+freearr_y[rv.direction], tmp)

1 lines of code changed in 1 file:

• server/trunk/server: monster.c (+1 -24)

partmedia 2020-03-05 01:35 Rev.: 21133

Fix source distribution

0 lines of code changed in 1 file:

• server/trunk/server: Makefile.am (-5)

partmedia 2020-03-04 21:56 Rev.: 21131

Call apply_manual() instead of ob_apply()

When a monster reads a scroll, the monster should be subject to the
usual race restriction check before applying it.

1 lines of code changed in 1 file:

• server/trunk/server: monster.c (+1 -1)

partmedia 2020-03-04 21:56 Rev.: 21130

Move apply event hook from apply_manual() to ob_apply()

Some code paths call ob_apply() directly without going through
apply_manual(). In these cases, the apply event hook is not run.

0 lines of code changed in 1 file:

• server/trunk/server: apply.c (-4)

ryo_saeba 2020-03-02 14:42 Rev.: 21124

Allow multiple skills to share the same subtype.
This is useful for skills like harvesting (fishing, mining, and such) which work similarly and only differ in the skill.
As a side-effect, skill_names is no more indexed by the skill's subtype.

35 lines of code changed in 4 files:

• server/trunk/server: attack.c (+1 -1), player.c (+1 -1), skill_util.c (+30 -29), spell_util.c (+3 -3)

ryo_saeba 2020-02-26 16:44 Rev.: 21119

Move function to common library.

0 lines of code changed in 1 file:

• server/trunk/server: skill_util.c (-26)

partmedia 2020-02-26 14:38 Rev.: 21116

Update comments and error messages

24 lines of code changed in 1 file:

• server/trunk/server: server.c (+24 -20)

partmedia 2020-02-26 14:38 Rev.: 21115

Fix double use of variable

3 lines of code changed in 1 file:

• server/trunk/server: server.c (+3 -3)

ryo_saeba 2020-02-26 14:29 Rev.: 21114

Simply calling, since we know the skill exact name.

22 lines of code changed in 1 file:

• server/trunk/server: c_object.c (+22 -12)

ryo_saeba 2020-02-17 16:53 Rev.: 21110

Fix crash if a tool asks for a non existing skill.

Crash seen as part of https://sourceforge.net/p/crossfire/patches/363/

6 lines of code changed in 1 file:

• server/trunk/server: skill_util.c (+6 -1)

partmedia 2020-02-11 17:13 Rev.: 21102

Refactor cult-switching

30 lines of code changed in 1 file:

• server/trunk/server: gods.c (+30 -34)

partmedia 2020-02-11 16:54 Rev.: 21100

Make CFPython Object.Level settable

While here, send a missing item update in cfapi_object_set_property().

1 lines of code changed in 1 file:

• server/trunk/server: plugins.c (+1)

partmedia 2019-12-29 22:21 Rev.: 21077

Refactor monster_npc_call_help()

7 lines of code changed in 1 file:

• server/trunk/server: monster.c (+7 -10)

partmedia 2019-12-28 08:29 Rev.: 21069

Refactor recipe_chance()

Rewrite and document recipe_chance() so it's more clear what it does.

26 lines of code changed in 1 file:

• server/trunk/server: alchemy.c (+26 -12)

partmedia 2019-12-26 22:12 Rev.: 21063

Update item name when applying item

Applying an item identifies its enchantment, which changes the base
name. Send the client a name update.

1 lines of code changed in 1 file:

• server/trunk/server: apply.c (+1 -1)

partmedia 2019-12-26 20:56 Rev.: 21060

Rename 'quit' command to 'delete'

Make it harder to delete a character by renaming 'quit' to 'delete'. New
players have been known to accidentally delete their character despite
the warning.

15 lines of code changed in 2 files:

• server/trunk/server: c_misc.c (+14 -1), commands.c (+1)

(1537 more)