/client/trunk Developers: kstenger

Login name:
kstenger
Total Commits:
24 (0.6%)
Lines of Code:
742 (0.3%)
Most Recent Commit:
2014-03-06 20:57

Activity by Clock Time

Activity by Hour of Day for kstenger

Activity by Day of Week for kstenger

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 24 (100.0%) 742 (100.0%) 30.9
gtk-v2/src/ 18 (75.0%) 619 (83.4%) 34.3
gtk-v2/ui/ 2 (8.3%) 109 (14.7%) 54.5
common/ 4 (16.7%) 14 (1.9%) 3.5

Activity of kstenger

Most Recent Commits

kstenger 2014-03-06 20:57 Rev.: 19262

Set minimum window size at startup.
These lines where removed by revision 19186, but this caused weird effects.

8 lines of code changed in 1 file:

  • gtk-v2/src: main.c (+8)
kstenger 2013-12-30 19:54 Rev.: 19202

Undo the changes made in revision 19200. Found a better place/way to do it.

When the player is initialized in new_player() initialize the bindings too.
Added keybindings_init to common/external.h to be able to do it.

5 lines of code changed in 3 files:

  • common: external.h (+1), player.c (+3)
  • gtk-v2/src: stats.c (+1 -5)
kstenger 2013-12-30 19:49 Rev.: 19201

Forgot to use the servername when saving the char bindings file too.

2 lines of code changed in 1 file:

  • gtk-v2/src: keys.c (+2 -2)
kstenger 2013-12-30 16:05 Rev.: 19200

Add some compatibility for older servers to use char-specific bindings.
It's probably not the best solution: update bindings when redrawing stats.
When the playername label has to be updated it's a good sign that the bindings
also should, and it's the right moment to get the character's name
if the server doesn't support accounts.

5 lines of code changed in 1 file:

  • gtk-v2/src: stats.c (+5 -1)
kstenger 2013-12-30 15:27 Rev.: 19199

Add the servername as a part of the char specific keys filename allowing
to have characters with the same name have different bindings for each
server they belong.

2 lines of code changed in 1 file:

  • gtk-v2/src: keys.c (+2 -1)
kstenger 2013-12-30 10:50 Rev.: 19197

Added the chance to bind a global key with the 'bind' command.

4 lines of code changed in 1 file:

  • gtk-v2/src: keys.c (+4)
kstenger 2013-12-30 10:39 Rev.: 19196

Changed the 'user' scope name to 'global' as suggested by Partmedia.

Corrected a couple of details in some comments while at it.
And removed a couple of spaces by the end of the lines (which my editor
insists in erasing).

No functional changes.

64 lines of code changed in 3 files:

  • gtk-v2/src: gtk2proto.h (+1 -1), keys.c (+59 -59)
  • gtk-v2/ui: dialogs.ui (+4 -4)
kstenger 2013-12-30 08:33 Rev.: 19193

Added support for scoped keybindings.

When bindings are loaded let them know where they come from by adding a flag indicating if it comes from the character's keys file or from the user's keys file.
I found it easier to put default keybindings into the user's scope too, it won't hurt.

Load them separatedly to ease their maintenance.

Adapt the keybindings management window to let the user see and switch scopes.

TODO: add support for the 'bind' command to save user scoped new bindings (by defauld it saves them into the character's scope).

554 lines of code changed in 3 files:

  • gtk-v2/src: gtk2proto.h (+2), keys.c (+447 -189)
  • gtk-v2/ui: dialogs.ui (+105 -5)
kstenger 2013-12-16 13:47 Rev.: 19182

Change the order in which keybinding's files are loaded.
Now defaults go first, then user global bindings, then character specific bindings.
So also changed what we do when a binding is inserted, if it already exists do not return error and leave but overwrite it instead.
EKEYBIND_TAKEN was so useless and got removed.
Use keybind_find() instead of keybind_insert() at several places to check for previous existance when we don't want to overwrite the previous binding.

43 lines of code changed in 1 file:

  • gtk-v2/src: keys.c (+43 -34)
kstenger 2013-12-16 10:26 Rev.: 19181

Remove never used if statement.

0 lines of code changed in 1 file:

  • gtk-v2/src: keys.c (-5)
kstenger 2013-12-16 10:20 Rev.: 19180

Add deprecation warning for bindings 'S' flag.

4 lines of code changed in 1 file:

  • gtk-v2/src: keys.c (+4)
kstenger 2013-12-16 10:15 Rev.: 19179

Turn uppercase bindings to lowercase with the shift flag on.
Fixes bug #766.

8 lines of code changed in 1 file:

  • gtk-v2/src: keys.c (+8 -1)
kstenger 2013-10-12 16:16 Rev.: 19081

Tweak to get the colored stat bars to work.
This worked after a lot of trial and error and disabling my theme's pixmaps.
Hopefully won't break anything on other systems.

3 lines of code changed in 1 file:

  • gtk-v2/src: stats.c (+3)
kstenger 2013-10-09 13:27 Rev.: 19080

Add an "unidentified" flag when sending information about an item to a script.

4 lines of code changed in 1 file:

  • common: script.c (+4 -3)
kstenger 2013-09-04 11:18 Rev.: 18980

Update status of the key modifiers to 0 when the main window looses focus.

30 lines of code changed in 3 files:

  • gtk-v2/src: gtk2proto.h (+1), keys.c (+24), main.c (+5)
kstenger 2013-09-03 12:32 Rev.: 18972

Function script_tell() modifies the command it receives.
Since the parameter is a pointer to the command, it was actually modifying the binding command itself when you used a binding.
Now it will only modify a local copy of the command making it posible to actually bind things to tell to your scripts.

6 lines of code changed in 1 file:

  • common: script.c (+6 -2)
Generated by StatSVN 0.7.0