Activity by Clock Time
| Directory | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 1297 (100.0%) | 105344 (100.0%) | 81.2 |
| gtk-v2/ui/ | 100 (7.7%) | 80330 (76.3%) | 803.3 |
| gtk-v2/src/ | 446 (34.4%) | 8033 (7.6%) | 18.0 |
| common/ | 342 (26.4%) | 5329 (5.1%) | 15.5 |
| gtk-v2/glade/ | 38 (2.9%) | 5101 (4.8%) | 134.2 |
| sound-src/ | 116 (8.9%) | 2598 (2.5%) | 22.3 |
| / | 130 (10.0%) | 2042 (1.9%) | 15.7 |
| common/shared/ | 6 (0.5%) | 767 (0.7%) | 127.8 |
| gtk-v2/ | 16 (1.2%) | 550 (0.5%) | 34.3 |
| cmake/ | 2 (0.2%) | 262 (0.2%) | 131.0 |
| macros/ | 37 (2.9%) | 170 (0.2%) | 4.5 |
| pixmaps/ | 28 (2.2%) | 98 (0.1%) | 3.5 |
| utils/ | 7 (0.5%) | 34 (0.0%) | 4.8 |
| gtk-v2/win32/ | 13 (1.0%) | 28 (0.0%) | 2.1 |
| help/ | 6 (0.5%) | 1 (0.0%) | 0.1 |
| gtk-v2/themes/ | 4 (0.3%) | 1 (0.0%) | 0.2 |
| doc/examples/script/ | 2 (0.2%) | 0 (0.0%) | 0.0 |
| doc/ | 1 (0.1%) | 0 (0.0%) | 0.0 |
| Documentation/examples/script/ | 2 (0.2%) | 0 (0.0%) | 0.0 |
| Documentation/ | 1 (0.1%) | 0 (0.0%) | 0.0 |
Add metaserver refresh button
40 lines of code changed in 2 files:
Simplify combo box population
11 lines of code changed in 1 file:
Remove GtkObject
12 lines of code changed in 5 files:
Use accessors where possible
7 lines of code changed in 3 files:
Fix data type
1 lines of code changed in 1 file:
Update key symbols
20 lines of code changed in 1 file:
Rename CMake GTK variable name
9 lines of code changed in 4 files:
Improve latency profiler output
14 lines of code changed in 1 file:
Update data type
1 lines of code changed in 1 file:
Really bump version string
1 lines of code changed in 1 file:
Refactor; remove notes about performance
There is probably no performance benefit from reducing the number of
calls to mapdata_cell(). However, this particular change made the code
more readable, so keep this change. I refactored the scope of the new
temporary MapCell variables.
I compared the assembly of the old code with the new code. I used clang
8.0.1 with -O2 on FreeBSD/amd64. In both versions, the assembly has
mapdata_cell() inlined and lifted out of the inner loop:
movq the_map(%rip), %r12
movslq %edi, %r13
movslq %esi, %rax
imulq $152, %rax, %r15
movq (%r12,%r13,8), %rdi
addq %r15, %rdi
Even though the old code has multiple calls and the new code has an
intermediate variable, both generated the same code! Notice how the
result of "calling" mapdata_cell() is never stored in memory; it stays
in a register.
In general, in the age of deep pipelines, large caches, and speculative
execution, even comparing assembly is generally not enough. However,
when both versions produce the same assembly, it's a pretty convincing
argument that there is no performance benefit.
There are plenty of inefficiencies hanging around in the client, for
example, the unnecessary double-buffering in Pixmap mode, that when
fixed would produce a measurable performance benefit. But trying to
outsmart the compiler probably isn't going to do much.
3 lines of code changed in 2 files:
Bump version string to 1.74.0
4 lines of code changed in 2 files:
Add latency profile printer
26 lines of code changed in 1 file:
Replace non-null assertion with null check
This assertion gets triggered when the server exits right when the
client is connecting. Exit with an error instead.
6 lines of code changed in 1 file:
Make profiling output easier to parse
3 lines of code changed in 2 files:
Remove inventory table column limit
32 lines of code changed in 2 files:
Fix table view for large inventories
Fun fact: this bug has been here since the GTKv2 client landed in r3083!
3 lines of code changed in 2 files:
Simplify cell removal
2 lines of code changed in 1 file:
Use one treestore for all tab views
21 lines of code changed in 1 file:
Avoid redrawing on expose event
Since the inventory table is already redrawn when the main loop is idle,
avoid redrawing on expose to prevent the main loop from freezing up from
expose events when the redraw time is long.
0 lines of code changed in 1 file:
(395 more)