gtk-v2/src/info.c: Add missing initializer to pane variable. Without it,
we are passing in garbage value to functions, which results in crashes.
MSW 2008-12-29
5 lines of code changed in 2 files:
- Add/update code comments throughout, including function headers for doxygen.
65 lines of code changed in 1 file:
make proto in the GTK-V2 source directory yielded an error about a missing
about.h file. Additional includes are passed to cproto to remove this
error.
7 lines of code changed in 2 files:
The GTK-V2 client for some reason saved the window positions file multiple
times per use of menubar Client | Save Window Position. Adding a call to
g_signal_stop_emission_by_name() in on_save_window_position_activate()
puts this silliness to an end. The file is now only saved one time.
11 lines of code changed in 2 files:
- Add doxygen-style comments to identify what functions do.
11 lines of code changed in 2 files:
Remove "(crossfire-client-gtk2:2088): Gtk-WARNING **: GtkSpinButton: setting
an adjustment with non-zero page size is deprecated run-time warnings for the GTK-V2 client.
31 lines of code changed in 12 files:
Complete fixing GTK-V1 issue [ 1876788 ] Doubled characters in GTK clients
(unusable). Tested with --enable-cfgtk2 compiled as RPM.
8 lines of code changed in 2 files:
Misc compilation tweaks, no functional change.
9 lines of code changed in 4 files:
gtk_signal_emit_stop_by_name() was poorly placed and is moved to a location
where it will help fix the [ 1876788 ] Doubled characters in GTK clients
(unusable) for the GTK-V1 client.
10 lines of code changed in 2 files:
- The fix applied for [ 2022488 ] and [ 1862055 ] was for a GTK-V1 client
compiled against GTK2, but used a function probably not in GTK1, so this
commit changes it back to a GTK1 function used elsewhere in keyfunc() and
in the GTK1 docs: http://www.gtk.org/tutorial1.2/gtk_tut-18.html#ss18.1
2 lines of code changed in 1 file:
- Mark another open bug [2022488] as fixed by SVN 10960.
3 lines of code changed in 1 file:
Fix for [ 1862055 ] GTKv1 client built with --enable-cfgtk2 cannot login so
it is no longer necessary to run the client with Popup Windows.
14 lines of code changed in 2 files:
Pending fix for [ 1876788 ] Doubled characters in GTK clients (unusable).
mwedel noted gtk_signal_emit_stop_by_name() was not used consistently
everywhere keypresses were consumed by the client. Patches were written
and tested to show that consistent use of gtk_signal_emit_stop_by_name()
caused the doubled character problem to disappear. Then a new patch was
written to replace redundant call/return pairs with fall-through logic.
http://www.gtk.org/api/2.6/gtk/gtk-Signals.html#gtk-signal-emit-stop-by-name
also states this is a deprecated function, g_signal_stop_emission_by_name()
is now used instead of gtk_signal_emit_stop_by_name().
121 lines of code changed in 2 files: