- Fix bogus doxygen @params directives.
12 lines of code changed in 1 file:
Fix building client with build directory separate from source directory.
11 lines of code changed in 3 files:
- It is now possible to ./configure; cd gtk-v2/src; make to build the client,
without having to execute make at the top of the project first. This can
be helpful during development.
23 lines of code changed in 1 file:
Commit client side support for new in client character creation.
common/client.h: Add various new globals for map, race, and class info.
common/commands.c: Move Race_Class_Info structure to header file, add
new global declarations. Add handling of requesting and storing
starting map information from server. Handle newcharinfo
protocol command.
common/external.h: Add new external calls.
common/init.c: Add calls to free race and class data.
common/proto.h: Add new prototype
gtk-v2/glade/dialogs.glade: Update dialogs.glade file with new
window for creating character.
gtk-v2/src/Makefile.am: Add create_char.c file
gtk-v2/src/account.c: Add calls for popups and to show the choose
character window. Add handling for new character creation method.
gtk-v2/src/create_char.c: New file that handles character creation logic.
gtk-v2/src/gtk2proto.h: Update with new functions
gtk-v2/src/main.c: update loginmethod to 2, add call to
init_create_character_window()
gtk-v2/src/main.h: Add global reference to account password
gtk-v2/src/stats.c: Make some widgets static to the file.
MSW 2010-10-20
2072 lines of code changed in 15 files:
- For almost the same reason given for removing the path, also remove the
dot extension on the sound names so that the server can append whatever
extension it wants to use.
163 lines of code changed in 1 file:
- It is now possible to `./configure; cd sound-src; make` and build the sound
server without doing a top-level make.
27 lines of code changed in 1 file:
Fix minor syntax error for sun sound.
MSW 2010-10-14
1 lines of code changed in 1 file:
- Rename a missed reference to sounds.dist.
1 lines of code changed in 1 file:
- Do not encourage putting path names into the sounds file anymore. Instead,
commit it with no paths at the point of use rather than making it with a
script that translates the paths to the flavor of the day. cfsndserv is
now able to search multiple paths defined at build time.
206 lines of code changed in 2 files:
- Having hardcoded paths is a bad plan. Much better to allow the sound server
to be adaptable about where it locates sound files. Since the sound system
changed away from use of numbers, this file is almost useless anyway. For
now, remove the paths so we can use it as a cross-reference between sound
name and the sound number used by the original sound protocol.
0 lines of code changed in 2 files:
- Remove warning: pointer targets in passing argument 1 of ‘StdinCmd’ differ
in signedness (for legacy sound systems).
1 lines of code changed in 1 file:
- Move an #ifdef to fix compilation for legacy sound systems.
- Fix a misspelling of StdinCmd in fd_server() function to fix compilation for
legacy sound systems.
5 lines of code changed in 1 file:
common.h
- Add #defines for commonly used sound server data directories and externs for
the pointer variables they will ultimately be used with.
- Add a helpful #define SOUND_DEBUG in this common file.
- Add an extern to the client replace_chars_with_string() function so that the
sound server can transparently support backslash delimited path strings.
sndproto.h
- Rebuild to support the new stdin handler and the sound number and type
translator functions.
common.c
- Instead of allocating memory for paths each time a file is referenced, set
up pointers for each path that is used more than once, and allocate the
memory for them one time via init_sounds().
- Remove function prototypes as common.h is the correct place to put them.
- Update a comment relating to play_sound()'s sound_number parameter.
- Document the rationale behind use of MAXSOCKBUF for a file path buffer size.
- Remove individualized setup of paths at the point-of-use in init_sounds(),
write_settings(), and read_settings().
- To smooth the transition from sound to sound2 command support by cfsndserv,
or, rather, to temporarily limit the scope of the rewrite and speed time to
initial functionality testing, create a stub sound_to_soundnum() translator
to take legacy sound names and map them to sound numbers so all legacy
sound drivers do not have to be re-written all at once. For this commit,
the function is a stub, so sound effects are basically disabled, but the
code compiles cleanly.
- As with conversion of sound name to sound number, create type_to_soundtype()
to convert sound2 types to sound types so that legacy sound effects can be
played with minimal rewrite. This conversion layer is hopefully temporary,
but should allow minimally functional sound support much earlier as it
prevents a need to immediately rewrite the drivers for all supported sound
systems.
- Rename SoundCmd() to StdinCmd() and rewrite it to parse both sound2 and
music commands coming from the client over stdin. The format of commands
from the client is completely changed to support all of the parameters that
the sound2 protocol defines, and requires string arguments to be quoted to
make it easier to manage names with a variety of characters including white
space. StdinCmd() does basic parameter sanity checks on the data so it can
discard invalid commands. StdinCmd() detects the type of command by the
location of the quoted strings in the client commands.
alsa9.c
common.c
cfsndserv.c
- Add client includes to the sound server to allow more commonality between
the sound server and the client.
alsa9.c
cfsndserv.c
- Update the sound server notice that identifies how it is compiled and add
a statement summarizing what is supported and not supported.
- Standardize SOUND_DEBUG announcements when entering primary sound support
functions.
- Add a play_music() stub function to all legacy sound systems (ALSA, ALSA9,
Sun, SGI, and OSS) that does nothing when they are selected, and add a very
basic (but functional) play_music() function that plays music if SDL_SOUND
is compiled in. Having play_music() available for all sound systems lets
StdinCmd() remain the same no matter which sound system is built.
- Rename calls to SoundCmd() to StdinCmd().
cfsndserv.c
- Move the helpful #define SOUND_DEBUG to common.h.
- Relocate all SDL_mixer sound support functions into the same #ifdef and all
the legacy functions into the same #else to put the related functions in
closer proximity with each other.
741 lines of code changed in 6 files:
- Fix make complaint about having two targets that resolve to the same
library.
4 lines of code changed in 1 file:
- Fix duplicate reference to cfsndserv instead of a reference to the alsa9
version.
1 lines of code changed in 1 file:
- Remove duplicate of strdup_local() in common.c. It is in ../common/misc.c,
so it seems silly not to link with ../common/libccflient.a rather than have
it two places in the same project. Furthermore, for sound and music, more
functions from ../common are needed, so this is also prep work for that.
34 lines of code changed in 4 files:
Fix some bugs found by static analysis (dead assignment, NULL dereference) using clang-analyzer.
101 lines of code changed in 5 files:
Fix a number of serious compiler warnings (passing pointer to integer of different size, discarding const qualifiers).
10 lines of code changed in 7 files:
- Got a bit hasty on that last commit eh? Update various play_sound()
references to play_sound_effect().
6 lines of code changed in 1 file:
- Rename the play_sound() function to avoid a name conflict with a cfsndserv
function of the same name. It messes up the doxygen call graphs.
- Reverse the order of the sound and source names sent to cfsndserv so that
the name of the sound effect or music is always the last quoted string on
the command line as it makes the command parse a little nicer on the
cfsndserv end of the pipe.
11 lines of code changed in 2 files:
- Disable developer aids in sound/music functions. They were accidentally
turned on at revision 13969.
3 lines of code changed in 1 file:
- Doxygen comment rework for Sound2Cmd() and MusicCmd().
13 lines of code changed in 1 file:
- Fix a doxygen complaint about the use of unsupported XML/HTML tags in a
Sound2Cmd() and MusicCmd().
6 lines of code changed in 1 file:
- Make the gtk-v2 client compatible with the sound2 protocol from the server
and complete the unfinished implementations in Sound2Cmd() and MusicCmd().
This makes the client ready for sound2 and music by altering the format of
data sent to cfsndserv. cfsndserv is incompatible with the sound2 protocol
because sound numbers have been dispensed with, so the change in format of
data piped to cfsndserv does not break anything any worse than it already
was.
122 lines of code changed in 3 files:
- Add the common/shared folder to INCLUDES.
- Reformat for readability, and remove DEFAULT_INCLUDES from the proto target
to get rid of duplicate includes.
14 lines of code changed in 1 file:
Fix out of tree build. common/Makefile.am called some scripts that were not properly handling the case of source directory and build directory differing.
8 lines of code changed in 4 files:
- Give sound-serv access to the shared newclient.h file, and update the proto
target with similar changes.
5 lines of code changed in 1 file:
Add 'containers' pickup menu item.
100 lines of code changed in 15 files: