StatSVN - Developers: toxicfrog

Activity by Clock Time

Activity by Hour of Day for toxicfrog

Activity by Day of Week for toxicfrog

Activity in Directories

Directory	Changes	Lines of Code	Lines per Change
Totals	33 (100.0%)	116 (100.0%)	3.5
server/trunk/common/	7 (21.2%)	57 (49.1%)	8.1
server/trunk/server/	16 (48.5%)	41 (35.3%)	2.5
server/trunk/	1 (3.0%)	6 (5.2%)	6.0
server/trunk/test/toolkit/	1 (3.0%)	3 (2.6%)	3.0
server/trunk/socket/	3 (9.1%)	3 (2.6%)	1.0
server/trunk/types/spellbook/	1 (3.0%)	2 (1.7%)	2.0
server/trunk/types/identify_altar/	1 (3.0%)	2 (1.7%)	2.0
server/trunk/include/	1 (3.0%)	2 (1.7%)	2.0
server/trunk/test/unit/common/	1 (3.0%)	0 (0.0%)	0.0
server/trunk/test/include/	1 (3.0%)	0 (0.0%)	0.0

Activity of toxicfrog

Most Recent Commits

toxicfrog 2020-09-14 08:43 Rev.: 21430

Fix segfault when calling is_identifiable_type() on something with no typedata

Thanks to Preston Crow on crossfire-devel for the bug report.

5 lines of code changed in 1 file:

server/trunk/common: item.c (+5 -1)

toxicfrog 2020-09-13 16:41 Rev.: 21426

Reorder output of successful spellbook reading

On a successful read, it will now show you the contents of the book
(i.e. the spell description) followed by "you succeed in learning the
spell", rather than telling you that you succeed first and then
displaying the book contents.

8 lines of code changed in 2 files:

server/trunk: ChangeLog (+6 -2)
server/trunk/types/spellbook: spellbook.c (+2 -2)

toxicfrog 2020-09-13 16:41 Rev.: 21425

Removing trailing whitespace from a lot of files

This has no effect but to make the diffs cleaner, since a lot of people
(including me) use editors that strip trailing whitespace by default.

36 lines of code changed in 14 files:

server/trunk/common: artifact.c (+1 -1), living.c (+5 -5), map.c (+1 -1), object.c (+2 -2)
server/trunk/server: attack.c (+3 -3), c_misc.c (+1 -1), monster.c (+11 -11), plugins.c (+2 -2), server.c (+1 -1), shop.c (+4 -4), skill_util.c (+2 -2), skills.c (+1 -1)
server/trunk/socket: request.c (+1 -1), sounds.c (+1 -1)

toxicfrog 2020-09-13 16:41 Rev.: 21424

Refactor need_identify into is_identifiable_type and is_identified

This should result in no functional changes, but makes a lot of code
that queries ID status a bit easier to read. It also replaces the
hard-coded list of object types in need_identify with a more general
approach of checking whether the object type has an associated
identifyskill.

64 lines of code changed in 13 files:

server/trunk/common: artifact.c (+1 -1), item.c (+42 -50)
server/trunk/include: libproto.h (+2 -1)
server/trunk/server: alchemy.c (+1 -1), c_object.c (+7 -4), c_wiz.c (+1 -1), knowledge.c (+1 -1), player.c (+1 -1), shop.c (+2 -4), skills.c (+1 -4), spell_effect.c (+2 -4)
server/trunk/socket: item.c (+1 -1)
server/trunk/types/identify_altar: identify_altar.c (+2 -6)

toxicfrog 2020-09-11 20:02 Rev.: 21405

Fix test/unit/common to not require a crossfire install

Historically this has loaded confdir from $PREFIX, i.e. from your
installed copy of crossfire. This meant that if you didn't have
crossfire installed, you couldn't run the tests, and if you did, it
would use the confdata from the install rather than from the build tree.

With this change it automatically sets confdir based on datadir,
allowing all tests in test/unit/common/ to function without needing a
`make install` first. This problem still affects test/unit/server/ and
test/unit/bugfix, and will require more work to fix there.

3 lines of code changed in 3 files:

server/trunk/test/include: toolkit_common.h (-1)
server/trunk/test/toolkit: toolkit_common.c (+3 -4)
server/trunk/test/unit/common: check_living.c (-1)