/server/trunk Developers: partmedia

Login name:
partmedia
Total Commits:
1,513 (9.0%)
Lines of Code:
18,962 (4.7%)
Most Recent Commit:
2020-08-29 02:33

Activity by Clock Time

Activity by Hour of Day for partmedia

Activity by Day of Week for partmedia

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 1513 (100.0%) 18962 (100.0%) 12.5
server/ 408 (27.0%) 3243 (17.1%) 7.9
doc/ 46 (3.0%) 3222 (17.0%) 70.0
doc/Developers/ 10 (0.7%) 2833 (14.9%) 283.3
random_maps/ 82 (5.4%) 1972 (10.4%) 24.0
common/ 247 (16.3%) 1593 (8.4%) 6.4
include/ 183 (12.1%) 1084 (5.7%) 5.9
lib/config/ 24 (1.6%) 1054 (5.6%) 43.9
/ 90 (5.9%) 815 (4.3%) 9.0
socket/ 96 (6.3%) 780 (4.1%) 8.1
lib/ 48 (3.2%) 745 (3.9%) 15.5
utils/ 37 (2.4%) 365 (1.9%) 9.8
include/random_maps/ 5 (0.3%) 274 (1.4%) 54.8
devel/ 8 (0.5%) 200 (1.1%) 25.0
types/food/ 8 (0.5%) 131 (0.7%) 16.3
utils/cre/ 44 (2.9%) 50 (0.3%) 1.1
plugins/cfpython/ 16 (1.1%) 45 (0.2%) 2.8
plugins/citylife/ 7 (0.5%) 42 (0.2%) 6.0
plugins/cfanim/ 13 (0.9%) 42 (0.2%) 3.2
types/savebed/ 3 (0.2%) 34 (0.2%) 11.3
types/transport/ 5 (0.3%) 33 (0.2%) 6.6
test/unit/server/ 8 (0.5%) 26 (0.1%) 3.2
types/shop_inventory/ 2 (0.1%) 24 (0.1%) 12.0
types/potion/ 3 (0.2%) 24 (0.1%) 8.0
types/converter/ 4 (0.3%) 24 (0.1%) 6.0
types/weapon_improver/ 2 (0.1%) 23 (0.1%) 11.5
types/lighter/ 3 (0.2%) 23 (0.1%) 7.6
types/gate/ 2 (0.1%) 23 (0.1%) 11.5
types/common/ 2 (0.1%) 23 (0.1%) 11.5
types/player_changer/ 2 (0.1%) 21 (0.1%) 10.5
types/exit/ 1 (0.1%) 21 (0.1%) 21.0
types/spell_effect/ 3 (0.2%) 20 (0.1%) 6.6
types/duplicator/ 2 (0.1%) 20 (0.1%) 10.0
types/detector/ 1 (0.1%) 19 (0.1%) 19.0
lib/wizhelp/ 7 (0.5%) 17 (0.1%) 2.4
plugins/common/ 4 (0.3%) 14 (0.1%) 3.5
test/unit/common/ 7 (0.5%) 13 (0.1%) 1.8
plugins/common/include/ 5 (0.3%) 11 (0.1%) 2.2
include/shared/ 3 (0.2%) 10 (0.1%) 3.3
types/shop_mat/ 3 (0.2%) 9 (0.0%) 3.0
macros/ 8 (0.5%) 6 (0.0%) 0.7
test/unit/random_maps/ 3 (0.2%) 4 (0.0%) 1.3
test/bugs/bugtrack/ 4 (0.3%) 4 (0.0%) 1.0
test/toolkit/ 3 (0.2%) 3 (0.0%) 1.0
test/ 1 (0.1%) 3 (0.0%) 3.0
lib/help/ 1 (0.1%) 3 (0.0%) 3.0
doc/playbook/ 2 (0.1%) 3 (0.0%) 1.5
types/ 2 (0.1%) 2 (0.0%) 1.0
test/unit/socket/ 2 (0.1%) 2 (0.0%) 1.0
make_win32/ 1 (0.1%) 2 (0.0%) 2.0
doc/playbook-html/ 2 (0.1%) 2 (0.0%) 1.0
types/trapdoor/ 1 (0.1%) 1 (0.0%) 1.0
types/button/ 1 (0.1%) 1 (0.0%) 1.0
test/unit/ 1 (0.1%) 1 (0.0%) 1.0
test/bugs/ 1 (0.1%) 1 (0.0%) 1.0
lib/i18n/ 1 (0.1%) 1 (0.0%) 1.0
lib/adm/ 8 (0.5%) 1 (0.0%) 0.1
plugins/template/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/template/ 3 (0.2%) 0 (0.0%) 0.0
plugins/citylife/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/cfrhg/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/cfrhg/ 3 (0.2%) 0 (0.0%) 0.0
plugins/cfpython/include/ 2 (0.1%) 0 (0.0%) 0.0
plugins/cfnewspaper/include/ 2 (0.1%) 0 (0.0%) 0.0
plugins/cfnewspaper/ 3 (0.2%) 0 (0.0%) 0.0
plugins/cflogger/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/cflogger/ 3 (0.2%) 0 (0.0%) 0.0
plugins/cfanim/include/ 2 (0.1%) 0 (0.0%) 0.0
plugins/ 1 (0.1%) 0 (0.0%) 0.0
doc/spoiler/ 1 (0.1%) 0 (0.0%) 0.0
doc/spoiler-html/ 1 (0.1%) 0 (0.0%) 0.0
doc/spell-docs/ 1 (0.1%) 0 (0.0%) 0.0
doc/scripts/ 1 (0.1%) 0 (0.0%) 0.0

Activity of partmedia

Most Recent Commits

partmedia 2020-08-29 02:33 Rev.: 21320

Fix out-of-bounds reads from using out_of_map()

Several callers use out_of_map() to check whether a given x, y
coordinate is in a map. However, out_of_map() returns false if the
coordinate exists in a tiled map outside the given map.

Macros such as GET_MAP_OB (and FOR_MAP_PREPARE, which uses GET_MAP_OB)
access the map 'spaces' array directly, and so implicitly assume that
the x, y coordinate is in the real map. Using out_of_map() instead of
OUT_OF_REAL_MAP can therefore result in out-of-bounds accesses to the
'spaces' array.

This patch replaces a few obviously unsafe calls to out_of_map() with
OUT_OF_REAL_MAP. There are probably still a few unsafe calls lurking
around, and obviously the better solution would have been to update
these calls to use the multi-tile aware functions.

4 lines of code changed in 3 files:

  • common: object.c (+2 -3)
  • server: attack.c (+1 -1), skills.c (+1 -1)
partmedia 2020-08-26 11:56 Rev.: 21316

Add new NROF() macro to deal with nrof=0

Most of the code assumes that nrof=0 is the same as nrof=1. Document
this and add a macro to deal with this and use it whenever possible.

30 lines of code changed in 8 files:

  • common: button.c (+8 -8), item.c (+1 -1), object.c (+3 -3)
  • include: object.h (+10 -1)
  • server: alchemy.c (+4 -4), c_object.c (+1 -1), shop.c (+2 -2)
  • types/trapdoor: trapdoor.c (+1 -1)
partmedia 2020-08-26 11:56 Rev.: 21315

Send ticks only while playing

3 lines of code changed in 1 file:

  • socket: loop.c (+3 -3)
partmedia 2020-08-26 11:56 Rev.: 21314

Profile save_objects()

10 lines of code changed in 1 file:

  • common: map.c (+10 -4)
partmedia 2020-08-23 12:58 Rev.: 21304

Fix integer comparison with different signedness

2 lines of code changed in 2 files:

  • common: time.c (+1 -1)
  • include: sproto.h (+1 -1)
partmedia 2020-07-29 14:01 Rev.: 21246

Execute word of recall effect without magic denied check

Casting word of recall causes a delayed word of recall effect. The check
for denied magic is already performed when casting. However, this second
check break balms of return home, which, like other balms, should
function even in magic-denied areas.

Removing this second check does mean that a player could now cast word
of recall in a magic-allowed area, then run into a magic-denied area,
and still be teleported home. This is probably not a problem.

Tracker: bugs/873

2 lines of code changed in 1 file:

  • types/spell_effect: spell_effect.c (+2 -6)
partmedia 2020-04-22 21:04 Rev.: 21219

Set timeout to zero when trying to swap map with player

1 lines of code changed in 1 file:

  • server: swap.c (+1)
partmedia 2020-04-13 01:00 Rev.: 21205

Clear last_skill_ob before removing inventory

6 lines of code changed in 1 file:

  • server: login.c (+6)
partmedia 2020-04-13 01:00 Rev.: 21204

Prune removed objects from last_skill_ob

Skill objects can apparently be removed, but will remain on the
last_skill_ob list. This causes NULL dereferences when they are used.

26 lines of code changed in 2 files:

  • common: living.c (+8)
  • socket: request.c (+18 -9)
partmedia 2020-04-02 16:21 Rev.: 21203

Refactor with find_applied_skill_by_name()

While here, warn instead of crashing when last_skill_ob[i]->skill is
NULL. It is not yet clear why that happens.

32 lines of code changed in 4 files:

  • common: living.c (+24 -7)
  • include: sproto.h (+1)
  • server: attack.c (+1 -11), spell_util.c (+6 -8)
partmedia 2020-04-02 16:21 Rev.: 21202

Improve shutdown handling

- Shut down immediately on signal or 'shutdown now', instead of waiting
up to 51 ticks
- Warn players on login, and more often

49 lines of code changed in 3 files:

  • include: server.h (+1)
  • server: login.c (+2), server.c (+46 -29)
partmedia 2020-03-21 13:36 Rev.: 21189

Reduce indirection

Submitted by: Frank Wilde <F.Wilde@casino2000.lu>

4 lines of code changed in 1 file:

  • server: party.c (+4 -3)
partmedia 2020-03-21 13:36 Rev.: 21188

Refactor duplicate empty party removal code

Submitted by: Frank Wilde <F.Wilde@casino2000.lu>

19 lines of code changed in 1 file:

  • server: party.c (+19 -36)
partmedia 2020-03-21 13:35 Rev.: 21187

Move same-party rejoin check to party_join()

Submitted by: Frank Wilde <F.Wilde@casino2000.lu>

9 lines of code changed in 2 files:

  • server: c_party.c (-7), party.c (+9 -1)
partmedia 2020-03-20 19:28 Rev.: 21184

Improve 'maps' command output

24 lines of code changed in 1 file:

  • server: c_misc.c (+24 -20)
partmedia 2020-03-20 19:28 Rev.: 21183

Add more sound events

6 lines of code changed in 3 files:

  • types/button: button.c (+1)
  • types/food: food.c (+3)
  • types/gate: gate.c (+2)
partmedia 2020-03-20 19:28 Rev.: 21182

Ignore sound_chance

1 lines of code changed in 2 files:

  • include: object.h (+1 -1)
  • socket: sounds.c (-6)
partmedia 2020-03-20 19:28 Rev.: 21181

Play sound for all kills

1 lines of code changed in 1 file:

  • server: attack.c (+1 -3)
partmedia 2020-03-20 19:28 Rev.: 21180

Make else exclusive

1 lines of code changed in 1 file:

  • common: loader.l (+1 -2)
partmedia 2020-03-20 19:28 Rev.: 21179

Generate batch scanner for more performance

1 lines of code changed in 1 file:

  • common: Makefile.am (+1 -1)

(426 more)

Generated by StatSVN 0.7.0