/server/trunk Developers: partmedia

Login name:
partmedia
Total Commits:
1,533 (8.8%)
Lines of Code:
19,177 (4.7%)
Most Recent Commit:
2020-12-28 00:35

Activity by Clock Time

Activity by Hour of Day for partmedia

Activity by Day of Week for partmedia

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 1533 (100.0%) 19177 (100.0%) 12.5
server/ 414 (27.0%) 3363 (17.5%) 8.1
doc/ 46 (3.0%) 3222 (16.8%) 70.0
doc/Developers/ 10 (0.7%) 2833 (14.8%) 283.3
random_maps/ 82 (5.3%) 1972 (10.3%) 24.0
common/ 253 (16.5%) 1626 (8.5%) 6.4
include/ 186 (12.1%) 1088 (5.7%) 5.8
lib/config/ 24 (1.6%) 1054 (5.5%) 43.9
/ 91 (5.9%) 816 (4.3%) 8.9
socket/ 96 (6.3%) 780 (4.1%) 8.1
lib/ 48 (3.1%) 745 (3.9%) 15.5
utils/ 39 (2.5%) 414 (2.2%) 10.6
include/random_maps/ 5 (0.3%) 274 (1.4%) 54.8
devel/ 8 (0.5%) 200 (1.0%) 25.0
types/food/ 8 (0.5%) 131 (0.7%) 16.3
plugins/cfpython/ 17 (1.1%) 52 (0.3%) 3.0
utils/cre/ 44 (2.9%) 50 (0.3%) 1.1
plugins/citylife/ 7 (0.5%) 42 (0.2%) 6.0
plugins/cfanim/ 13 (0.8%) 42 (0.2%) 3.2
types/savebed/ 3 (0.2%) 34 (0.2%) 11.3
types/transport/ 5 (0.3%) 33 (0.2%) 6.6
test/unit/server/ 8 (0.5%) 26 (0.1%) 3.2
types/shop_inventory/ 2 (0.1%) 24 (0.1%) 12.0
types/potion/ 3 (0.2%) 24 (0.1%) 8.0
types/converter/ 4 (0.3%) 24 (0.1%) 6.0
types/weapon_improver/ 2 (0.1%) 23 (0.1%) 11.5
types/lighter/ 3 (0.2%) 23 (0.1%) 7.6
types/gate/ 2 (0.1%) 23 (0.1%) 11.5
types/common/ 2 (0.1%) 23 (0.1%) 11.5
types/player_changer/ 2 (0.1%) 21 (0.1%) 10.5
types/exit/ 1 (0.1%) 21 (0.1%) 21.0
types/spell_effect/ 3 (0.2%) 20 (0.1%) 6.6
types/duplicator/ 2 (0.1%) 20 (0.1%) 10.0
types/detector/ 1 (0.1%) 19 (0.1%) 19.0
lib/wizhelp/ 8 (0.5%) 18 (0.1%) 2.2
plugins/common/ 4 (0.3%) 14 (0.1%) 3.5
test/unit/common/ 7 (0.5%) 13 (0.1%) 1.8
plugins/common/include/ 5 (0.3%) 11 (0.1%) 2.2
include/shared/ 3 (0.2%) 10 (0.1%) 3.3
types/shop_mat/ 3 (0.2%) 9 (0.0%) 3.0
macros/ 8 (0.5%) 6 (0.0%) 0.7
test/unit/random_maps/ 3 (0.2%) 4 (0.0%) 1.3
test/bugs/bugtrack/ 4 (0.3%) 4 (0.0%) 1.0
test/toolkit/ 3 (0.2%) 3 (0.0%) 1.0
test/ 1 (0.1%) 3 (0.0%) 3.0
lib/help/ 1 (0.1%) 3 (0.0%) 3.0
doc/playbook/ 2 (0.1%) 3 (0.0%) 1.5
types/ 2 (0.1%) 2 (0.0%) 1.0
test/unit/socket/ 2 (0.1%) 2 (0.0%) 1.0
make_win32/ 1 (0.1%) 2 (0.0%) 2.0
doc/playbook-html/ 2 (0.1%) 2 (0.0%) 1.0
types/trapdoor/ 1 (0.1%) 1 (0.0%) 1.0
types/button/ 1 (0.1%) 1 (0.0%) 1.0
test/unit/ 1 (0.1%) 1 (0.0%) 1.0
test/bugs/ 1 (0.1%) 1 (0.0%) 1.0
lib/i18n/ 1 (0.1%) 1 (0.0%) 1.0
lib/adm/ 8 (0.5%) 1 (0.0%) 0.1
plugins/template/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/template/ 3 (0.2%) 0 (0.0%) 0.0
plugins/citylife/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/cfrhg/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/cfrhg/ 3 (0.2%) 0 (0.0%) 0.0
plugins/cfpython/include/ 2 (0.1%) 0 (0.0%) 0.0
plugins/cfnewspaper/include/ 2 (0.1%) 0 (0.0%) 0.0
plugins/cfnewspaper/ 3 (0.2%) 0 (0.0%) 0.0
plugins/cflogger/include/ 1 (0.1%) 0 (0.0%) 0.0
plugins/cflogger/ 3 (0.2%) 0 (0.0%) 0.0
plugins/cfanim/include/ 2 (0.1%) 0 (0.0%) 0.0
plugins/ 1 (0.1%) 0 (0.0%) 0.0
doc/spoiler/ 1 (0.1%) 0 (0.0%) 0.0
doc/spoiler-html/ 1 (0.1%) 0 (0.0%) 0.0
doc/spell-docs/ 1 (0.1%) 0 (0.0%) 0.0
doc/scripts/ 1 (0.1%) 0 (0.0%) 0.0

Activity of partmedia

Most Recent Commits

partmedia 2020-12-28 00:35 Rev.: 21654

Fix possible NULL dereference

1 lines of code changed in 1 file:

  • server: knowledge.c (+1 -1)
partmedia 2020-12-28 00:35 Rev.: 21653

Add noreturn attribute to fatal()

This teaches static analyzers to ignore NULL dereference false positives
after fatal().

1 lines of code changed in 1 file:

  • include: libproto.h (+1 -1)
partmedia 2020-12-27 18:38 Rev.: 21652

Fix same-map check

Checking for the argument to be '.' does not prevent the DM from
resetting from the same map when the full path is given.

1 lines of code changed in 1 file:

  • server: c_wiz.c (+1 -1)
partmedia 2020-12-27 12:22 Rev.: 21651

Fix resetting unique maps

4 lines of code changed in 1 file:

  • common: map.c (+4 -2)
partmedia 2020-12-25 11:12 Rev.: 21644

Simplify party linked list removal code

Submitted by: Jareth (in game)

15 lines of code changed in 1 file:

  • server: party.c (+15 -37)
partmedia 2020-12-24 13:44 Rev.: 21634

Factor out bits_set()

14 lines of code changed in 1 file:

  • common: item.c (+14 -11)
partmedia 2020-12-23 00:18 Rev.: 21633

Remove unnecessary file existence checks

When loading a map with tiled maps, the server checks that all tiled
maps have valid paths. First, it checks the 'bare' path assuming that
the path is absolute, and then it calls path_combine_and_normalize() and
checks again if it doesn't exist. This means that loading a world map
(with 4 tiled maps) results in 8 access() system calls.

This is a bit unnecessary because path_combine_and_normalize() already
knows how to normalize paths. To add insult, the original code calls
path_combine_and_normalize() both when the map path is checked, and when
the map is actually loaded. Further, the existence of the path does not
imply that the map is loadable; and this code insists on checking the
path, even if the tiled map is already loaded into memory.

Stop doing these ridiculous things.

4 lines of code changed in 1 file:

  • common: map.c (+4 -21)
partmedia 2020-12-19 00:28 Rev.: 21626

Add cfdb_convert

This Python 3 utility converts Python 2 bsddb 'shelve' databases to the
default Python 3 'shelve' format.

Server operators running existing servers should convert existing
databases after switching to Python 3. Running cfdb_convert with the
'--auto' flag in the 'var/crossfire' directory will automatically
convert a list of standard databases with known names.

49 lines of code changed in 2 files:

  • utils: Makefile.am (+1 -1), cfdb_convert (new 48)
partmedia 2020-12-19 00:28 Rev.: 21625

Switch build to Python 3

1 lines of code changed in 1 file:

  • configure.ac (+1 -1)
partmedia 2020-12-18 23:29 Rev.: 21624

Do not print difficulty after 'goto' command

0 lines of code changed in 1 file:

  • server: c_wiz.c (-3)
partmedia 2020-11-22 18:37 Rev.: 21560

Document object_set_msg() for settting msg

2 lines of code changed in 1 file:

  • include: object.h (+2 -1)
partmedia 2020-11-18 02:04 Rev.: 21546

cfpython: Ignore EVENT_CLOCK

EVENT_CLOCK is not being used in maps, but nevertheless runs
python_init.py several times per second even while idling.

This patch makes cfpython ignore EVENT_CLOCK. We should stop ignoring it
if we ever decide to use Python clock events again.

7 lines of code changed in 1 file:

  • plugins/cfpython: cfpython.c (+7)
partmedia 2020-11-18 02:04 Rev.: 21545

Fix argument type

2 lines of code changed in 2 files:

  • common: map.c (+1 -1)
  • include: libproto.h (+1 -1)
partmedia 2020-10-19 11:21 Rev.: 21513

Avoid forcing line breaks

4 lines of code changed in 1 file:

  • server: spell_effect.c (+4 -5)
partmedia 2020-10-19 11:20 Rev.: 21512

Refactor town portal spell effects

99 lines of code changed in 1 file:

  • server: spell_effect.c (+99 -80)
partmedia 2020-09-06 16:36 Rev.: 21353

Correct 'seconds' to 'minutes'

1 lines of code changed in 1 file:

  • lib/wizhelp: shutdown.en (+1 -1)
partmedia 2020-09-04 01:30 Rev.: 21344

Fix short-circuit in object_can_merge()

object_can_merge() can only return 0 if compare_ob_value_lists()
returns 0. Otherwise, it must continue checking.

3 lines of code changed in 1 file:

  • common: object.c (+3 -1)
partmedia 2020-09-03 00:17 Rev.: 21333

Improve code readability

7 lines of code changed in 1 file:

  • common: map.c (+7 -8)
partmedia 2020-08-29 01:33 Rev.: 21320

Fix out-of-bounds reads from using out_of_map()

Several callers use out_of_map() to check whether a given x, y
coordinate is in a map. However, out_of_map() returns false if the
coordinate exists in a tiled map outside the given map.

Macros such as GET_MAP_OB (and FOR_MAP_PREPARE, which uses GET_MAP_OB)
access the map 'spaces' array directly, and so implicitly assume that
the x, y coordinate is in the real map. Using out_of_map() instead of
OUT_OF_REAL_MAP can therefore result in out-of-bounds accesses to the
'spaces' array.

This patch replaces a few obviously unsafe calls to out_of_map() with
OUT_OF_REAL_MAP. There are probably still a few unsafe calls lurking
around, and obviously the better solution would have been to update
these calls to use the multi-tile aware functions.

4 lines of code changed in 3 files:

  • common: object.c (+2 -3)
  • server: attack.c (+1 -1), skills.c (+1 -1)
partmedia 2020-08-26 10:56 Rev.: 21316

Add new NROF() macro to deal with nrof=0

Most of the code assumes that nrof=0 is the same as nrof=1. Document
this and add a macro to deal with this and use it whenever possible.

30 lines of code changed in 8 files:

  • common: button.c (+8 -8), item.c (+1 -1), object.c (+3 -3)
  • include: object.h (+10 -1)
  • server: alchemy.c (+4 -4), c_object.c (+1 -1), shop.c (+2 -2)
  • types/trapdoor: trapdoor.c (+1 -1)

(444 more)

Generated by StatSVN 0.7.0