November 2008 Commit Log

Number of Commits:

104

Number of Active Developers:

5

mwedel 2008-11-26 01:02 #104 Rev.: 10733

server/login.c: Clear shootype value when player leaves game - otherwise
it will point to bad value in ranges[] array.
MSW 2008-11-25

11 lines of code changed in 2 files:

• ChangeLog (+4)
• server: login.c (+7 -1)

lalo 2008-11-25 16:57 #103 Rev.: 10717

allowing check_inv to check an item by title; also, changing the behaviour to AND rather than OR, so you can check for something of a given type with a given key, for example.

11 lines of code changed in 1 file:

• common: button.c (+11 -6)

lalo 2008-11-24 02:28 #102 Rev.: 10699

re-enabling cfpython to change a player's title

59 lines of code changed in 6 files:

• include: plugin.h (+1)
• plugins/cfpython: cfpython_object.c (+27)
• plugins/cfpython/include: cfpython_object_private.h (+3)
• plugins/common: plugin_common.c (+13)
• plugins/common/include: plugin_common.h (+2)
• server: plugins.c (+13)

akirschbaum 2008-11-23 12:43 #101 Rev.: 10690

Prepend an underscore to names generated for implicitly defined animations.

9 lines of code changed in 2 files:

• ChangeLog (+4)
• lib: collect.pl.in (+5 -5)

akirschbaum 2008-11-21 18:20 #100 Rev.: 10657

Accelerate Send_With_Handling().

23 lines of code changed in 5 files:

• include: sockproto.h (+2 -1)
• server: player.c (+1 -1)
• socket: init.c (+1), loop.c (+3 -2), lowlevel.c (+16 -17)

akirschbaum 2008-11-21 17:16 #99 Rev.: 10656

Remove unused function Write_String_To_Socket().

0 lines of code changed in 2 files:

• include: sockproto.h (-1)
• socket: lowlevel.c (-14)

akirschbaum 2008-11-21 17:12 #98 Rev.: 10655

Remove calls to Write_String_To_Socket().

45 lines of code changed in 1 file:

• socket: request.c (+45 -23)

akirschbaum 2008-11-21 17:02 #97 Rev.: 10654

Remove call to Write_String_To_Socket().

38 lines of code changed in 1 file:

• socket: request.c (+38 -70)

akirschbaum 2008-11-21 16:32 #96

Remove call to Write_String_To_Socket().

10 lines of code changed in 2 files:

• socket: init.c (+6 -1), item.c (+4 -1)

akirschbaum 2008-11-21 16:30 #95 Rev.: 10651

Remove calls to Write_String_To_Socket().

14 lines of code changed in 1 file:

• socket: image.c (+14 -10)

akirschbaum 2008-11-21 16:24 #94 Rev.: 10650

Remove call to Write_String_To_Socket().

6 lines of code changed in 1 file:

• socket: info.c (+6 -4)

akirschbaum 2008-11-21 16:18 #93

Remove call to Write_String_To_Socket().

11 lines of code changed in 2 files:

• socket: info.c (+5 -4), loop.c (+6 -6)

akirschbaum 2008-11-21 16:11 #92 Rev.: 10647

Merge redundant functions cs_write_string() and Write_String_To_Socket().

4 lines of code changed in 5 files:

• include: sockproto.h (-1)
• socket: image.c (+2 -2), init.c (+1 -1), lowlevel.c (-19), request.c (+1 -1)

akirschbaum 2008-11-21 16:04 #91 Rev.: 10646

Add SockList_AddLen8Data(). Use it where appropriate.

24 lines of code changed in 6 files:

• include: sockproto.h (+1)
• socket: image.c (+1 -5), item.c (+4 -23), lowlevel.c (+13), request.c (+3 -13), sounds.c (+2 -4)

akirschbaum 2008-11-21 14:48 #90 Rev.: 10644

Do not send excess data for magicmap responses.

1 lines of code changed in 1 file:

• socket: info.c (+1 -1)

akirschbaum 2008-11-21 14:17 #89 Rev.: 10643

Replace conditional expressions with MIN()/MAX().

36 lines of code changed in 10 files:

• common: exp.c (+3 -3), time.c (+4 -4)
• server: login.c (+1 -1), monster.c (+3 -3), player.c (+16 -16), shop.c (+1 -1), skill_util.c (+1 -1), skills.c (+2 -2), spell_util.c (+1 -1)
• socket: info.c (+4 -4)

akirschbaum 2008-11-21 13:31 #88 Rev.: 10642

Replace calloc()/free() with local variable.

2 lines of code changed in 1 file:

• socket: info.c (+2 -2)

akirschbaum 2008-11-21 13:15 #87 Rev.: 10641

Accelerate 'replyinfo race_list' and 'replyinfo class_list' processing.

23 lines of code changed in 1 file:

• socket: request.c (+23 -35)

akirschbaum 2008-11-21 12:57 #86 Rev.: 10640

Rewrite SockList handling to not malloc/free buffers but use stack space instead. Encapsulate most accesses to SockList instances into lowlevel.c.

308 lines of code changed in 14 files:

• ChangeLog (+5)
• common: stringbuffer.c (-5)
• include: newclient.h (+3 -28), sockproto.h (+7), stringbuffer.h (-11)
• server: player.c (+1 -1)
• socket: image.c (+16 -28), info.c (+4 -6), init.c (+6 -9), item.c (+28 -44), loop.c (+4 -4), lowlevel.c (+153 -33), request.c (+74 -93), sounds.c (+7 -13)

akirschbaum 2008-11-20 17:24 #85 Rev.: 10626

Do not call tailor_readable_ob() with invalid msgtype parameter.

3 lines of code changed in 2 files:

• ChangeLog (+2)
• common: treasure.c (+1 -2)

akirschbaum 2008-11-20 16:32 #84 Rev.: 10624

Remove unneeded parentheses.

4 lines of code changed in 1 file:

• common: readable.c (+4 -4)

akirschbaum 2008-11-20 16:29 #83 Rev.: 10623

Whitespace changes.

1 lines of code changed in 1 file:

• common: readable.c (+1 -1)

akirschbaum 2008-11-20 16:29 #82 Rev.: 10622

Detect and report errors when saving bookarch file.

26 lines of code changed in 2 files:

• ChangeLog (+1)
• common: readable.c (+25 -19)

akirschbaum 2008-11-20 16:18 #81 Rev.: 10621

Prevent possible buffer overflow.

1 lines of code changed in 1 file:

• common: readable.c (+1 -1)

akirschbaum 2008-11-20 16:16 #80 Rev.: 10620

Make functions static.

7 lines of code changed in 2 files:

• common: readable.c (+7 -7)
• include: libproto.h (-7)

akirschbaum 2008-11-20 16:08 #79 Rev.: 10619

Do not crash for undefined archetype name.

8 lines of code changed in 1 file:

• common: readable.c (+8 -5)

akirschbaum 2008-11-20 16:04 #78

Whitespace changes.

9 lines of code changed in 2 files:

• common: readable.c (+1 -1)

akirschbaum 2008-11-20 16:04 #77 Rev.: 10616

Convert if statement into guard.

68 lines of code changed in 1 file:

• common: readable.c (+68 -68)

akirschbaum 2008-11-20 15:48 #76 Rev.: 10615

Remove unused code.

2 lines of code changed in 2 files:

• common: readable.c (+2 -5)
• include: spells.h (-1)

akirschbaum 2008-11-20 15:38 #75 Rev.: 10614

Remove trailing whitespace from generated book contents.

6 lines of code changed in 2 files:

• ChangeLog (+2)
• common: readable.c (+4 -4)

akirschbaum 2008-11-20 15:31 #74 Rev.: 10613

Remove redundant assignments.

4 lines of code changed in 1 file:

• common: readable.c (+4 -4)

akirschbaum 2008-11-20 15:28 #73 Rev.: 10612

Make parameter const.

2 lines of code changed in 2 files:

• common: readable.c (+1 -1)
• include: libproto.h (+1 -1)

akirschbaum 2008-11-20 15:18 #72 Rev.: 10611

Simplify get_random_mon().

7 lines of code changed in 1 file:

• common: readable.c (+7 -10)

akirschbaum 2008-11-20 15:04 #71 Rev.: 10610

Remove redundant field initialization.

1 lines of code changed in 1 file:

• common: readable.c (+1 -3)

akirschbaum 2008-11-20 15:02 #70 Rev.: 10609

Remove redundant condition.

1 lines of code changed in 1 file:

• common: readable.c (+1 -1)

akirschbaum 2008-11-20 15:01 #69 Rev.: 10608

Add const modifier to variables.

2 lines of code changed in 1 file:

• common: readable.c (+2 -2)

akirschbaum 2008-11-20 14:57 #68 Rev.: 10607

Remove unneeded else clauses.

3 lines of code changed in 1 file:

• common: readable.c (+3 -3)

akirschbaum 2008-11-20 14:53 #67 Rev.: 10606

Remove redundant if statement.

5 lines of code changed in 1 file:

• common: readable.c (+5 -7)

akirschbaum 2008-11-20 14:50 #66 Rev.: 10605

Replace degenerated switch statement with if statement.

92 lines of code changed in 1 file:

• common: readable.c (+92 -92)

akirschbaum 2008-11-20 14:39 #65 Rev.: 10604

Remove redundant if statement.

1 lines of code changed in 1 file:

• common: readable.c (+1 -1)

akirschbaum 2008-11-20 14:38 #64 Rev.: 10603

Accelerate new_text_name().

8 lines of code changed in 1 file:

• common: readable.c (+8 -8)

akirschbaum 2008-11-20 14:36 #63 Rev.: 10602

Remove temporary variables.

8 lines of code changed in 1 file:

• common: readable.c (+8 -18)

akirschbaum 2008-11-20 14:34 #62 Rev.: 10601

Move #define to top of file.

3 lines of code changed in 1 file:

• common: readable.c (+3 -3)

akirschbaum 2008-11-20 14:30 #61 Rev.: 10600

Accelerate add_author().

8 lines of code changed in 1 file:

• common: readable.c (+8 -13)

akirschbaum 2008-11-20 14:26 #60 Rev.: 10599

Replace integer constants with named constants.

36 lines of code changed in 1 file:

• common: readable.c (+36 -28)

akirschbaum 2008-11-20 14:12 #59 Rev.: 10598

Do not call get_titlelist() for invalid indices.

16 lines of code changed in 2 files:

• ChangeLog (+1)
• common: readable.c (+15 -10)

akirschbaum 2008-11-20 02:52 #58 Rev.: 10596

Report accesses to invalid book indices.

8 lines of code changed in 1 file:

• common: readable.c (+8 -3)

akirschbaum 2008-11-20 02:41 #57 Rev.: 10595

Detect and report syntax errors in 'bookarch' file.

85 lines of code changed in 2 files:

• ChangeLog (+1 -1)
• common: readable.c (+84 -24)

akirschbaum 2008-11-20 02:00 #56 Rev.: 10594

Fix typos.

2 lines of code changed in 1 file:

• ChangeLog (+2 -2)

akirschbaum 2008-11-20 01:59 #55 Rev.: 10593

Fix 'bookarch' parser to strip trailing spaces but not leading spaces.

17 lines of code changed in 2 files:

• ChangeLog (+2 -1)
• common: readable.c (+15 -14)

akirschbaum 2008-11-20 01:55 #54 Rev.: 10592

Add explicit initialization to static variables.

3 lines of code changed in 1 file:

• common: readable.c (+3 -3)

akirschbaum 2008-11-20 01:53 #53 Rev.: 10591

Fix possible memory leak when reading the 'bookarch' file.

6 lines of code changed in 2 files:

• ChangeLog (+4)
• common: readable.c (+2 -2)

akirschbaum 2008-11-19 17:22 #52 Rev.: 10576

Fix 'messages' file parser to strip leading spaces but not trailing spaces. Issue warning messages if messages are truncated. Detect and report syntax errors rather than crash.

33 lines of code changed in 2 files:

• ChangeLog (+3)
• common: readable.c (+30 -19)

akirschbaum 2008-11-19 16:41 #51 Rev.: 10575

Whitespace changes.

5 lines of code changed in 1 file:

• common: readable.c (+5 -5)

akirschbaum 2008-11-19 16:39 #50 Rev.: 10574

Remove assignments within expressions.

16 lines of code changed in 1 file:

• common: readable.c (+16 -8)

akirschbaum 2008-11-19 16:34 #49 Rev.: 10573

Remove unneeded parentheses.

4 lines of code changed in 1 file:

• common: readable.c (+4 -4)

akirschbaum 2008-11-19 16:33 #48 Rev.: 10572

Fix incorrect random expression -- condition was always false.

3 lines of code changed in 2 files:

• ChangeLog (+2)
• common: readable.c (+1 -1)

akirschbaum 2008-11-19 16:29 #47 Rev.: 10571

Remove unneeded parentheses; whitespace changes.

9 lines of code changed in 1 file:

• common: readable.c (+9 -9)

akirschbaum 2008-11-19 16:20 #46 Rev.: 10570

Whitespace changes.

124 lines of code changed in 1 file:

• common: readable.c (+124 -125)

akirschbaum 2008-11-19 16:01 #45 Rev.: 10569

Fix possible buffer overflow.

1 lines of code changed in 1 file:

• common: readable.c (+1 -1)

akirschbaum 2008-11-19 15:57 #44 Rev.: 10568

Remove parameter restriction and accelerate strtoktolin().

2 lines of code changed in 1 file:

• common: readable.c (+2 -3)

akirschbaum 2008-11-19 15:54 #43 Rev.: 10567

Remove parameter restriction and accelerate nstrtok().

3 lines of code changed in 1 file:

• common: readable.c (+3 -4)

akirschbaum 2008-11-19 15:51 #42 Rev.: 10566

Simplify if statements.

5 lines of code changed in 1 file:

• common: readable.c (+5 -7)

akirschbaum 2008-11-19 15:49 #41 Rev.: 10565

Replace while loops with for loops.

13 lines of code changed in 1 file:

• common: readable.c (+13 -28)

akirschbaum 2008-11-19 15:40 #40 Rev.: 10564

Add arraysize() macro to make expressions more simple.

33 lines of code changed in 1 file:

• common: readable.c (+33 -25)

akirschbaum 2008-11-19 15:32 #39 Rev.: 10563

Make readable_message_type a compile-time constant.

5 lines of code changed in 4 files:

• common: readable.c (+2 -2)
• include: libproto.h (+1 -1)
• types/book: book.c (+1 -1)
• types/sign: sign.c (+1 -1)

akirschbaum 2008-11-19 15:27 #38 Rev.: 10562

Remove redundant 'const' modifier.

1 lines of code changed in 1 file:

• common: readable.c (+1 -1)

akirschbaum 2008-11-19 15:21 #37 Rev.: 10561

Remove unused variables.

2 lines of code changed in 2 files:

• plugins/cfrhg: cfrhg.c (+1 -2)
• server: player.c (+1 -1)

akirschbaum 2008-11-19 15:21 #36 Rev.: 10560

Add missing return values.

2 lines of code changed in 1 file:

• types/player_changer: player_changer.c (+2 -2)

akirschbaum 2008-11-19 12:23 #35 Rev.: 10559

Accelerate "replyinfo image_sums" processing; Fix documentation for "replyinfo image_sums" format.

10 lines of code changed in 3 files:

• ChangeLog (+5)
• doc/Developers: protocol (+3 -2)
• socket: image.c (+2 -3)

akirschbaum 2008-11-19 12:14 #34 Rev.: 10558

Do not reuse variable; use sensible variable names.

9 lines of code changed in 1 file:

• socket: image.c (+9 -7)

akirschbaum 2008-11-19 12:09 #33 Rev.: 10557

Move variable declaration before functions.

2 lines of code changed in 1 file:

• common: image.c (+2 -2)

akirschbaum 2008-11-18 17:53 #32 Rev.: 10543

Improve error message.

1 lines of code changed in 1 file:

• common: porting.c (+1 -1)

akirschbaum 2008-11-18 17:08 #31 Rev.: 10542

Remove unused variable initialization.

1 lines of code changed in 1 file:

• socket: loop.c (+1 -1)

akirschbaum 2008-11-18 16:59 #30 Rev.: 10541

Properly check "setup want_pickup" settings.

12 lines of code changed in 1 file:

• socket: request.c (+12 -2)

akirschbaum 2008-11-18 16:45 #29 Rev.: 10540

Send correct response for "setup inscribe" settings.

1 lines of code changed in 1 file:

• socket: request.c (+1 -1)

akirschbaum 2008-11-18 16:41 #28 Rev.: 10539

Properly check "setup bot" settings.

12 lines of code changed in 1 file:

• socket: request.c (+12 -2)

akirschbaum 2008-11-18 16:38 #27 Rev.: 10538

Whitespace changes.

10 lines of code changed in 1 file:

• socket: request.c (+10 -10)

akirschbaum 2008-11-18 16:37 #26 Rev.: 10537

Properly check "setup tick" settings.

12 lines of code changed in 1 file:

• socket: request.c (+12 -2)

akirschbaum 2008-11-18 16:30 #25 Rev.: 10535

Properly check "setup extendedTextInfos" settings.

11 lines of code changed in 1 file:

• socket: request.c (+11 -8)

akirschbaum 2008-11-18 16:26 #24 Rev.: 10534

Whitespace changes.

10 lines of code changed in 1 file:

• socket: request.c (+10 -10)

akirschbaum 2008-11-18 16:25 #23 Rev.: 10533

Properly check "setup mapsize" settings; remove stray space character from error response.

8 lines of code changed in 1 file:

• socket: request.c (+8 -10)

akirschbaum 2008-11-18 16:08 #22 Rev.: 10532

Properly check "setup facecache" settings.

12 lines of code changed in 1 file:

• socket: request.c (+12 -2)

akirschbaum 2008-11-18 16:05 #21 Rev.: 10531

Properly check "setup newmapcmd" settings.

12 lines of code changed in 1 file:

• socket: request.c (+12 -2)

akirschbaum 2008-11-18 16:00 #20 Rev.: 10530

Properly check "setup map2cmd" settings.

11 lines of code changed in 2 files:

• doc/Developers: protocol (+2 -1)
• socket: request.c (+9 -2)

akirschbaum 2008-11-18 15:56 #19 Rev.: 10529

Properly check "setup darkness" settings.

14 lines of code changed in 2 files:

• ChangeLog (+1 -2)
• socket: request.c (+13 -3)

akirschbaum 2008-11-18 15:51 #18 Rev.: 10528

Properly check "setup spellmon" settings.

13 lines of code changed in 2 files:

• ChangeLog (+1)
• socket: request.c (+12 -2)

akirschbaum 2008-11-18 15:45 #17 Rev.: 10527

Properly check "setup sound" settings; document allowed values.

7 lines of code changed in 3 files:

• ChangeLog (+2)
• doc/Developers: protocol (+4 -1)
• socket: request.c (+1 -1)

akirschbaum 2008-11-18 15:35 #16 Rev.: 10526

Remove incorrect comment.

0 lines of code changed in 1 file:

• socket: request.c (-1)

akirschbaum 2008-11-18 15:34 #15 Rev.: 10525

Accelerate processing of setup protocol command.

1 lines of code changed in 1 file:

• socket: request.c (+1 -1)

akirschbaum 2008-11-18 15:23 #14 Rev.: 10523

Properly check input read from client socket.

6 lines of code changed in 2 files:

• ChangeLog (+3)
• socket: request.c (+3 -1)

ryo_saeba 2008-11-17 15:43 #13 Rev.: 10506

Apply patch #2305993: Random Item generation difficutly table expansion, courtesy meflin.

220 lines of code changed in 3 files:

• ChangeLog (+6)
• common: treasure.c (+213 -43)
• include: treasure.h (+1 -1)

ryo_saeba 2008-11-16 14:00 #12 Rev.: 10492

Allow transports to not occupy the same spaces depending on the facing direction.

171 lines of code changed in 4 files:

• ChangeLog (+6)
• common: map.c (+10 -1)
• doc/Developers: objects (+6)
• server: player.c (+149 -2)

rjtanner 2008-11-11 14:10 #11 Rev.: 10396

Reduce selling cost of Gourmet Mushrooms as they were easy to exploit and abuse for massive cash influx. Change requested on behalf of meflin.

6 lines of code changed in 2 files:

• ChangeLog (+5)
• lib: artifacts (+1 -1)

ryo_saeba 2008-11-11 06:20 #10 Rev.: 10393

Tentative fix for bug #1982043: Ruggilli immolation.

6 lines of code changed in 2 files:

• ChangeLog (+4)
• server: disease.c (+2 -1)

ryo_saeba 2008-11-11 06:01 #9 Rev.: 10392

Fix for bug #2259992: I dont know how to apply the ... * (unpaid).

10 lines of code changed in 3 files:

• ChangeLog (+5)
• include: ob_methods.h (+1)
• server: apply.c (+4 -2)

ryo_saeba 2008-11-10 16:42 #8 Rev.: 10381

Tentative fix for bug #2094038: Monk Confusion...

9 lines of code changed in 2 files:

• ChangeLog (+5)
• server: gods.c (+4 -4)

ryo_saeba 2008-11-10 06:39 #7 Rev.: 10380

Remove obsolete 'color_fg' handling.

4 lines of code changed in 2 files:

• ChangeLog (+4)
• common: image.c (-4)

ryo_saeba 2008-11-09 18:02 #6 Rev.: 10324

Merge smoothing information in New_Face, to simplify some.

36 lines of code changed in 3 files:

• ChangeLog (+5)
• common: image.c (+30 -52)
• include: face.h (+1)

ryo_saeba 2008-11-09 13:10 #5 Rev.: 10323

Apply patch #2040854: Patch to compile on OSX PPC, and to comply with ANSI C, by elliotbay.

8 lines of code changed in 3 files:

• ChangeLog (+6)
• plugins/cfpython: cfpython.c (+2)
• plugins/cfpython/include: cfpython.h (-1)

ryo_saeba 2008-11-09 12:19 #4 Rev.: 10320

Fix for bug #2249875: 2.0 random say crashes.

9 lines of code changed in 4 files:

• ChangeLog (+7)
• common: dialog.c (-8), object.c (+2 -1)
• include: libproto.h (-1)

ryo_saeba 2008-11-08 13:57 #3 Rev.: 10303

Crossfire Resource Editor (for now only displaying), initial import.

2225 lines of code changed in 49 files:

• ChangeLog (+7)
• utils/cre: .ignore (new 5), .qmake.cache (new 4), CREAnimationControl.cpp (new 87), CREAnimationControl.h (new 35), CREAnimationPanel.cpp (new 78), CREAnimationPanel.h (new 29), CREAnimationWidget.cpp (new 38), CREAnimationWidget.h (new 25), CREArchetypePanel.cpp (new 22), CREArchetypePanel.h (new 23), CREArtifactPanel.cpp (new 80), CREArtifactPanel.h (new 28), CREFacePanel.cpp (new 141), CREFacePanel.h (new 31), CREFormulaePanel.cpp (new 154), CREFormulaePanel.h (new 40), CREMainWindow.cpp (new 116), CREMainWindow.h (new 49), CREPixmap.cpp (new 67), CREPixmap.h (new 27), CREResourcesWindow.cpp (new 258), CREResourcesWindow.h (new 34), CRETreasurePanel.cpp (new 67), CRETreasurePanel.h (new 25), CRETreeItem.cpp (new 11), CRETreeItem.h (new 18), CRETreeItemAnimation.cpp (new 22), CRETreeItemAnimation.h (new 25), CRETreeItemArchetype.cpp (new 21), CRETreeItemArchetype.h (new 27), CRETreeItemArtifact.cpp (new 21), CRETreeItemArtifact.h (new 26), CRETreeItemFace.cpp (new 23), CRETreeItemFace.h (new 27), CRETreeItemFormulae.cpp (new 22), CRETreeItemFormulae.h (new 23), CRETreeItemTreasure.cpp (new 22), CRETreeItemTreasure.h (new 27), CREUtils.cpp (new 155), CREUtils.h (new 34), README (new 10), cre.cpp (new 185), cre.pro (new 48), cre.qrc (new 8)
• utils/cre/resources: treasure_list.png (new), treasure_no.png (new), treasure_yes.png (new), treasureone_list.png (new)

ryo_saeba 2008-11-08 13:35 #2 Rev.: 10302

Enable C++ programs to use CF's data.

28 lines of code changed in 7 files:

• ChangeLog (+9)
• common: anim.c (+2), map.c (+7 -7)
• include: map.h (+3 -3)
• random_maps: random_map.h (+1 -1)
• server: server.c (+5 -5), swap.c (+1 -1)

akirschbaum 2008-11-02 14:11 #1 Rev.: 10242

Remove reference to obsolete attribute name.

1 lines of code changed in 1 file:

• doc/Developers: objects (+1 -1)

October 2008 »