August 2016 Commit Log

Number of Commits:

20

Number of Active Developers:

1

partmedia 2016-08-12 23:43 #20 Rev.: 20315

Revert FABS macro change

Some bit of the server somewhere relies on the type-independent behavior
of the original FABS macro. This manifests itself in the form of
infinite recursion when attempting to log in.

3 lines of code changed in 2 files:

• include: compat.h (-3), define.h (+3)

partmedia 2016-08-12 23:02 #19 Rev.: 20314

Fix signed integer comparisons

16 lines of code changed in 9 files:

• common: readable.c (+4 -4), treasure.c (+1 -2), utils.c (+3 -3)
• include: object.h (+1 -1)
• server: attack.c (+2 -6), monster.c (+2 -2), server.c (+1 -1), swap.c (+1 -1)
• types/food: food.c (+1 -1)

partmedia 2016-08-12 23:02 #18 Rev.: 20313

Convert fatal error codes to enum

10 lines of code changed in 3 files:

• common: utils.c (+2 -8)
• include: define.h (+7 -8), libproto.h (+1 -1)

partmedia 2016-08-12 23:01 #17 Rev.: 20312

Remove remnants of crossfire-config

1 lines of code changed in 2 files:

• doc: Makefile.am (+1 -2), crossfire-config.man (del)

partmedia 2016-08-12 23:01 #16 Rev.: 20311

Move compatibility definitions to compat.h

Note that we never call FABS on a floating-point value, so defining it
as a call to abs() is okay.

Also remove an ancient compiler check.

11 lines of code changed in 2 files:

• include: compat.h (+11), define.h (-20)

partmedia 2016-08-12 23:01 #15 Rev.: 20310

Remove unused variable

0 lines of code changed in 1 file:

• common: item.c (-2)

partmedia 2016-08-12 23:01 #14 Rev.: 20309

Convert OBJECT_TYPE defgroup to enum

158 lines of code changed in 2 files:

• include: define.h (-162), object.h (+158)

partmedia 2016-08-12 23:01 #13 Rev.: 20308

Remove unused object types

0 lines of code changed in 1 file:

• include: define.h (-40)

partmedia 2016-08-12 23:01 #12 Rev.: 20307

Move shop_price_sell() call after argument check

sell_item() checks the arguments to shop_price_sell() so that errors are
handled gracefully instead of triggering a failed assertion. The call
was moved before the check while refactoring, leading to crashes when
the assertion does not hold.

Fix by moving check before the call to shop_price_sell(). The root cause
still needs to be investigated and fixed.

1 lines of code changed in 1 file:

• server: shop.c (+1 -1)

partmedia 2016-08-12 23:01 #11 Rev.: 20306

Remove superfluous return statements

Reported by: Andreas Kirschbaum

3 lines of code changed in 1 file:

• common: porting.c (+3 -3)

partmedia 2016-08-12 23:01 #10 Rev.: 20305

Fix sign extension by using unsigned cast

Reported by: Coverity Scan

11 lines of code changed in 4 files:

• common: map.c (+6 -1)
• include: map.h (+3 -1)
• server: c_misc.c (+1 -1), c_wiz.c (+1 -1)

partmedia 2016-08-03 19:42 #9 Rev.: 20304

Fix botched memory leak fix

The fix in r20296 was incorrect and introduced double frees.

2 lines of code changed in 1 file:

• random_maps: room_gen_onion.c (+2 -7)

partmedia 2016-08-03 19:30 #8 Rev.: 20303

Use get_map_flags instead of GET_MAP_FLAGS

Reported by: Coverity Scan

1 lines of code changed in 1 file:

• server: move.c (+1 -1)

partmedia 2016-08-03 19:30 #7 Rev.: 20302

Fix order of operations

1 lines of code changed in 1 file:

• server: monster.c (+1 -1)

partmedia 2016-08-03 19:30 #6 Rev.: 20301

Fix overflows by using calloc() correctly

10 lines of code changed in 6 files:

• common: loader.l (+1 -1), map.c (+1 -1), object.c (+1 -1)
• socket: loop.c (+1 -1)
• utils: bwp.c (+5 -5), mapper.c (+1 -1)

partmedia 2016-08-03 19:30 #5 Rev.: 20300

Add explicit cast

1 lines of code changed in 1 file:

• server: login.c (+1 -1)

partmedia 2016-08-03 19:30 #4 Rev.: 20299

Fix incorrect substitution of NULL for ASCII NUL

Reported by: Coverity Scan

1 lines of code changed in 1 file:

• random_maps: style.c (+1 -1)

partmedia 2016-08-03 19:30 #3 Rev.: 20298

Add missing va_end()

Reported by: Coverity Scan

1 lines of code changed in 1 file:

• server: plugins.c (+1)

partmedia 2016-08-03 19:30 #2 Rev.: 20297

Convert randomness macros to functions

Each function that the randomness macros call returns a different type.
Explicitly declare a cf_random() and cf_srandom().

24 lines of code changed in 2 files:

• common: porting.c (+20)
• include: define.h (+4 -29)

partmedia 2016-08-03 18:43 #1 Rev.: 20296

Fix memory leaks

Reported by: Coverity Scan

6 lines of code changed in 1 file:

• random_maps: room_gen_onion.c (+6)

July 2016 »