May 2009 Commit Log

Number of Commits:
59
Number of Active Developers:
2
akirschbaum 2009-05-27 15:05 Rev.: 11727

Disable more per-dialog key bindings of cursor keys in inventory dialog.

2 lines of code changed in 1 file:

akirschbaum 2009-05-26 11:35 Rev.: 11726

Remove unneeded final modifier.

1 lines of code changed in 1 file:

akirschbaum 2009-05-25 23:39 Rev.: 11725

Make field final.

1 lines of code changed in 1 file:

akirschbaum 2009-05-25 23:38 Rev.: 11724

Update comments.

41 lines of code changed in 5 files:

kbulgrien 2009-05-25 16:28 Rev.: 11723

- GTK-V2 sixforty layout rework that started out as a general fix for the new
stat.c and pickup.c code, but became a general improvement effort. The
layout still has some issues as saving windows position seems unreliable -
possibly due to a need for constraining containers (viewport?) in the vpaned
widgets. To debug, experimentation with scrolled windows can show when
widgets might be have a size that subverts sizing. The default layout with
no sixforty.pos is sane.
- The stats panel is changed the most with scroll bars added so the wide stats
can be viewed in a small client.
- Both message panels are not in a notebook anymore to support recent chat,
tell, say changes.

1086 lines of code changed in 2 files:

akirschbaum 2009-05-25 14:09 Rev.: 11722

Disable per-dialog key bindings of cursor keys in inventory dialog. Now the character may move around while the inventory dialog is open.

13 lines of code changed in 2 files:

akirschbaum 2009-05-25 14:03 Rev.: 11721

Make login/logout messages darker to improve readability.

5 lines of code changed in 2 files:

akirschbaum 2009-05-25 13:49 Rev.: 11720

Rename field names.

5 lines of code changed in 1 file:

akirschbaum 2009-05-25 13:34 Rev.: 11719

Do not write invalid keybindings files.

23 lines of code changed in 5 files:

kbulgrien 2009-05-25 07:59 Rev.: 11718

- Fix an omitted change in the menubar edits made prior to support changes in
pickup.c to restore functionality and remove a warning during client start.

25 lines of code changed in 12 files:

akirschbaum 2009-05-24 00:37 Rev.: 11717

Add "def item" skin command. Move recurring parameters from "item" and "inventory_list" commands to "def item" parameters.

549 lines of code changed in 17 files:

kbulgrien 2009-05-23 21:30 Rev.: 11716

- GTK-V2 lobotomy layout has undergone a significant dress-up of the layout
and general reduction of various container widgets that are not necessary
for one reason or another. An issue with chat panels was discovered and
fixed. Under some circumstances, the vertical scroll bar would disappear
due to the horizontal scroll bar policy being set to never. The policy is
now set to automatic to prevent the issue. Unused menu bar widgets are
removed, and the menu widgets names are made more consistent.
- GTK-V2 menubar widgets are renamed to remove numeric suffixes & improve
uniformity.
- All GTK-V2 .glade files have had their menubars replaced with the new one
developed for lobotomy.glade to correspond with the changes in menubar.c and
pickup.c.

9706 lines of code changed in 14 files:

kbulgrien 2009-05-23 19:02 Rev.: 11715

- This update supports recent client code changes. The layout is basically
the same as before the the update but viewports are added in a number of
places to improve the aesthetics of the UI. The stat bar numeric data has
been moved to the left of the bars.

2487 lines of code changed in 2 files:

akirschbaum 2009-05-23 16:10 Rev.: 11714

Make /tell messages darker to improve readability.

5 lines of code changed in 2 files:

akirschbaum 2009-05-23 16:02 Rev.: 11713

Simplify code.

1 lines of code changed in 1 file:

akirschbaum 2009-05-23 15:03 Rev.: 11712

Add 'R' keybinding: reply to last player that has sent a /tell command.

286 lines of code changed in 19 files:

akirschbaum 2009-05-23 13:18 Rev.: 11711

Do not store 'char' type keybindings as 'int's.

3 lines of code changed in 2 files:

akirschbaum 2009-05-23 13:15 Rev.: 11710

Update comments.

21 lines of code changed in 2 files:

akirschbaum 2009-05-23 13:09 Rev.: 11709

Update comments.

47 lines of code changed in 1 file:

akirschbaum 2009-05-23 13:02 Rev.: 11708

Accelerate keybindings management.

3 lines of code changed in 1 file:

akirschbaum 2009-05-23 12:51 Rev.: 11707

Fix equals().

2 lines of code changed in 2 files:

akirschbaum 2009-05-23 12:50 Rev.: 11706

Simplify code.

8 lines of code changed in 2 files:

kbulgrien 2009-05-22 22:30 Rev.: 11705

- Update lobotomy, caelestis, and chthonic notes to mention the swapping of
critical and normal message panel positions due to chat, tell, and say
message routing to the critical panel.

5 lines of code changed in 1 file:

kbulgrien 2009-05-22 22:26 Rev.: 11704

- This update supports recent client code changes to widget count and names.
- The stat bar display is moderately reorganized to allow very long experience
data to be covered by the neighboring hpane panel as needed.
- The critical and normal message panels have swapped positions due to recent
use of the critical panel for chat, tell, and say messages (placed nearer
the command entry control).

2383 lines of code changed in 2 files:

kbulgrien 2009-05-22 21:59 Rev.: 11703

- This update includes both stylistic changes to lobotomy.glade and updates to
support recent client code changes. Though the lobotomy layout was unique
in certain respects, the notorious skills and stats carry-overs from the
original gtk-v2 layout were ugly. This commit introduces statistic panels
that are completely unique. The skills and protections areas still take up
the bulk of the bottom row, but they are designed to better avoid the
overlap that so easily occurs in gtk-v2. A stats cluster in the bottom
right corner explores a new method of organizing all character stats and any
related stat bars in a small area, while tending to avoid the width problems
that can so easily crop up with the stat bar numeric data. Another notable
change is that all notebooks except the map/magic map notebook are gone.
- The AUTHORS file is updated to describe the changes above.

2662 lines of code changed in 3 files:

kbulgrien 2009-05-22 20:16 Rev.: 11702

- Fix the character information panel by converting a single column table to
a vbox. Glade3 Designer displays the table as a three column table when
it is opened... even though it was displayed correctly when saved. There
must be a bug in the Designer.
- Various widgets that do not interact with the client code are given more
creative names.

403 lines of code changed in 2 files:

kbulgrien 2009-05-21 22:00 Rev.: 11701

- The prior commit accidentally omitted the gtk-v2.glade file changes even
though the commit comment mentioned it. The gtk-v2.glade changes described
are hereby committed.

2372 lines of code changed in 1 file:

kbulgrien 2009-05-21 21:58 Rev.: 11700

- This is the beginning of the rework of all .glade layouts to support SVN
revision 11699 changes to GTK-V2 client code.
- All of the files are changed using Glade3 Designer, so are about half their
former size. The files target Glade 2.12 and do not contain deprecations or
version conflicts.
- The HP/SP/Grace/Food/Exp label is split up into four labels each, and the
encumbrance data is also split. Though gtk-v2.glade has been changed
subtly, the data is still in the same relative location as the original
layout. The caelestis and chthonic relocate stat numeric data to the right
side of the progress bars to achieve the same improvements originally
developed for meflin.glade.
- The encumbrance portion of the layout has changed in the XML structure, but
does not appear different to the player.
- All layouts have had some viewports added in various places to give the UI
an overall better, more polished appearance.

5024 lines of code changed in 3 files:

kbulgrien 2009-05-21 21:46 Rev.: 11699

- The following commit introduces a code incompatibility with existing .glade
layouts. The reason for this change is to allow greater flexibility in UI
design. The existing "Stat: Current/Max" strings that appear beside the
progress bars (especially Exp:) get very long and bulky and do not align
well vertically. It is felt that all UI layouts will benefit from this
change, and that it will allow layout density to be increased for those who
prefer small UIs.
- Existing, unmodified .glade layouts may still be used, but some numeric
stat data (HP/SP/Grace/Food/Encumbrance/ExpToNextLevel) will no longer be
visible in the client until the layout is updated.
- meflin.glade rework sparked the idea for this change, and was used to test
the code, so is hereby committed. It improves readability by restructuring
the stats pane, and increases available UI space for critical messages by
allowing the player to easily hide very wide experience data displays.
- Expect the author to update all of the other layouts in relatively short
order.
- In summary, the .glade widget count has been increased slightly to support
splitting of data into more widgets. The stat widgets and weight widgets
have been renamed as part of this change. The client no longer explicitly
names stats with hard-coded strings. The stat names are now set by the
layout.

659 lines of code changed in 4 files:

akirschbaum 2009-05-21 12:01 Rev.: 11698

Fix possible resource leak.

11 lines of code changed in 1 file:

akirschbaum 2009-05-21 11:59 Rev.: 11697

Remove JXCWindowRenderer.init().

2 lines of code changed in 2 files:

akirschbaum 2009-05-21 11:53 Rev.: 11696

Fix display issues when the character is running.

111 lines of code changed in 3 files:

kbulgrien 2009-05-20 21:19 Rev.: 11695

- Whitespace change only (tab --> spaces).

12 lines of code changed in 1 file:

kbulgrien 2009-05-19 03:04 Rev.: 11694

- New lake graphics were created at 10251 that replaced the original graphics
drawn in the style of ../deep_sea.clc.*.png. Since the original style is
still in use by the classic face set, the old style graphics are recalled
from 8170 and re-instantiated as classic style graphics.

93 lines of code changed in 15 files:

kbulgrien 2009-05-19 01:48 Rev.: 11693

- The ground/Lake/blake_[7BDE]_base_11[1234].png graphics have been messed up
somehow. The small lake in Scorn uses them, and pixel errors are obvious
along the top edge and in the middle of the water. 7, D, and E are fixed
by pixel edits. The damage to B, however, is very bad and will need to be
done starting over from an undamaged 1, 2, 8, or A graphic and repairs are
not included with this commit.

0 lines of code changed in 12 files:

kbulgrien 2009-05-18 18:59 Rev.: 11692

- Change some river pieces in a lake near the southwestern corner of Scorn.
One to biglake to match the body of water, and one river outlet to try to
make the interface with the lake less ugly. A new river arch is needed!

3 lines of code changed in 1 file:

kbulgrien 2009-05-17 20:41 Rev.: 11691

- Swapped position of Messages and Look/Inventory at Meflin's request.
- With the look/inventory panel at the bottom, it makes more sense to put the
notebook tabs next to the command input to reduce mouse movement, so the
tabs are relocated to the bottom of the notebook.
- To maintain a consistent appearance, the stats/protections/skills notebook
tabs are also moved to the bottom of the notebook.
- The Range: slot in the stats table caused some expanding and contracting of
the stats panel when rotating through ranged skills, so it is now assigned a
row of its own. The cell where Range: used to be is now blank.
- After adding the Range: row, the table now has seven rows, so the Str, Dex,
Con, Int, Wis, Pow, Cha can now be laid out in a vertical fashion, so two
columns are added to do so, and the row previously assigned to them is gone.
- The addition of the Range: row also leaves a cell above WSp blank, so Run &
Fire is moved from the menubar to this cell.
- Added separators between the menu and the player information items in the
menu bar.

995 lines of code changed in 2 files:

kbulgrien 2009-05-16 21:57 Rev.: 11690

- Reworked the GTK-V2 meflin layout which was not used (probably because
messages were not visible when clicking or examining items with the mouse).
- The rework is based off of the sixforty layout to improve playability when
more screen area is available. The changes involve making sure critical
messages and regular messages are both visible at the same time. The
critical messages are put on the stats pane below the maps. The other big
change is to try putting ground view and inventory on their own tabbed
notebook with the ground view the default.
- Overall appearance of the client seems nicer as this layout makes more use
of viewports around various elements. There are still areas for improvement
like the menubar.
- The command input box seems small too, but its worth getting other feedback
before messing around too much more with it.
- This layout concentrates on keeping mousework at the bottom of the client
screen, and to pull that off, flips the tabs to the bottom in a few places.

1370 lines of code changed in 2 files:

kbulgrien 2009-05-16 19:06 Rev.: 11689

- Open GTK-V2 meflin.glade layout in glade3 and save changes after verifying
GTK+ target 2.12 and that deprecation and version mismatch checks pass.
Plan to use this layout to experiment with some concepts that sixforty
inspired.

2107 lines of code changed in 2 files:

kbulgrien 2009-05-16 17:46 Rev.: 11688

- Add sixforty.glade to the crossfire-client.spec and update its internal
changelog.

12 lines of code changed in 2 files:

kbulgrien 2009-05-16 16:20 Rev.: 11687

- Add a four-quadrant layout that seems workable at a 640x480 screen
resolution. It has some innovations for tightening up stats display, and
will likely be nice for larger resolutions also. This layout actually
appears to be different enough to inspire some ideas on how to make a few
code changes to improve the ability to tighten up the displays even more.
This layout was developed with glade2, but resaved using glade3 prior to
commit. The XML targets GTK+ 2.12 and fully passes glade3s deprecation and
version mismatch checks.
- Incorporate the new sixforty.glade into the build (Makefile.am), but changes
to the RPM .spec file are still pending.
- Add a descriptive summary of the new sixforty layout to the AUTHORS file.

2129 lines of code changed in 5 files:

kbulgrien 2009-05-15 21:15 Rev.: 11686

- Set the About dialog window_position property to center for more logical and
natural positioning of an infrequently viewed dialog. The other dialogs
seem to try to position themselves in corners of the screen, which makes
sense so they do not overlay each other, but it doesn't make a lot of sense
for the About dialog, and looks better this way.

8 lines of code changed in 2 files:

kbulgrien 2009-05-14 23:08 Rev.: 11685

- Try again to save the deletable property false.

565 lines of code changed in 1 file:

kbulgrien 2009-05-14 22:47 Rev.: 11684

- Set the deletable property False on all gtk-v2 dialogs to fix Tracker ID:
2784779 GTK-V2 loses dialogs if closed with X control. It looks like glade3
is going to be annoying. The diff is huge, but if you sort the old file and
new file, the real difference is only one line of text for each dialog.

7 lines of code changed in 1 file:

kbulgrien 2009-05-14 22:39 Rev.: 11683

- Open/save gtk-v2/glade/dialogs.glade using glade3 so that later
modifications may be better identified in a diff. Glade3 appears to save
widgets in alpha order. Glade3 also seemed to remove quite a bit of
content (79K reduced down to 55K), but so far what I have seen indicates
that glade2 to glade3 migration is pretty safe.

1251 lines of code changed in 2 files:

akirschbaum 2009-05-14 14:29 Rev.: 11682

Make MapNormalizer editor plugin script save only map files that needed normalization.

3 lines of code changed in 1 file:

akirschbaum 2009-05-14 14:25 Rev.: 11681

Adapt MapNormalizer editor plugin script to current Gridarta.

1 lines of code changed in 1 file:

akirschbaum 2009-05-14 14:21 Rev.: 11680

Suppress some 'cannot load map file' error messages in MapValidator editor plugin script.

6 lines of code changed in 1 file:

kbulgrien 2009-05-10 09:07 Rev.: 11679

- Change some of the RPM .spec file BuildRequires to be
more flexible after after testing on Mandriva 2009.0 (local machine) and
Centos (Invidious). Centos build failed with requires libcurl-devel and
libglade2.0-devel but both succeed if the requires are changed to curl-devel
and libglade2-devel. These new requires also work on fedora10.

10 lines of code changed in 2 files:

kbulgrien 2009-05-09 10:00 Rev.: 11678

- Added an svn:externals property to use server/include/shared revision
11676 to create and populate client/common/shared so that newclient.h is a
direct copy of the file maintained in the server area.

11 lines of code changed in 1 file:

kbulgrien 2009-05-09 09:48 Rev.: 11677

- After coming to the realization that newclient.h is better sourced in the
server so that different client codebases could conceptually use different
versions of the file depending on their development state, this file and
is now moved to server/include/shared. The common/shared is removed to allow
the server/include/shared directory to be made and external reference here.

0 lines of code changed in 1 file:

kbulgrien 2009-05-09 09:46 Rev.: 11676

- Add a server/trunk/include/shared directory able to be referenced as an SVN
external resource in the client source tree.
- Move client/trunk/common/shared/newclient.h control to the newly added
include/shared directory in the server.
- Add a README file to the new shared directory with a brief note documenting
the new maintenance procedures for the newclient.h file.

645 lines of code changed in 3 files:

kbulgrien 2009-05-09 09:12 Rev.: 11675

- After advice of Ragnor against svn:externals without -r, deleted the
svn:externals pointing to client/trunk/common/shared, after also coming to
the conclusion that this needs to be controlled in server vs. client so that
any client software base that wants to use this file can specify the version
of the file they want instead of the server having to pick one from
somewhere else.

9 lines of code changed in 1 file:

kbulgrien 2009-05-09 00:27 Rev.: 11674

Removed comment that talked about the file being separately controlled in
client and server. Add a comment to the #ifdef that switches the content of
one typedef depending on where it is compiled.

11 lines of code changed in 2 files:

kbulgrien 2009-05-08 23:48 Rev.: 11673

The file server/trunk/include/newclient.h was a separate copy of data from
client/trunk/common/newclient.h and was not kept in sync with the client.
Things were added either in client or server, but not both. The client
file was updated by merging all new content from the server file, and it
was then moved to client/trunk/common/shared/newclient.h so it would be
possible to set an svn:externals property in the server/trunk/include
directory that would cause a server/trunk/include/shared directory to be
created and populated as a mirror of client/trunk/common/shared. The
svn:externals property only works on directories. Now the file is truly
shared and changes in either area affect both builds. One conflict did
have to be resolved with #ifdef as a buf was declared differently in
the server than it was in the client.

29 lines of code changed in 11 files:

kbulgrien 2009-05-08 22:15 Rev.: 11672

Moved common/newclient.h to common/shared/newclient.h because svn
externals work on a directories only, and it is planned to use this
facility to share this file between the server and client to assure
synchronization.

756 lines of code changed in 11 files:

kbulgrien 2009-05-08 21:16 Rev.: 11671

Merge differences with server/trunk/include/newclient.h in preparation for
correcting the fact that the two files are separately maintained - allowing
divergence in implementation. One apparent required conflict is handled by
detecting a define present only in the client.

305 lines of code changed in 2 files:

kbulgrien 2009-05-03 16:50 Rev.: 11670

- Add a few more legitimate replies to the key question to avoid reset of the
conversation that would be aggravating.

1 lines of code changed in 1 file:

kbulgrien 2009-05-03 14:58 Rev.: 11669

- Remove duplicate floor pieces and duplicate monsters stacked on top of each
other.

1 lines of code changed in 1 file:

April 2009 »

Generated by StatSVN 0.7.0