August 2009 Commit Log

Number of Commits:
54
Number of Active Developers:
3
kbulgrien 2009-08-31 23:04 Rev.: 12180

- The Save and Load buttons are now enabled. The Save button is fully
functional, but the Load button only opens the save file and scans it
without actually loading the data. The Load data parsing is not yet
implemented. For now, it counts the number of non-comment and non-blank
lines and outputs a message if it does not match the number of message types
the system supports.
- msgctrl_init() no longer de-sensitizes the Save and Load buttons.
- save_msgctrl_configuration() now supports saving the message control
configuration to ./crossfire/msgs.
- load_msgctrl_configuration() does read the ./crossfire/msgs file, but does
not update the client message control configuration yet (though it does
reset the control to match the msgctrl_widgets[] state variables).
- on_msgctrl_button_load_clicked() now calls the load_msgctrl_configuration()
function.

106 lines of code changed in 2 files:

kbulgrien 2009-08-31 19:37 Rev.: 12179

- The hiscore command requests 50 high scores, but for some reason the command
that outputs the scores arbitrarily returns only 49. Removed a needless
decrement of the max parameter. Now the command returns the number of
scores requested.

6 lines of code changed in 2 files:

kbulgrien 2009-08-31 19:06 Rev.: 12178

- Remove help files that used to support the output-sync and output-count
functionality.

0 lines of code changed in 6 files:

kbulgrien 2009-08-31 19:05 Rev.: 12177

- Remove i18n strings and help files that used to support the output-sync and
output-count functionality.

19 lines of code changed in 4 files:

kbulgrien 2009-08-30 22:34 Rev.: 12176

- Go ahead and make change to attribute messages default to go to both so that
level ups show up in critical. Meflin concurs.

1 lines of code changed in 1 file:

kbulgrien 2009-08-30 15:40 Rev.: 12175

- Add some space between the Message Control dialog buttons (in the HButtonBox
setup) so they are not crammed completely together when the dialog is small.

3 lines of code changed in 2 files:

kbulgrien 2009-08-30 15:34 Rev.: 12174

- Add Defaults and Load buttons to Message Control dialog in dialogs.glade.
- Update the gtk2proto.h file per addition of Defaults button support in the
Message Control dialog.
- Rename msgctrl_data[] to msgctrl_defaults[] to better indicate current
function and make all values const. This data is no longer modified at
run-time.
- In msgctrl_init(), connect the Load and Defaults buttons, but in the case
of the Load button, desensitize it until the functionality is present.
- Replace widget and state variable initialization code in msgctrl_init() with
a call to a new default_msgctrl_configuration().
- Add update_msgctrl_configuration() to update the the widgets on the Message
Control dialog with the values in the msgctrl_widgets[] state variables.
- Add default_msgctrl_configuration() in which msgctrl_widgets[] state is
initialized. It loads all msgctrl_widgets[] state variables with values
stored in msgctrl_defaults[]. This method runs when the Defaults button is
pressed and when msgctrl_init() runs. update_msgctrl_configuration() is
then invoked to perform an implicit apply when the client defaults are
reloaded.
- Added on_msgctrl_button_load_clicked() to support the new Load button.
- Added on_msgctrl_button_defaults_clicked() to support the Defaults button.

698 lines of code changed in 4 files:

kbulgrien 2009-08-30 13:18 Rev.: 12173

- Rework the data structures for the Message Control dialog to prepare for
supporting return to default. msgctrl_data[] is now only used to hold the
defaults. Also convert the buffer empty code to use the flush function to
centralize that operation in one place.

67 lines of code changed in 2 files:

kbulgrien 2009-08-29 22:12 Rev.: 12172

- Bug fix for output-count sometimes outputting duplicate messages when a lot
of messages pass through the system with single occurances that never
accumulate duplicates.

11 lines of code changed in 1 file:

kbulgrien 2009-08-29 21:53 Rev.: 12171

- Fix a missed rename in draw_ext_info().
- Add braces to avoid wasted debug time due to forgetting to put them in.

6 lines of code changed in 1 file:

kbulgrien 2009-08-29 16:25 Rev.: 12170

- Some aesthetics and practical improvements to the Message Control dialog
including using the names of the message panels exactly as they appear
in all the client layouts.

54 lines of code changed in 1 file:

kbulgrien 2009-08-29 16:07 Rev.: 12169

- Until the layouts are changed, refer the the secondary message panel as
it is labelled in the client layout - "Critical".

1 lines of code changed in 1 file:

kbulgrien 2009-08-29 15:47 Rev.: 12168

- Add the new Message Control menu item to the Client menu.

100 lines of code changed in 12 files:

kbulgrien 2009-08-29 15:24 Rev.: 12167

- Begin referring to the in-client output-count and message routing as the
"Message Control System", and add support for in-client, player
configuration via a new dialog to replace previously hard-coded settings.
- Change some previously selected data types to GTK data types to make
interfacing with the UI require fewer casts.
- Instead of continuing to use the info_ prefix for this functionality, start
using a msgctrl_ prefix.
- Added new functions to support the Message Control dialog: msgctrl_init()
which does the dialog setup on client start;
save_msgctrl_configuration(), and load_msgctrl_configuration() that are
presently stubs, but are intended to be used to allow the message control
configuration to be saved and restored. read_msgctrl_configuration()
obtains the state of the Message Control dialog checkboxes, and dynamically,
at run-time, allows the player to reconfigure which message types undergo
duplicate suppression, and to which message panels they are routed to.
on_msgctrl_button_save_clicked(), on_msgctrl_button_apply_clicked(), and
on_msgctrl_button_close_clicked() support the dialog buttons (though
presently the save button is disabled as saving and loading is not yet
supported). on_msgctrl_activate() displays the new dialog when the Client |
Message Control menu option is selected.
- All new data structures and functions are heavily commented in the doxygen
style.
- Added a call to msgctrl_init() in main() during client startup to construct
the checkbox table and preset all the checkboxes to match the hardcoded
defaults in info.c.
- Link the new Message Control dialog into the client menu.

341 lines of code changed in 4 files:

kbulgrien 2009-08-29 15:00 Rev.: 12166

- Update to include prototypes for the new Message Control system in-client
configuration support.

10 lines of code changed in 2 files:

kbulgrien 2009-08-29 14:45 Rev.: 12165

- Add a new Message Control dialog that is for configuring the client-side
output-count and message routing. The table only has static titles set.
The client code will construct the rest of the dialog widgets needed to
configure the system.

205 lines of code changed in 2 files:

kbulgrien 2009-08-29 14:40 Rev.: 12164

- Dress up the About dialog by adding an HSeparator and by replacing an HBox
with an HButtonBox. Padding adjusted here and there, and now widgets all
have meaningful names.

32 lines of code changed in 2 files:

kbulgrien 2009-08-29 14:32 Rev.: 12163

- Change up some padding on the config dialog for appearance. Rename widgets
to meaningful names.

35 lines of code changed in 2 files:

kbulgrien 2009-08-29 14:06 Rev.: 12162

- Make the spell dialog look a bit nicer by adding an HSeparator and replacing
an HBox with an HButtonBox. Some padding also adjusted. Renamed widgets
with meaningful names.

21 lines of code changed in 2 files:

kbulgrien 2009-08-29 13:54 Rev.: 12161

- Dress up the keybinding dialog by adding an HSeparator, by replacing an HBox
with an HButtonBox, and by adjusting some padding here and there.

25 lines of code changed in 2 files:

kbulgrien 2009-08-29 13:43 Rev.: 12160

- Dress up the metaserver dialog by adding a couple of horizontal separator
bars and by replacing an HBox with a HButtonBox. Rename widget names that
were "typenumber" to "dialog_type_description".

41 lines of code changed in 2 files:

akirschbaum 2009-08-27 13:07 Rev.: 12159

Remove unneeded else clause.

21 lines of code changed in 1 file:

akirschbaum 2009-08-27 13:03 Rev.: 12158

Remove duplicate initializations.

4 lines of code changed in 3 files:

akirschbaum 2009-08-27 10:35 Rev.: 12157

Actually fix the crash when updating the ground or inventory view.

6 lines of code changed in 2 files:

kbulgrien 2009-08-25 21:13 Rev.: 12156

- Set up an info_control[] array of structs, one element for each message
MSG_TYPE_* in common/shared/newclient.h. This array contains enable/disable
flags that determine whether or not a message shows up in any of the message
panels (and it is possible to route message types to both panels). The
array also determines which of the message types are processed for duplicate
message reduction. There are still a few conditions that override the
info_control[] settings. Presently the array is filled with hard-coded
defaults, but they will ultimately become defaults that can be over-ridden
by an in-client control panel and, eventually, by settings saved to a
configuration file. message_callback() and draw_ext_info() are now modified
to use info_control[] instead of the hard-coded settings they used
previously.

213 lines of code changed in 2 files:

kbulgrien 2009-08-23 21:17 Rev.: 12155

- Adjust the client-side output-count implementation to always output a
message the first time it occurs when it first enters the buffering system.
After the initial display, the output-count and sync settings determine
display time. With the new scheme, inactive buffers are also aged and
discarded by age so that the content can be re-used if the message recurs
before it is pushed out of the buffer. The "initial" display of a message
is not done if the message buffer is re-activated after having been
inactivated by output-count or sync. Meflin also pointed out the trailing
" (Nx)" differed from the original server implementation, so now the count
is prefixed on the message as "N times ". This changed the size of the
count buffer, and affected the output buffering method - making it more
logical to avoid allocating the count buffer in each message buffer, but
rather only one time in the info_buffer_flush() function. This
implementation is a bit heavier since buffers are now processed more when
they are inactive, but it does get unique messages to the player more
quickly even if they happen to pass through the duplicate suppression
system.

172 lines of code changed in 2 files:

kbulgrien 2009-08-20 19:22 Rev.: 12154

- More doxygen @file comment conversions, this time for the gtk v1 client.

61 lines of code changed in 12 files:

kbulgrien 2009-08-20 17:31 Rev.: 12153

- Fix some rcsid variable references renamed with the prior commit.

2 lines of code changed in 2 files:

kbulgrien 2009-08-20 05:56 Rev.: 12152

- Add doxygen @file and in the case of common.c, add a header not present
that is commonly used in all other source files.

44 lines of code changed in 3 files:

kbulgrien 2009-08-20 05:47 Rev.: 12151

- Narrow in on more reasonable defaults for duplicate message suppression.

1 lines of code changed in 1 file:

kbulgrien 2009-08-19 21:40 Rev.: 12150

- Exempt chats/tells from duplicate message suppression (until a proper
configuration is available.

1 lines of code changed in 1 file:

kbulgrien 2009-08-19 20:11 Rev.: 12149

- Convert header comments, if any, to doxygen @file comments. Add stubs just
to encourage someone to put something there later if no comment existed.

137 lines of code changed in 21 files:

kbulgrien 2009-08-18 22:05 Rev.: 12148

- Convert/add file and function header comments in doxygen format.
- Fix spelling.

182 lines of code changed in 1 file:

kbulgrien 2009-08-18 21:32 Rev.: 12147

- Adjust the doxygen defgroup names for map and spell command function groups.
- Fix spelling.

5 lines of code changed in 1 file:

kbulgrien 2009-08-18 21:23 Rev.: 12146

- Convert file header and function header comments to doxygen format.
Transfer some information in the file header to the function headers.
- Convert grouping comments to use doxygen @defgroup.

258 lines of code changed in 1 file:

kbulgrien 2009-08-18 21:20 Rev.: 12145

- Change the doxygen grouping construct to use @defgroup.
- Fix spelling.

3 lines of code changed in 1 file:

kbulgrien 2009-08-17 21:54 Rev.: 12144

- Some doxygen fixup and comment errors corrected from the output-count/sync
implementation just committed.

10 lines of code changed in 1 file:

kbulgrien 2009-08-17 21:28 Rev.: 12143

Implement a client-side replacement for the recently removed output-count and
output-sync commands. The client implementation matches the basic operation
of the server feature. Output-count determines the highest number of messages
that can to coalesce into one. The output-sync determines the maximum amount
of time a message stays in a buffer until it is displayed. The present code
has output-count hardcoded to 16 (info.c: MESSAGE_COUNT_MAX) and output-sync
to 16 client ticks, or about 2 seconds (info.c: MESSAGE_AGE_MAX). Messages
ARE NOT considered for duplicate suppression if: define MESSAGE_COUNT_MAX <=
1; the message is sourced from client code; the hinted color of the message is
NDI_UNIQUE; the message length is greater than 56 characters. Messages are
displayed if either output-count or output-sync limits are reached. Either or
both client command configuration and GUI configuration is planned. Probably
GUI configuration will be implemented with an ability to configure message
routing as well.

352 lines of code changed in 4 files:

kbulgrien 2009-08-13 21:08 Rev.: 12142

- Add a note to the Changelog entry for r12141 to note I18N impact.

3 lines of code changed in 1 file:

kbulgrien 2009-08-13 21:06 Rev.: 12141

Remove output-count and output-sync from the server. Remove the output buffer
defines and declarations, along with the outputs_sync and outputs_count items.
Remove now unused flush_output_element(), check_output_buffers(), various
comments, calls to removed functions, output-sync and output-count command
support, player struct outputs_sunc and outputs_count members. This mod does
attempt to preserver player file compatibility with older server versions by
always saving legacy defaults to the player file outputs_sync and count
parameters. Re-ran make cproto to add missing items fix brokenness in the
proto files. NOTE: References to I18N_MSG_CMISC_099, 100, 101, 102, 103, and
104 were removed, but the messages themselves were not removed and no attempt
was made to see if other references still exist. Also note, it is intended
that the output-sync and output-count function will be soon restored, but in
the gtk-v2 client. There is no plan to restore it to the legacy clients.
jxclient reportedly already implements output-count/sync functionality.

46 lines of code changed in 10 files:

kbulgrien 2009-08-11 05:17 Rev.: 12140

Fix bug 2835449 pickup is broken by changing server/login.c check_login() to
read the pickup value saved in the player file as an unsigned value instead
of as a signed value. Unfortunately corrupted player files still have the
debug bit set, and this fix does not address that issue. To fix the player
file, zero out the pickup value, or adjust the value to turn off the debug
bit.

15 lines of code changed in 2 files:

kbulgrien 2009-08-10 16:50 Rev.: 12139

- Fix regression introduced at revision 12136 by commenting an uncommented
line in experience table D (Table C is supposed to be used). Reported
by MarkM / knotwork. Causes server start failure [Error] Experience
for level 116 is lower than previous level (0 <= 67200000000).

11 lines of code changed in 2 files:

kbulgrien 2009-08-09 19:29 Rev.: 12138

- Fix an incomplete rename of ratio_pickup_off1 to ratio_pickup_off in the
pickup menu. This is a partial fix of the recent breakage in the pickup
menu.

95 lines of code changed in 11 files:

kbulgrien 2009-08-08 21:19 Rev.: 12137

Modify pentagram and glyph msg/endmsg to indicate limitations and to add an
example of use.

16 lines of code changed in 3 files:

meflin2 2009-08-08 10:13 Rev.: 12136

set perm XP to 50 like metalforge missed the settings file

1 lines of code changed in 1 file:

meflin2 2009-08-08 10:12 Rev.: 12135

set perm XP to 50 like metalforge

46 lines of code changed in 2 files:

akirschbaum 2009-08-08 03:51 Rev.: 12134

Fix crash due to "java.lang.ArrayIndexOutOfBoundsException" when updating the ground or inventroy view.

14 lines of code changed in 2 files:

kbulgrien 2009-08-03 22:50 Rev.: 12133

- Fix for tracker #2825935 `cast consecrate` regression introduced at revision
11827, Sat Jun 13 2009 in server/spell_effect.c that resulted in "You are
not standing over an altar!" even when standing on an altar. The regression
caused the altar check to iterate over character inventory instead of
objects below the character. Various spelling issues also corrected.

23 lines of code changed in 2 files:

kbulgrien 2009-08-03 19:14 Rev.: 12132

- Rework some grammar and remove linebreaks from a message.

3 lines of code changed in 1 file:

kbulgrien 2009-08-02 21:41 Rev.: 12131

- Remove duplicate grass tiles from trees and tower.

1 lines of code changed in 1 file:

kbulgrien 2009-08-02 07:30 Rev.: 12130

- Fix a spelling mistake introduced in 12129.

1 lines of code changed in 1 file:

kbulgrien 2009-08-01 18:24 Rev.: 12129

- Fix a whitespace issue with attack message "viciously strikes".

4 lines of code changed in 2 files:

meflin2 2009-08-01 15:38 Rev.: 12128

spells need more literacy

1 lines of code changed in 1 file:

meflin2 2009-08-01 14:43 Rev.: 12127

initial spell re-level change

134 lines of code changed in 132 files:

July 2009 »

Generated by StatSVN 0.7.0