Fix prototype declaration.
1 lines of code changed in 1 file:
- Add a new m4 macro ax_pthread.m4 to (hopefully) better suport detection of
pthreads. See: SF tracker ID 2850517 for info: crossfire-client-1.12.0
build failure under Slackware 12.2 - ID: 2850517. Note that ax_thread.m4 is
itself licensed under GPLv3. Note a possibility for license confusion, but
also note that a review of various projects shows a fairly common precedent
of allowing mixed licenses in the m4 macro directory - not all explicitly
documenting the fact that different licenses are used. Other projects
maintain a file identifying copyright and licensing provisions for various
parts of the project. Whereas it is very likely other sources will be
modified, it is highly unlikely anyone will expect to modify the .m4 macros
in this project.
- Replace AC_CHECK_LIB(pthread, pthread_create) method of detecting pthreads
with AX_PTHREAD()i
- Modify the configure.ac file to create a configure script that reports if
the x11 client is built. There is no reason to avoid this since it reports
other clients are or are not built.
- Modify the configure script notice "Will build * renderer" to "With *
renderer" since it looks silly in the case where no clients are built that
use the renderers.
- Modify common, x11, gtk, and gtk-v2 Makefile.am files to use PTHREAD_CFLAGS
and PTHREAD_LIBS variables as advised by the new macros/ax_pthread.m4 file.
It is advised that both CFLAGS and LIBS variables be used (even though on
some systems both are not needed).
601 lines of code changed in 8 files:
backport r11803 god enchant bug fix
42 lines of code changed in 1 file:
- Improve comments for load_image() in common/image.c.
9 lines of code changed in 1 file:
- Convert function header comments to doxygen style so they show up in the
generated documentation.
77 lines of code changed in 1 file:
- Rework un-deux.glade layout to support SVN revision 11699 changes to GTK-V2
client code. HP/SP/Grace/Food/Exp label is split up into four labels each,
and the encumbrance data is also split.
293 lines of code changed in 2 files:
- Continued fixing of hp/sp/food/grace/encumbrance in the gtk-v1 themed
glade files.
291 lines of code changed in 2 files:
- This is a resumption of the rework of all .glade layouts to support SVN
revision 11699 changes to GTK-V2 client code. HP/SP/Grace/Food/Exp label is
split up into four labels each, and the encumbrance data is also split.
This change fixes all zeroes reported by knotwork/mark metson. The other
layouts in the V1 theme need similar updates.
296 lines of code changed in 2 files:
- ChangeLog for prior commit.
37 lines of code changed in 1 file:
- The msgctrl_window now has more padding around the title label to improve
aesthetics.
- The header of the message control dialog is modified to make room for two
spinbutton controls: msgctrl_spinbutton_count and msgctrl_spinbutton_timer.
The spinbuttons allow user access to the output count and time controls
previously hardcoded. The controls have tooltips that explain what they are
for. Both spinbuttons allow pasting new values, clicking the value up/down,
or using PgUp/PgDn to adjust the values in one second increments (8 client
ticks).
- The tooltips for all of the message control dialog column labels are
reworked.
- Padding is added to numerous message control dialog widgets to improve the
overall appearance of the dialog.
- Tool tips have been added to all the message control dialog buttons to give
some indication of what they do.
- Add output count and timer spinbutton control capability to the new message
control dialog by adding to info.c a buffer_parameter_t struct typedef and
buffer_control initialize structure that contains space for the pointer,
state variable, and a default value. The message_control struct is
initialized with the #defines that controlled the system previously.
- Renamed checkbox_t to boolean_widget_t since it doesn't really matter what
kind of control is used as we only care whether it supports some kind of
on/off capability.
- msgctrl_init() initializes the state and ptr members of the buffer_control
structure. Comments are also added to the function header.
- update_msgctrl_configuration() now updates the count and timer spinbuttons.
- save_msgctrl_configuration() has improved comments, and also reads the
dialog to assure saving of the currently displayed settings and not just the
last applied settings. The save file format is modified to add the
spinbutton values. The format of the file is slightly changed to include a
record type so that it is easier to validate the file format.
- load_msgctrl_configuration() is heavily modified to improve the savefile
error detection, and to support the new file format. The load process is a
bit more strict about the file being in the right format. Saved values are
only read from records that are in the correct format.
- Spinbutton initialization is added to default_msgctrl_configuration().
- The comment header for read_msgctrl_configuration() is improved and
spinbutton support added.
- Comment improvements are made for all the button handlers.
- on_msgctrl_button_close_clicked() automatically applies the current values
displayed on the control.
357 lines of code changed in 2 files:
- Support autoload of Message Control dialog settings by reading the
configuration file in msgctrl_init().
- Move msgctrl_init() later in client start up so that autoload of Message
Control dialog settings does not segfault.
9 lines of code changed in 3 files:
- The Message Control dialog Load button is now fully functional.
- Changed some of the struct definitions to be compatible with use to allocate
a buffer in load_msgctrl_configuration() by making them typedefs and then by
declaring the msgctrl_widgets[] separately.
- Fix the update_msgctrl_configuration() truncated header comment.
- save_msgctrl_configuration() client message format changed to report the
save file path/filename.
- Add load_msgctrl_configuration() data parsing using strtok() and only report
settings were loaded if at least some valid data records were processed. If
any data records are not in the expected format, the file is reported as
corrupt.
- Add comments to local variables in several message control system functions.
- Remove various instances of end-of-line whitespace.
120 lines of code changed in 2 files:
- The Save and Load buttons are now enabled. The Save button is fully
functional, but the Load button only opens the save file and scans it
without actually loading the data. The Load data parsing is not yet
implemented. For now, it counts the number of non-comment and non-blank
lines and outputs a message if it does not match the number of message types
the system supports.
- msgctrl_init() no longer de-sensitizes the Save and Load buttons.
- save_msgctrl_configuration() now supports saving the message control
configuration to ./crossfire/msgs.
- load_msgctrl_configuration() does read the ./crossfire/msgs file, but does
not update the client message control configuration yet (though it does
reset the control to match the msgctrl_widgets[] state variables).
- on_msgctrl_button_load_clicked() now calls the load_msgctrl_configuration()
function.
106 lines of code changed in 2 files: