Allow include rules to contain a "pre" block which will be evaluated to decide
whether to allow the file(s) to be included. This is treated in exactly the same
way as the "pre" blocks for all other rules.
A test map demonstrating this in use is included.
62 lines of code changed in 6 files:
- Lession: re-read carefully before commit. Fix problem with last check in.
1 lines of code changed in 1 file:
- Remove convoluted logic from metaserver_load_cache().
8 lines of code changed in 1 file:
Fix a substantial number of other script paths that I had missed previously.
57 lines of code changed in 16 files:
Fix the paths to npc_dialog.py so that this script actually gets called.
3 lines of code changed in 2 files:
- Completed fix initiated at commit 13020 (or fixed regression introduced at
that point). The "fix" was incomplete, and resulted in scrambling of the
cache file. Sorry folks.
1 lines of code changed in 1 file:
- Add prototype for GTK-V2 client use.
5 lines of code changed in 1 file:
- The GTK-V2 client now updates the player's ~/.crossfire/servers.cache file
whenever a connection with a server is successful.
- Remove an unused variable.
11 lines of code changed in 2 files:
- Replace duplicated code with call to metaserver_connect_to().
44 lines of code changed in 1 file:
Extract FacesTracker from JXClient.
120 lines of code changed in 2 files:
Move KeyHandler construction from JXCWindow to JXClient.
7 lines of code changed in 2 files:
Remove JXCWindow.defaultKeyHandler.
1 lines of code changed in 1 file:
Move code from JXCWindow to DefaultKeyHandler.
52 lines of code changed in 2 files:
Extract DefaultKeyHandler from JXCWindow.
130 lines of code changed in 2 files:
Extract OutputCountTracker from JXCWindow.
163 lines of code changed in 3 files:
Move call toload keybindings from JXCWindow to JXClient.
1 lines of code changed in 2 files:
Extract PickupTracker from JXCWindow.
165 lines of code changed in 3 files:
Remove unused parameter.
2 lines of code changed in 2 files:
Remove duplicated code.
1 lines of code changed in 1 file:
Extract PlayerNameTracker from JXCWindow.
175 lines of code changed in 3 files:
Remove unnneeded variable.
2 lines of code changed in 1 file:
Whitespace change.
0 lines of code changed in 1 file:
Remove dependency JXCWindow -> FacesManager.
64 lines of code changed in 2 files:
Move initialization code from JXCWindow to JXClient.
11 lines of code changed in 2 files:
Move parameters to SkinLoader constructor.
24 lines of code changed in 3 files:
Move JXCSkinLoader construction from SkinLoader to JXClient.
16 lines of code changed in 2 files:
Extract SkinLoader from JXCWindow.
494 lines of code changed in 6 files:
- Factor out the server cache maintenance code out of the metaserver_select()
function used by older clients to make it is accessible to clients that use
a different mechanism for selecting a server to play on. The new function
is called metaserver_update_cache().
80 lines of code changed in 1 file:
- Rewrite the ChangeLog and fix the commit comment for 13020. What was
originally written was not clear enough to explain the circumstances that
triggered the buggy behavior in metaserver_load_cache().
6 lines of code changed in 1 file:
- Fixed a logic bug in the loader that reads player .crossfire/servers.cache
files. The loader wrongly ignored the last valid entry in a cache when it
contained an odd number of lines. I.e. if the servers.cache file had only
one valid two-line entry, and an extra blank line, the loader ignored the
the valid entry and it would not show up in the client. With this change,
it does show up.
8 lines of code changed in 2 files:
- Add doxygen-style comment headers to all functions that do not already have
them, and as needed reformat existing headers.
- Add detail to the metaserver_load_cache() comment header.
39 lines of code changed in 1 file:
Make sure newly opened dialogs are displayed on top of other dialogs.
9 lines of code changed in 3 files:
Fix broken anchor and HTML syntax errors.
4 lines of code changed in 1 file:
- In init_connection(), fix tests for failure to properly check only for
-1 return values when calling socket(), fcntl(), connect(), and select().
- If fcntl() fails, do not try to immediately re-call it to set blocking
mode in init_connection(). Instead, just fail.
15 lines of code changed in 1 file:
- In the case where HAVE_GETADDRINFO is available (not WIN32), a timeout is
now implemented when establishing a connection with a server. The timeout
is presently hard-coded at 30 seconds. Prior to this, if a connection
attempt failed, the client was observed to lock up hard for three minutes.
Half a minute is still pretty harsh, but a DNS lookup failure can take 30
seconds, so it may be wiser to wait at least as long before bailing out on
the attempt.
137 lines of code changed in 2 files:
Break out the CFDialog python script into a dispatcher for a number of smaller, action oriented scripts.
363 lines of code changed in 15 files:
Change the timer condition to match what the sign says.
1 lines of code changed in 1 file:
Update Changes file to include the change from revision 13010
3 lines of code changed in 1 file:
Add wheelbarrow to cornerbrook
4 lines of code changed in 1 file:
Add wheelbarrow. This uses an image drawn by kbulgarien
30 lines of code changed in 3 files:
Merge the dialog rules for the gate guards into a common .msg file that both
can include.
66 lines of code changed in 3 files:
Updates to the quest test map and a number of .msg files that demonstrate
how to use include to source rules from different files.
76 lines of code changed in 6 files:
Change the npc_dialog.py file to allow message files to include other message
files.
39 lines of code changed in 1 file:
Fix Typo in quest include
1 lines of code changed in 1 file:
Change the custom name of the red dragon mail to Red Dragon Mail
2 lines of code changed in 1 file:
Change the name of dragon scales and dragon mails to red dragon scales/mail.
10 lines of code changed in 3 files:
Add the gorks quests file to the includes for the scorn file so it is picked up properly.
1 lines of code changed in 1 file:
Support for the various quests that track passage through the gates of scorn.
1242 lines of code changed in 17 files:
Amendment to goths tavern needed for the coffeegoose quest
6 lines of code changed in 1 file:
Questify the 'Esmeralda the goose' quest.
497 lines of code changed in 11 files:
Quest handling for Terry's farm. This commit includes some quest definitions that are not implemented on the maps yet.
424 lines of code changed in 6 files:
A Simple introductory quest in the newbies house.
121 lines of code changed in 4 files:
Questify Gramps Malone's two fedex quests.
429 lines of code changed in 9 files:
Questify Gork's treasure hoard.
113 lines of code changed in 6 files:
Add a 'quest' to get armour custom-made by the smith in scorn armour shop.
346 lines of code changed in 5 files:
Update test map to use new dialog syntax
3 lines of code changed in 1 file:
Update existing dialog files to use the new dialog syntax
109 lines of code changed in 9 files:
Updates to the dialog handling files to support more powerful syntax
294 lines of code changed in 2 files:
Move npc_dialog.py to the dialog directory rather than misc/
152 lines of code changed in 2 files:
Revert the files added in commit 12790, these will be created from the original versions instead.
0 lines of code changed in 2 files:
server/account_char.c: Modify to use the map name, not path for character
listing if that data is available - gives nicer output.
socket/request.c: Add numeric face number for character information, add
standard handling to send face number to client before use.
test/unit/common/check_living.c: Minor change to make it C89 compliant.
MSW 2010-04-26
46 lines of code changed in 4 files:
- Where LOG() is called with a string like "gtk-v2:*" or "<filename>:*", make
the string use double colons for consistency with common code and many
other files.
14 lines of code changed in 5 files:
- Where LOG() is called with "gtk::*", change the label to "gtk-v2::*" as
these are carryovers from the gtk-v1 client sources. The convention is
established by LOG() messages in common that use the string "common::*".
37 lines of code changed in 9 files:
- Re-ran `make proto` to catch all the new account login functions, and other
accumulated changes.
36 lines of code changed in 1 file:
- Rename init_cache_data() to init_image_cache_data(). "cache" is not unique
enough. The init_cache_data() call immediately follows setup of the
servers_cache_file, and the two are completely unrelated. The name
init_cache_data() undoubtedly persisted from ../../gtk/gx11.c.
3 lines of code changed in 2 files:
- Rework gtk-v2 Makefile.am to fix `make proto`. Factor the CFLAGS out of
INCLUDES and put them in AM_CFLAGS instead to take PTHREAD_CFLAGS out of
INCLUDES. On some systems, PTHREAD_CFLAGS resolves to -pthread or other
similar options. Since INCLUDES is on the cproto command-line -pthread gets
interpreted as cproto command flags. That is bad as it is, but doubly so
since cproto bombs out with a complaint that "h" is not a valid option.
This factoring seems safe to do because ../../macros/ax_pthread.m4 does not
contain any references to -I options.
11 lines of code changed in 1 file:
Quest definition files using the new quest definition syntax
131 lines of code changed in 3 files:
Make the quest file allow other files to be 'included'. Make the error
messages for quest definitions more explicit. Change the default quests file.
79 lines of code changed in 2 files:
Clear hp fixing code. Fix previous gr commit.
6 lines of code changed in 2 files:
Clean player grace fixing code.
8 lines of code changed in 2 files:
Clean player sp fixing code.
6 lines of code changed in 2 files:
Extract part of fix_object() to fix_player(), to make the function more manageable.
213 lines of code changed in 2 files:
Rename POTION_EFFECT to POTION_RESIST_EFFECT to better describe what it is.
18 lines of code changed in 9 files:
Warn players of the end of resistance effects.
14 lines of code changed in 2 files:
Some unit tests for fix_object().
165 lines of code changed in 3 files:
Add NPC_Gift_Box, an object which can hold items for npc's to give away, which
won't drop when they are killed. Use of this is preferred to the main inventory
because then there can't be any random treasure generated with the same name
15 lines of code changed in 2 files:
Add the two quests referenced in the test map
70 lines of code changed in 1 file:
A test map and associated .msg files that demonstrate the things that can
be done with the test scripts and extended dialog files. The signs describe
what should happen at each place, this map is intended to also track buggy
behaviour and regressions.
1503 lines of code changed in 9 files:
Two scripts which can be used to handle quest interaction with maps
102 lines of code changed in 2 files:
Add CFNPCDialog.py and the wrapper script dialog/npc_dialog.py, a wrapper script for advanced dialog handling.
152 lines of code changed in 2 files:
Make examining an item automatically attempt to identify it.
172 lines of code changed in 4 files:
Add missing files for make distcheck.
MSW 2010-04-25
2 lines of code changed in 22 files:
Add missing includes, add some makefiles for them for make distcheck.
MSW 2010-04-25
12 lines of code changed in 7 files:
Add missing files, remove files that no longer exist - needed for
make distcheck.
MSW 2010-04-25
4 lines of code changed in 3 files:
Update version to be 1.50.trunk
MSW 2010-04-25
1 lines of code changed in 1 file:
Add break for 1.50.0 release
MSW 2010-04-25
4 lines of code changed in 1 file:
Remove dev tag from version numbers. Remove top of SVN trunk
from ChangeLog
MSW 2010-04-25
0 lines of code changed in 6 files:
Update version numbers in configure, client-spec.
common/client.c: Send server deprecated 'newmpcmd 1' setup option - this lets
the client work properly on old servers.
MSW 2010-04-25
13 lines of code changed in 4 files:
Remove top of SVN comment.
MSW 2010-04-25
0 lines of code changed in 2 files:
Add breaks to mark different versions, add 1.50.0 break.
MSW 2010-04-25
7 lines of code changed in 1 file:
Remove SVN top of line from 1.50.0 release tag, since there
should not be future commits to this.
MSW 2010-04-25
0 lines of code changed in 2 files:
Add break marker for 1.50 release.
MSW 2010-04-25
7 lines of code changed in 1 file:
Change AC of doors to make them easier to hit. Doors in general should not
be difficult to hit.
MSW 2010-04-25
29 lines of code changed in 7 files:
server/attack.c: Don't make doors (or other objects) harder to hit because
they lack a move type. Remove unused variable.
MSW 2010-04-25
12 lines of code changed in 2 files:
- Fix a missing whitespace issue that makes books read like "which gives the
recipientImmunity to magic".
6 lines of code changed in 2 files:
Add missing code for account login to display character icons (note server
code won't be checked in until after 1.50 release). Add missing function
declarations to external.h to remove compiler warnings. Update common/shared
to latest version.
common/commands.c: Add support for new attribute.
common/external.h: Add missing declarations.
gtk-v2/src/account.c: Update update_character_choose() to display icon.
MSW 2010-04-24
50 lines of code changed in 4 files:
Add ability to send face number (instead of name) - add new definition
to newclient.h, update protocol doc. First commit is so shared newclient.h
file can get used.
Files affected: include/shared/newclient.h doc/Developers/protocol
MSW 2010-04-24
18 lines of code changed in 3 files:
- Remove the Skills/Experience tab from the core stats notebook in
gtk-v2.glade as the skills window is better to use. Tested at 1400x1050,
640x480. At 640x480, the inventory/message panel is all the way to the
left, but the hpane grab bar is visible. At default client size with no
gdefaults2 or gtk-v2.pos, the map is to small to work properly, (some map
tiles stay black) but, if the corestats are pushed down or hidden at the
bottom of the screen it is playable.
10 lines of code changed in 2 files:
Fix the handling of the standalone metaserver code, add some more information in stderr.
52 lines of code changed in 2 files:
- Replace [NULL] from response to command-line `crossfire-server -v` with the
same text that is sent back to a client when it requests server version.
- Make `crossfire-server -help` for -v option reflect actual behavior.
9 lines of code changed in 3 files:
Put the name of the glade file into the version string sent by the client.
7 lines of code changed in 3 files:
- Oh, ok, remove disfunctional scrollbars from ALL the layouts...
37 lines of code changed in 1 file:
- Remove the disfunctional scrollbars from around the map in most gtk-v2
.glade files. The layout acts better under different circumstances when
they aren't there. After all these years they've never been used, so no
point in keeping them around as they just take up space.
145 lines of code changed in 7 files:
- Remove the disfunctional scrollbars from around the map in chthonic.glade.
The layout acts better under different circumstances if they aren't there.
11 lines of code changed in 2 files:
Fix potions's name.
8 lines of code changed in 2 files:
CRE: expose 'item' as an Object instead of an Archetype to scripting engine.
30 lines of code changed in 6 files:
CRE: ac and wc as properties for objects.
17 lines of code changed in 3 files:
Display version number.
45 lines of code changed in 4 files:
- Make sure random map dungeon level numbers on signs and keys match up and
make sense. This is an off-by-one issue.
- Change mapstruct members enter_x and enter_y to sint16 since it appears that
most other server code uses sint16 types for map coordinates, and the change
results in dropping some -Wconversion warnings. Use of -1,-1 in an exit is
now the way to mark it the defaults set in the map are used without having
to set them in the exit. It may be odd to have -1,-1 in a map (mapstruct),
but it still seems better to have type consistency. Also fix up the broken
doxygen comment on these items, and add some content detail.
20 lines of code changed in 3 files:
- Extend the client theme handling by adding support for player-accessible
style file support. load_theme() is modified to always look in the player
${HOME}/.crossfire folder for a gtkrc file even when the client theme is
None. This file can serve as a player's private theme file, or could be
used just to tweak certain aspects of the client in the same way any other
.gtkrc file would. After looking for the gtkrc file, load_theme() also now
looks for a <layout>.gtkrc file. I.e. If sixforty.glade is in use, a
corresponding ${HOME}/sixforty.gtkrc is processed to make it possible to
create layout-specific adjustments. Both files have the same capabilities
as a client theme file, and, in cases where a player might not have write
access to the client theme folder, this modification allows the player to
use themes by putting them in the .crossfire folder, albeit under fixed
names. This also sets up a mechanism by which the client could one day
actually actively maintain (write/update) per-user GTK rc files, but the
current goal is primarily to make it easier to customize the client's
presentation without having to put a bunch of highly customized files in
the distribution. An in-client-selected theme is loaded last, so as to
have a higher priority than either the gtkrc or layout-specific rc files.
121 lines of code changed in 2 files:
Simplify code.
4 lines of code changed in 2 files:
- Remove the skills/experience table from these layout as a result of the new
skills window. A significant design point for both of these layouts was to
try to remove the vertical space constraints that the skills & experience
information placed on the layout when it was used on smaller displays.
- Update the AUTHORS notes for both of these layouts.
142 lines of code changed in 4 files:
- Remove the skills/experience table from the chthonic layout as a result of
the new skills window. At least one user desires this change also.
- Give meaningful names to various chthonic widgets that had generic names.
- Add a note to the AUTHORS file that notes a minor save/restore issue with
the protections/core statistics notebook area in the lower right corner
of the chthonic layout. It seems as though nesting hpaned or vpaned within
each other may be part of why some layouts have restore issues that need to
be dealt with.
121 lines of code changed in 3 files:
- Fix sixforty.glade issue with spinbutton_count to avoid run-time message
regarding non-zero page size.
- Remove the sixforty.glade table_skills_exp and enclosing structures now that
the skills window is available.
- Add note to AUTHORS that sixforty.glade has save/restore window position
issues at this time. This issue has been present prior to this, so until it
is fixed, just document it as a known issue so it doesn't get forgotten
(again). Also do not mention a map dimension less than allowed (8 vs.
minimum 11), and add mention of use of map and icon scale to improve
usability.
32 lines of code changed in 2 files:
Remove attacktype paralyze from level 6 monsters.
2 lines of code changed in 2 files:
CRE: export attack types values to scripting.
52 lines of code changed in 7 files:
CRE: export attacktype to scripting.
10 lines of code changed in 3 files:
CRE: display items count, and if filtered total count.
40 lines of code changed in 2 files:
Fix unit test for accounts when tmp files are still around.
9 lines of code changed in 2 files:
Fix invalid attack roll handling in easy cases.
4 lines of code changed in 2 files:
Remove blank line.
0 lines of code changed in 4 files:
Remove invalid item type.
0 lines of code changed in 3 files:
Inform players when drinking a cursed potion.
1 lines of code changed in 1 file:
Ingredients for formulae.
12 lines of code changed in 2 files:
CRE: export some properties for formulae.
42 lines of code changed in 4 files:
- Update the description of oroboros.glade. Removed the skills and experience
table per creation of the new skills window. This allowed the four tab
notebook in the top right to change to 2 tabs to improve accessibility of
vital statistics. This redesign also seems to improve the sizability of the
client, possibly making it easier to shrink below the default 1024x768
dimensions and opening the door to improvements in other layouts.
520 lines of code changed in 3 files:
- A complete rework of the client configuration dialog to make it take up less
vertical space. Netbook users with a screen height of 600 pixels could not
access all items in the dialog. The dialog was also pretty ugly and the
controls were not organized as well as they could be. The overall design of
the dialog now matches the design principles used for the account dialogs.
- Fix up even more confusion in the ChangeLog.
881 lines of code changed in 2 files:
- Allow the table_skills_exp to be missing from a main window .glade layout
without generating stderr spew like (crossfire-client-gtk2:*): Gtk-CRITICAL
**: gtk_label_set_text: assertion `GTK_IS_LABEL (label)' failed. The new
skills window means this table is optional, so there is no point to make
noise or do extra work if it is absent from the window definition.
- Fix up some confusion in the ChangeLog.
56 lines of code changed in 2 files:
- Fix broken build (perhaps only on older gtk/libglade versions?). Replaced
gtk_widget_get_visible() with GTK_WIDGET_VISIBLE().
19 lines of code changed in 2 files:
- Yet another attempt to fix builds after disable of x11 and gtk-v1 clients.
1 lines of code changed in 1 file:
- Fix up another error. Its not fatal, but generates error messages.
1 lines of code changed in 1 file:
- Fix prior mistake.
1 lines of code changed in 1 file:
- Second attempt to fix builds after disable of x11 and gtk-v1 clients.
6 lines of code changed in 2 files:
- First attempt at disabling x11 and gtk-v1 clients.
51 lines of code changed in 2 files:
CRE: set a better progress caption.
4 lines of code changed in 2 files:
CRE: show report generation progress, enable cancelling.
19 lines of code changed in 2 files:
CRE: button to copy report contents to clipboard.
35 lines of code changed in 3 files:
CRE: expose maps to report interfaces.
35 lines of code changed in 4 files:
CRE: keep map level while we're at it.
24 lines of code changed in 4 files:
CRE: expand maps node if only maps, resize columns to meaningful size.
7 lines of code changed in 2 files:
CRE: display an empty panel by default, to force a decent size.
40 lines of code changed in 4 files:
If the player has left the skill window open whilst playing, update the exp/level values.
14 lines of code changed in 3 files:
Double-click on server name connects in server selection screen.
31 lines of code changed in 8 files:
Update tooltips for ground and inventory views when items are picked up or dropped.
60 lines of code changed in 2 files:
CRE: display the formulea's title in a combo instead of a free text.
26 lines of code changed in 2 files:
CRE: display item property in treasure panel.
8 lines of code changed in 2 files:
CRE: report definition is now managed like filters.
439 lines of code changed in 15 files:
Display tooltips near mouse location in server selection screen.
1 lines of code changed in 1 file:
CRE: wrap object name and experience.
17 lines of code changed in 3 files:
Fix possible NullPointerException.
1 lines of code changed in 1 file:
Simplify code.
1 lines of code changed in 1 file:
- Dress up the dialogs related to the account code. A few items are moved to
make better use of space, but this mostly adds containers, attributes,
padding, etc. that improves the dialog aesthetics. Orientation properties
are removed to reduce libglade spew when running on older versions. They
aren't needed anyway. The other major change is that now all widgets have
logical names.
965 lines of code changed in 2 files:
CRE: change disposition for resource window.
5 lines of code changed in 2 files:
CRE: display region information when one is selected.
148 lines of code changed in 7 files:
CRE: experience display.
75 lines of code changed in 6 files:
Add a file that was missed in the previous commit
5 lines of code changed in 2 files:
Add skills window
470 lines of code changed in 20 files:
CRE: load data in the thread, no need to freeze everything.
14 lines of code changed in 2 files:
CRE: display map name, and exits to and from.
115 lines of code changed in 7 files:
CRE improvements.
240 lines of code changed in 14 files:
Fix for bug 1845694 - improper inventory/map redraws in cache mode.
gtk-v2/src/image.c: Add a variable to track if we have gotten new images.
gtk-v2/src/image.h: Add declaration for above variable.
gtk-v2/src/main.c: If we have new images, force full map and inventory
redraws in main loop.
MSW 2010-04-11
34 lines of code changed in 4 files:
gtk-v2/src/account.c: Clear new account names/status when activating
window. Otherwise, odd to have info filled in from account
created on previous server.
MSW 2010-04-11
10 lines of code changed in 2 files:
Fix for bug 2985631 - can not create a new character if you have a long
account password. Simple solution is to just truncat password.
MSW 2010-04-11
15 lines of code changed in 2 files:
common/client.c: Mostly whitespace changes. Make minor improvment to
-download_all_faces to request 1 set more than being worked on.
common/image.c: Whitespace change - fix formatting.
common/newsocket.c: Whitespace change - fix formatting.
gtk-v2/src/image.c: Fix for bug 2938906 - don't free pixmap data when
using cache mode.
gtk-v2/src/info.c: Remove useless message about not fine (sic) color.
MSW 2010-04-11
409 lines of code changed in 6 files:
gtk-v2/src/info.c: Fix problem with crashes on some systems -
initialization was outside of for loop which set the variable. Should
fix bug 2984398.
MSW 2010-04-09
7 lines of code changed in 2 files:
Add error message and quit client if user has out of date dialog.glade file
installed. Make error_dialog non static so account.c can use this,
add check in account.c to see if we found required window, and change
order if initialization of account windows to do login window first (as
that is where the check is).
Files changed: gtk-v2/src/account.c gtk-v2/src/main.c gtk-v2/src/gtk2proto.h
MSW 2010-04-09
16 lines of code changed in 4 files:
- Follow Ragnor's suggestion. since info.h itself needs newclient.h, go with
putting the newclient.h include there instead of in main.h ahead of the
info.h include.
2 lines of code changed in 2 files:
- Fix broken compile.
1 lines of code changed in 1 file:
Add account based support to gtk2 client & common code. Remove support
for gtk1 and X11 clients
---
configure.ac: Remove check for gtk1, cfgtk2 option, X11 libraries, and
checks related to those clients.
common/client.c: Add tracking of loginmethod. Update setup to send
loginmethod, update dispatch table for new commands. Add
close_server_connection() so duplicate code does not need to be
repeated. Don't send addme command when using new login method.
common/client.h: Add globals for motd, news, rules, loginmethods,
INFO_... types.
common/commands.c: Add processing of requestinfo for motd, rules, news.
Add handling of loginmethod setup. Add call to hde_all_login_windows()
when play starts. Add FailureCmd(), AccountPlayersCmd() to handle
protocol commands.
common/init.c: Free motd/news/rules data when changing servers.
common/metaserver.c: Move meta_sort() to this file, don't make it
static - removes compiler warnings.
common/metaserver.h: Remove static declaration of meta_sort, and
function prototype for it.
common/p_cmd.c: Update do_disconnect() to use close_server_connection()
common/proto.h: Updated with new functions.
gtk-v2/glade/dialogs.glade: Add new windows for account login code.
gtk-v2/src/Makefile.am: Add account.c file.
gtk-v2/src/gtk2proto.h: Update with new functions.
gtk-v2/src/account.c: New file - does account logic.
gtk-v2/src/info.c: Change order of includes. Move some declarations
from this file to info.h. Generalize some of the handling so
other functions can use textbuffer but take advantage of the markup
processing provided in this file
gtk-v2/src/info.h: New file - declarations from info.c moved here.
gtk-v2/src/keys.c: Change order if include of main.h. Update to use
close_server_connection()
gtk-v2/src/main.c: Change order of includes. Add sample use of
custom glib log handler. Update to try and use loginmethod 1
gtk-v2/src/main.h: Add extern for csocket_fd so a bunch of
files don't have to declare it itself.
gtk-v2/src/map.c: Change ordering of includes.
gtk-v2/src/menubar.c: Update to sue close_server_connection()
gtk-v2/src/metaserver.c: change order of includes. Call
hide_all_login_windows() when bringing up metaserver window.
gtk-v2/src/opengl.c: Change order of includes.
gtk-v2/src/pickup.c: Change order of includes.
gtk-v2/src/spells.c: Change order of include of gtk2proto.h
----
MSW 2010-04-08
2908 lines of code changed in 25 files:
Added CFDataBase for handling generic python objects
57 lines of code changed in 1 file:
Add some minimal new character support. Work in progress, but added code
that at least hands off the username/password to server.
---
doc/Developers/protocol: Add some docs on createplayer protocol command.
include/sockproto.h, include/sproto.h: Update with new functions.
server/login.c: Add code to update account for new characters.
server/player.c: Make set_first_map() non static. Change add_player()
to take second argument and return the newly created player object.
Fix roll_again() output to use <> instead of [], since later are
markup commands.
socket/loop.c: Add callback for createplayer protocol command.
socket/request.c: Add create_player_cmd(). Update add_player to take
second argument.
types/savebed/savebed.c: Add warning message and prevent player from
saving if they have 0 exp and the character won't be saved.
Otherwise, it seems to work but does nothing.
---
MSW 2010-04-07
162 lines of code changed in 9 files:
- Give the keys to the House of Treasure reasonable names other than key1,
key2, and key3. These aren't secret keys anyway and there are far too
many keys that are generically named anyway. Add descriptions too.
25 lines of code changed in 4 files:
added dir to /python for handling the private shops
1281 lines of code changed in 6 files:
added newmaps dir to test, for testing new maps.
44400 lines of code changed in 45 files:
Add region.
5 lines of code changed in 2 files:
Keep rough monster experience for maps. Dump region experience after parsing.
43 lines of code changed in 5 files:
Don't send pickup information if not explicitely asked for.
6 lines of code changed in 2 files:
Fix crash potential when changing class.
7 lines of code changed in 2 files:
Fix crash if 'add_me' was sent multiple times.
8 lines of code changed in 2 files:
Commit account management code. Seems mature enough for general use - probably
a few bugs. What this adds is an account that characters use to log in,
at which point they then choose what character they want to play.
---
doc/Developers/protocol: Fix some formatting, clarify some points, make
some revisions to account protocol commands.
include/account_char.h: Move MAX_CHARACTERS_PER_ACCOUNT to this
file so other files to access it.
include/newserver.h: Add login_method to socket structure.
include/sockproto.h: Update for new functions.
include/sproto.h: Update for new functions.
lib/Makefile.am: Have it make account directory if it does not exist.
server/account.c: Fix bug related to loading when only 1 character
is associated with account. Change account_exists() to return
proper name of account. Clean up some function declarations
and bugs. Add some new functions to get character/account
data.
server/account_char.c: Fix typo and minor errors in error message.
server/c_misc.c: Update check_login() for 2 params
server/init.c: Add call to load account information.
server/login.c: Save account information. Modify check_login() for
account logins which bypass password checking.
server/player.c: Make get_player() non static. Add enhancements
for new login code in play again.
socket/init.c: initialize login_method to 0.
socket/loop.c: Add new protocol commands with callbacks.
socket/request.c: Add loginmethod setup command. Add several new functions
to handle account management functionality.
test/unit/server/check_account.c: Update for new return semantics for
account_exists()
---
MSW 2010-04-06
879 lines of code changed in 17 files:
Fix invalid variable declarations.
2 lines of code changed in 1 file:
- Convert tooltip_text fields to tooltip fields as mwedel reports that newer
versions of glade3 have issues with it (though the version I have does not).
- Remove has_tooltip settings not needed by the tooltip fields.
- Make sure all the tooltips have a Translatable property.
16 lines of code changed in 2 files:
Remove SpellsManager.getSpellList().
32 lines of code changed in 3 files:
Make field private.
3 lines of code changed in 3 files:
Make fields private.
31 lines of code changed in 2 files:
Merge duplicated code.
4 lines of code changed in 4 files:
Make fields private.
87 lines of code changed in 5 files:
Make variables final.
9 lines of code changed in 1 file:
Rename variable names.
22 lines of code changed in 1 file:
Whitespace changes.
4 lines of code changed in 1 file:
Remove unused code.
6 lines of code changed in 3 files:
Do not synchronize on 'this'.
124 lines of code changed in 1 file:
Fix compiler warnings.
9 lines of code changed in 1 file:
Fix possible NullPointerException in 'watch' script comment.
3 lines of code changed in 2 files:
Add assert statements.
3 lines of code changed in 2 files:
Fix possible NullPointerException.
3 lines of code changed in 1 file:
Add assert statements.
3 lines of code changed in 1 file:
Add assert statement; merge duplicated code.
4 lines of code changed in 1 file:
Add @Nullable annotation.
1 lines of code changed in 1 file:
Add assert statements.
4 lines of code changed in 1 file:
Do not synchronize on this; add proper synchronization for all listeners.
28 lines of code changed in 1 file:
Add @NotNull annotation.
1 lines of code changed in 1 file:
Do not synchronize on class.
8 lines of code changed in 1 file:
Clean up code for application termination.
29 lines of code changed in 3 files:
Show tooltips for checkbox options.
13 lines of code changed in 2 files:
Remove unused code.
8 lines of code changed in 10 files:
Add assert statement.
1 lines of code changed in 1 file:
Remove redundant throws clause.
1 lines of code changed in 1 file:
Remove unused code.
3 lines of code changed in 1 file:
Make function private.
1 lines of code changed in 1 file:
Declare variable more local.
1 lines of code changed in 1 file:
Make constructors private.
2 lines of code changed in 1 file:
Weaken types.
8 lines of code changed in 3 files:
Rename function name.
5 lines of code changed in 2 files:
Remove JXCWindowRenderer.getElementListener().
10 lines of code changed in 2 files:
Convert ShortcutsLoader into utility class.
17 lines of code changed in 4 files:
Rename ShortcutsManager to ShortcutsLoader.
202 lines of code changed in 4 files:
Order import statements.
1 lines of code changed in 1 file:
Move code to load or save shortcuts from Shortcuts to ShortcutsManager.
142 lines of code changed in 2 files:
Remove ShortcutsManager.getShortcuts().
9 lines of code changed in 3 files:
Move Shortcuts construction out of ShortcutsManager constructor.
6 lines of code changed in 2 files:
Remove GuiManager.getTooltipManager().
8 lines of code changed in 2 files:
Remove unused code.
2 lines of code changed in 2 files:
Remove GuiManager.setConnection().
6 lines of code changed in 2 files:
Remove GuiManager.getCommands().
5 lines of code changed in 2 files:
Remove GuiManager.getKeybindingsManager().
2 lines of code changed in 2 files:
Remove GuiManager.initRendering().
1 lines of code changed in 2 files:
Remove GuiManager.getCommandCallback().
104 lines of code changed in 2 files:
Remove dependency TooltipManager -> JXCWindowRenderer.
18 lines of code changed in 4 files:
Move code to create objects out of JXCWindow constructor.
30 lines of code changed in 2 files:
Mark MouseTracker.init() as deprecated.
1 lines of code changed in 1 file:
Remove JXCWindow.init().
5 lines of code changed in 2 files:
Move code out of JXCWindow's constructor.
3 lines of code changed in 1 file:
Remove JXCWindow.getWindowRenderer().
14 lines of code changed in 2 files:
Move MouseTracker construction out of JXCWindow constructor.
9 lines of code changed in 2 files:
Remove dependency of JXCWindowRenderer's constructor to JXCWindow.
37 lines of code changed in 2 files:
- LOG message for spellmon FALSE is changed from WARNING to INFO. It's not
clear that a server's failure to support spellmon is really that bad. It
mostly seems to mean that spell information dialog will not be populated.
Also with the addition of spellmon 2, it is normal for older servers to not
support it, so that does not seem to warrant the error being a warning
anymore.
7 lines of code changed in 2 files:
- Add debugged trunk server code for spellmon 2 request to handle the extended
data in AddspellCmd(). The extended information is currently not exposed
to the user interface, but this commit makes it available.
- The original idea to look at data on the fly instead of tracking spellmon
command response did not work out. It turns out to be very easy to
track server response anyway, so there is not much point in trying to
figure things out dynamically.
- These changes have been tested on old and new servers - including logging in
and out of each on the same client session. The data in the Spell struct
has been confirmed to hold data (by testing with spells found in the
test/spell_requirements map).
51 lines of code changed in 3 files:
In query dialog, do not overwrite text with quit messages from other characters.
26 lines of code changed in 4 files:
Make server selection using Up/Down keys work again in server selection screen.
5 lines of code changed in 3 files:
Fix status dialog to correctly display boosted/depleted/increased/decreased stats.
33 lines of code changed in 4 files:
Add support for CS_STAT_APPLIED_xyz stat values.
101 lines of code changed in 10 files:
Add more extended statistics information: applied stats. These allow clients to distinguish between depleted stats and stat changes due to gear or skills.
30 lines of code changed in 5 files:
Remove trailing whitespace; fix typos.
5 lines of code changed in 1 file:
Document missing stat constants in skin definition files.
14 lines of code changed in 1 file:
Report "watch stats pow_race" and "watch stats pow_base" to scripts.
5 lines of code changed in 2 files:
Fix typo.
1 lines of code changed in 1 file:
Document list of features.
246 lines of code changed in 3 files:
Fix command history access.
6 lines of code changed in 2 files:
- Let's try that again. "silver" isn't a recognized color name and results
in a different error at server startup. The HTML RGB code for silver is
too dark anyway.
1 lines of code changed in 1 file:
- Fix [ INFO ] (spells.c::spell_get_styles) Unable to find style for
spell_normal.
- Remove some end-of-line whitespace.
24 lines of code changed in 3 files:
- Fix segfault when client requests spellmon 2.
14 lines of code changed in 2 files:
Add FAQ.
156 lines of code changed in 2 files:
Fix possible NullPointerException for invalid color specifications in skin files.
3 lines of code changed in 1 file:
Fix anchor names.
3 lines of code changed in 1 file:
Document skin file format.
1160 lines of code changed in 2 files:
Extract code into functions.
105 lines of code changed in 1 file:
Rename -N command-line option to -n. Add --no-full-screen option as alias for -n.
7 lines of code changed in 2 files:
Rename -S command-line option to -s. Add --skin option as alias for -s.
9 lines of code changed in 2 files:
Remove unused code.
0 lines of code changed in 1 file:
Allow any label_* element for title display in book.skin.
1 lines of code changed in 1 file:
Make function public.
1 lines of code changed in 1 file:
Commit some changes for values used in new login - this is
used in the accountplayers protocol command, but is committed
right now so my client svn:externals will pick it up.
MSW 2010-04-01
13 lines of code changed in 1 file:
- Reformat of some comments to ~ 80 cols to reduce vertical text spacing.
Some tab-->space conversion done in the reformatted comments.
- Fix some spelling/grammar issues in comments, and improve readability in
various places.
- Fill out the doxygen comments to the Spell structure by adding information
found in the server documentation of the protocol.
- Add usage and requirements members to the Spell structure that will support
the spellmon 2 extended information.
- Convert some variable comments to doxygen style.
- Add a TODO at the spot where spellmon 2 will be requested when the code is
ready.
- Update SetupCmd() to get ready to handle spellmon 2. Non-functional changes
are comment reformatting/rewriting, and addition of spellmon 2 comments.
Code change to separate darkness and spellmon done, but presently no actual
functional change occurs except there is a minor duplication of an identical
LOG() call.
- Update AddspellCmd() to get ready to handle spellmon 2. Non-functional
changes are comment reformatting/rewriting/addition. Stubs are added
to initialize the spellmon 2 data fields in the Spell structure.
237 lines of code changed in 4 files:
- Remove duplicate initializer.
4 lines of code changed in 2 files:
Fix invalid function call. Add function prototypes.
8 lines of code changed in 3 files: